Skip to main content

Browse the archive

https://github.com/angular/angular
07 August 2024, 03:31:07 UTC
sort by:
Revision Author Date Message Commit Date
7ab7181 Dylan Hunn 25 March 2022, 19:40:11 UTC release: cut the v14.0.0-next.9 release (#45442) PR Close #45442 25 March 2022, 19:41:33 UTC
78eace6 Paul Gschwendtner 24 March 2022, 20:04:16 UTC build: shorten partial compilation test case target names for windows (#45431) Shortens the partial compilation test case target names as the paths/ manifest paths in Bazel became too large, exceeding some Windows path length limits. Relevant context/resources: * https://angular-team.slack.com/archives/C02PARQNMC1/p1648137933069659 (internal) * https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd * https://github.com/bazelbuild/rules_nodejs/pull/3215/files#r782271592 PR Close #45431 25 March 2022, 19:18:34 UTC
fed7630 Paul Gschwendtner 24 March 2022, 19:23:53 UTC ci: improve stability of windows bazel CI job (#45431) Improves stability of the Windows Bazel CI job by installing Bazelisk globally. Also makes the environment helpers more convenient by evaluating the variable assignments directly, simplifying some Bash logic. PR Close #45431 25 March 2022, 19:18:34 UTC
a7c81da Paul Gschwendtner 24 March 2022, 18:54:58 UTC ci: dedupe top-level yarn install in circleci config (#45431) Dedupes the Yarn run steps, avoiding the need to manually keep this step in sync (e.g. with the timeout -- which is currently missing for the windows job) PR Close #45431 25 March 2022, 19:18:34 UTC
9e3e970 Paul Gschwendtner 24 March 2022, 16:58:38 UTC test: refactor compiler-cli compliance test to work on windows (#45431) Recent changes in `rules_nodejs` caused the test case copy file actions to be transitioned into the `exec` configuration, resulting in much larger file paths. These paths break on Windows with the shell argument limit, and with the path limit, causing errors like: ``` ERROR: C:/users/circleci/ng/packages/compiler-cli/test/compliance/test_cases/BUILD.bazel:9:12: Copying file packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/components_and_directives/value_composition/structural_directives_if_directive_def.js failed: (Exit 1): cmd.exe failed: error executing command cd /d C:/users/circleci/_bazel_circleci/u4uoan2j/execroot/angular SET PATH=C:\Program Files\Git\usr\bin;C:\Program Files\Git\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0 SET RUNFILES_MANIFEST_ONLY=1 cmd.exe /C bazel-out\x64_windows-opt-exec-2B5CBBC6\bin\packages\compiler-cli\test\compliance\test_cases\test_cases--1973427149-cmd.bat The system cannot find the path specified ``` https://app.circleci.com/pipelines/github/angular/angular/44038/workflows/4b530cb2-f232-4e1d-b35a-e6e085151d08/jobs/1140017 PR Close #45431 25 March 2022, 19:18:34 UTC
a48683b Paul Gschwendtner 23 March 2022, 19:40:28 UTC ci: make windows circleci job more robust and use git bash (#45431) It is totally fine, and expected to use Git Bash for running Bazel on Windows. In fact this is the most common setup for Bazel on Windows and it's unrealistic to run without it. This allows us to remove the old/legacy Powershell setup from CI which is also quite flaky sometimes and does not reproduce how Bazel is used on windows-users dev machines. PR Close #45431 25 March 2022, 19:18:34 UTC
b1fadbd Paul Gschwendtner 23 March 2022, 13:42:29 UTC ci: temporarily disable components-repo-unit-tests job for Bazel NodeJS v5 update (#45431) The Angular components repository can only start using Bazel Rules NodeJS v5 when `@angular/bazel` is published with support for it. To work around this cycle we temporarily disable the unit tests job until we migrated the COMP repo as well. PR Close #45431 25 March 2022, 19:18:34 UTC
af303d9 Paul Gschwendtner 23 March 2022, 13:34:45 UTC refactor: remove unused variables in starlark code to satisfy buildifier (#45431) We updated buildifier and a few warnings became errors now. This commit cleans up the failing unused variable instances, making the linter happy. Additionally for the API extractor BUILD file, the package defaults need to move to satisfy buildifier. PR Close #45431 25 March 2022, 19:18:34 UTC
a24293a Paul Gschwendtner 22 March 2022, 19:03:39 UTC build: migrate more usages from `@bazel/typescript` to `@bazel/concatjs` (#45431) As mentioned in previous commits (check them for more details), `@bazel/typescript` no longer contains `ts_library`-specific code, so we no longer need that dependency. PR Close #45431 25 March 2022, 19:18:34 UTC
ffa331b Paul Gschwendtner 22 March 2022, 18:08:14 UTC refactor(bazel): update api-extractor to account for `@bazel/typescript` change (#45431) `@bazel/typescript` code moved to `@bazel/concatjs` for the tsc-wrapped code. Note that this code is likely going to be removed anyway soon when we move dts bundling from `ng_module` to `ng_package`. PR Close #45431 25 March 2022, 19:18:34 UTC
c56f05c Paul Gschwendtner 22 March 2022, 17:30:47 UTC build: add temporary patch to make `tsec` compatible with `rules_nodejs` v5 (#45431) Adds a temporary patch to make `tsec` compatible with `rules_nodejs` v5 until https://github.com/google/tsec/pull/25 is available/released. PR Close #45431 25 March 2022, 19:18:33 UTC
7f6859e Paul Gschwendtner 22 March 2022, 11:06:15 UTC refactor(bazel): update ngc-wrapped to account for `tsc-wrapped` move to `@bazel/concatjs` (#45431) Previously `tsc-wrapped` which is the foundation for `ngc-wrapped`, resided in `@bazel/typescript`. It has been moved to `@bazel/concatjs` in rules_nodejs so we need to account for that as part of our rules_nodejs v5 update. PR Close #45431 25 March 2022, 19:18:33 UTC
010a39f Renovate Bot 21 March 2022, 17:09:54 UTC build: update bazel (#45431) Update `@bazel` packages to the latest 5.x version. Some of the changes here are modeled after angular/dev-infra@40c0ac855975ce9586b07af3a36a0bf4e3b58350. Co-Authored-By: George Kalpakas <kalpakas.g@gmail.com> PR Close #45431 25 March 2022, 19:18:33 UTC
05cd0e0 Renovate Bot 21 March 2022, 17:09:54 UTC build: update angular to 5a82e60 (#45431) Update the `@angular/dev-infra-private` package to the latest commit. PR Close #45431 25 March 2022, 19:18:33 UTC
aed95cd Dylan Hunn 25 March 2022, 17:41:20 UTC release: cut the v14.0.0-next.8 release (#45440) PR Close #45440 25 March 2022, 17:42:59 UTC
e2eaac3 arturovt 16 March 2022, 19:45:36 UTC fix(zone.js): read `Symbol.species` safely (#45369) We must read `Symbol.species` safely because `this` may be anything. For instance, `this` may be an object without a prototype (created through `Object.create(null)`); thus `this.constructor` will be undefined. One of the use cases is SystemJS creating prototype-less objects (modules) via `Object.create(null)`. The SystemJS creates an empty object and copies promise properties into that object (within the `getOrCreateLoad` function). The zone.js then checks if the resolved value has the `then` method and invokes it with the `value` context. Otherwise, this will throw an error: `TypeError: Cannot read properties of undefined (reading 'Symbol(Symbol.species)')`. PR Close #45369 25 March 2022, 01:56:36 UTC
7a9c6f5 Renovate Bot 24 March 2022, 09:29:37 UTC build: update dependency send to ^0.18.0 (#45428) PR Close #45428 24 March 2022, 21:32:00 UTC
dc0e39a khai 18 March 2022, 09:20:35 UTC docs: update for 2022 angular events (#45386) PR Close #45386 24 March 2022, 21:29:49 UTC
4ddcf81 Tobias Speicher 20 March 2022, 10:23:47 UTC refactor: replace deprecated String.prototype.substr() (#45397) .substr() is deprecated so we replace it with functions which work similarily but aren't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com> PR Close #45397 24 March 2022, 18:48:09 UTC
0f9b3c6 mgechev 22 March 2022, 23:49:07 UTC docs: update the public roadmap (#45415) Change status of existing projects and add new projects we're working on. PR Close #45415 24 March 2022, 18:29:29 UTC
638e860 alirezaghey 17 March 2022, 11:54:58 UTC docs: small English improvement (#45375) PR Close #45375 24 March 2022, 18:24:58 UTC
be161be Kristiyan Kostadinov 22 March 2022, 11:23:13 UTC fix(core): memory leak in event listeners inside embedded views (#43075) When we have an event listener inside an embedded view, we generate a `restoreView` call which saves the view inside of the LFrame. The problem is that we don't clear it until it gets overwritten which can lead to memory leaks. These changes rework the generated code in order to generate a `resetView` call which will clear the view from the LFrame. Fixes #42848. PR Close #43075 24 March 2022, 18:05:24 UTC
71ee417 JoostK 12 March 2022, 21:08:21 UTC refactor(core): remove unused logic from reflection capabilities (#45335) This commit removes a bunch of methodss from `ReflectionCapabilities` as they have gone unused. This also removes `Reflector` as it doesn't serve any purpose and it is not exposed as public API, so can be safely removed. PR Close #45335 24 March 2022, 18:02:39 UTC
8198bb9 Renovate Bot 22 March 2022, 13:21:00 UTC build: lock file maintenance (#45402) PR Close #45402 24 March 2022, 17:57:25 UTC
f671dd5 George Kalpakas 18 March 2022, 19:47:16 UTC fix(docs-infra): update (and unpin) dependency versions for preview server (#45390) Update the `Dockerfile` used to create the preview server to use the latest stable version of Debian (`bullseye`) and also update package versions to latest versions. Also, unpin the versions of installed packages (except for Node.js related ones) as pinning proved problematic due to many packages removing old versions from the official repositories. NOTE: This change will allow the preview server to be updated on the VM and take advantage of recent fixes, such as #45349. Currently, the update fails with the error: ``` E: Version '7.64.0-4+deb10u1' for 'curl' was not found The command '/bin/sh -c apt-get update -y && apt-get install -y curl=7.64.0-4+deb10u1' returned a non-zero code: 100 ``` PR Close #45390 24 March 2022, 17:53:58 UTC
f19b36f Krzysztof Platis 18 March 2022, 23:14:04 UTC fix(zone.js): in TaskTrackingZoneSpec track a periodic task until it is cancelled (#45391) Before this change, the macrotask for `setInterval(callback, ms)` was no longer tracked by `TaskTrackingZoneSpec` after the `callback` was invoked for the first time. Now the periodic macrotask is tracked until it is cancelled, e.g. `clearInterval(id)`. BREAKING CHANGE: in TaskTrackingZoneSpec track a periodic task until it is cancelled The breaking change is scoped only to the plugin `zone.js/plugins/task-tracking`. If you used `TaskTrackingZoneSpec` and checked the pending macroTasks e.g. using `(this.ngZone as any)._inner ._parent._properties.TaskTrackingZone.getTasksFor('macroTask')`, then its behavior slightly changed for periodic macrotasks. For example, previously the `setInterval` macrotask was no longer tracked after its callback was executed for the first time. Now it's tracked until the task is explicitly cancelled, e.g with `clearInterval(id)`. fixes 45350 PR Close #45391 24 March 2022, 17:53:36 UTC
c7bcc1b arturovt 19 March 2022, 01:17:03 UTC fix(zone.js): check if `process` is defined when patching the `GlobalErrors.install` (#45392) Jasmine checks internally if `process` and `process.on` is defined. Otherwise, it installs the browser rejection handler through the `global.addEventListener`. This code may be run in the browser environment where `process` is not defined, and this will lead to a runtime exception since Webpack 5 removed automatic Node.js polyfills. PR Close #42260 PR Close #45392 24 March 2022, 17:52:34 UTC
dc72f30 Paul Gschwendtner 19 March 2022, 07:55:32 UTC fix(bazel): ng module compilation workers are subject to linker race-conditions (#45393) The Bazel NodeJS rules provide two ways of accessing node modules: * A linker which creates a `node_modules` directory in the execroot/or in the runfiles. * A patched module resolution where no node modules directory necessarily needs to exist. The first is the default in `rules_nodejs` and the second is technically the most idiomatic resolution mechanism in Bazel (as it matches with a runfile resolution library). The linker is prone to race conditions in persistent workers, or non-sandbox environments (like windows). This is because the linker for all workers will operate on a shared `execroot` directory and the same `node_modules` directory is modified all the time / potentially conflicting with other linker processes from other concurrently-running workers. We rely on the patched module resolution anyway, but just need to disable the unused linker to avoid issues like the following: ``` ---8<---8<--- Start of log, file at /private/var/tmp/_bazel_splaktar/280f06d55552a0d01f89f0955b5acd78/bazel-workers/worker-8-TypeScriptCompile.log ---8<---8<--- [link_node_modules.js] An error has been reported: [Error: ENOENT: no such file or directory, unlink 'node_modules'] { errno: -2, code: 'ENOENT', syscall: 'unlink', path: 'node_modules' } Error: ENOENT: no such file or directory, unlink 'node_modules' ---8<---8<--- End of log ---8<---8<--- INFO: Elapsed time: 12.796s, Critical Path: 5.39s INFO: 645 processes: 477 internal, 12 darwin-sandbox, 156 worker. ``` PR Close #45393 24 March 2022, 17:52:12 UTC
c9d566c Kristiyan Kostadinov 19 March 2022, 15:05:24 UTC feat(core): drop support for TypeScript 4.4 and 4.5 (#45394) Drops support for TypeScript older than 4.6 and removes some workarounds in the compiler. BREAKING CHANGE: TypeScript versions older than 4.6 are no longer supported. PR Close #45394 24 March 2022, 17:51:47 UTC
0dca774 George Kalpakas 22 March 2022, 08:48:07 UTC build(docs-infra): upgrade cli command docs sources to c0a0bfb65 (#45408) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/bff1908b4...c0a0bfb65): **Modified** - help/add.json PR Close #45408 24 March 2022, 17:50:19 UTC
fc97499 Alan Agius 22 March 2022, 13:11:04 UTC build(docs-infra): remove `defaultProject` workspace option (#45410) The `defaultProject` workspace option has been deprecated. The project to use will be determined from the current working directory. See: https://github.com/angular/angular-cli/pull/22852 PR Close #45410 24 March 2022, 17:49:57 UTC
5ff459e Alan Agius 22 March 2022, 13:09:18 UTC test: remove `defaultProject` workspace option (#45410) The `defaultProject` workspace option has been deprecated. The project to use will be determined from the current working directory. See: https://github.com/angular/angular-cli/pull/22852 PR Close #45410 24 March 2022, 17:49:57 UTC
85782e6 Mike 22 March 2022, 14:53:05 UTC docs(router): Fix typo on segments (#45411) PR Close #45411 24 March 2022, 17:49:35 UTC
fe0e42a Dylan Hunn 23 March 2022, 18:28:04 UTC fix(forms): Make UntypedFormBuilder assignable to FormBuilder, and vice versa. (#45421) There was a subtle bug involving the opt-out class for FormBuilder, which I discovered during the ongoing migration. The types must be structurally the same, because people pass around FormBuilders, in addition to passing around the controls they produce. This PR ensures FormBuilder and UntypedFormBuilder are assignable to each other. PR Close #45421 24 March 2022, 17:49:10 UTC
38ad849 Joey Perrott 23 March 2022, 17:16:20 UTC fix(docs-infra): prevent framing of AIO with X-Frame-Options (#45419) Prevent the docs site from being place in an iframe. PR Close #45419 23 March 2022, 19:20:49 UTC
8155428 Alex Rickabaugh 09 February 2022, 01:09:20 UTC perf(compiler-cli): ignore the module.id anti-pattern for NgModule ids (#45024) In early versions of Angular, it was sometimes necessary to provide a `moduleId` to `@Component` metadata, and the common pattern for doing this was to set `moduleId: module.id`. This relied on the bundler to fill in a value for `module.id`. However, due to the superficial similarity between `Component.moduleId` and `NgModule.id`, many users ended up setting `id: module.id` in their NgModules. This is an anti-pattern that has a few negative effects, including preventing the NgModule from tree-shaking properly. This commit changes the compiler to ignore `id: module.id` in NgModules, and instead provide a warning which suggests removing the line entirely. PR Close #45024 22 March 2022, 18:11:54 UTC
34c5b7a Alex Rickabaugh 09 February 2022, 01:26:40 UTC refactor(compiler-cli): support non-error diagnostics from traits (#45024) Previously, the `TraitCompiler` would naively consider a compilation as failed if either analysis or resolution produced any diagnostics. This commit adjusts the logic to only consider error diagnostics, which allows warnings to be produced from `DecoratorHandler`s. This is a precursor commit to introducing such a warning. As such, the logic here will be tested in the next commit. PR Close #45024 22 March 2022, 18:11:53 UTC
27b4af7 Alex Rickabaugh 11 February 2022, 22:58:00 UTC fix(compiler-cli): full side-effectful registration of NgModules with ids (#45024) Angular contains an NgModule registry, which allows a user to declare NgModules with string ids and retrieve them via those ids, using the `getNgModuleById` API. Previously, we attempted to structure this registration in a clever fashion to allow for tree-shaking of registered NgModules (that is, those with ids). This sort of worked due to the accidental alignment of behaviors from the different tree-shakers involved. However, this trick relies on the generation of `.ngfactory` files and how they're specifically processed in various bundling scenarios. We intend to remove `.ngfactory` files, hence we can no longer rely on them in this way. The correct solution here is to recognize that `@NgModule({id})` is inherently declaring a global side-effect, and such classes should not really be eligible for tree-shaking in the first place. This commit removes all the old registration machinery, and standardizes on generating a side- effectful call to `registerNgModuleType` for NgModules that have ids. There is some risk here that NgModules with unnecessary `id`s may not tree-shake as a result of this change, whereas they would have in previous circumstances. The fix here should be to remove the `id` if it's not needed. Specifying an `id` is a request that the NgModule be retained regardless of any other references, in case it is later looked up by string id. PR Close #45024 22 March 2022, 18:11:53 UTC
e57b410 Alex Rickabaugh 10 February 2022, 01:36:33 UTC refactor(compiler-cli): linker honors associated statements for a field (#45024) When `@angular/compiler` processes metadata and compiles a definition field, it might also choose to return statements that are associated with that definition, and should be included after the type being compiled. Currently, the linker ignores these statements, as there are none generated that are relevant in the linking operation. A challenge to supporting such associated statements is that the linker operates on "declare" expressions, and replaces those expressions with other expressions. It does not have the capability to append statements after the whole type. The linker actually faces this challenge with statements from the `ConstantPool` as well, and solves this problem by generating an IIFE expression that executes the statements and then returns the definition expression. Previously, an `EmitScope` processed the definition and converted it to an expression, as well as collected constant statements from a `ConstantPool`. A special `IifeEmitScope` implementation was used when emitting into a context where top-level constant statements couldn't be added at all, and uses the IIFE strategy in this case. This commit adds blanket support for associated statements to the linker using this IIFE strategy. The main `EmitScope` now uses the IIFE strategy to emit associated statements, and `IifeEmitScope` has been renamed to `LocalEmitScope`. Now, the `LocalEmitScope` represents constant statements as associated statements to the main `EmitScope` implementation, so they get included in the IIFE as well. Tests are adjusted/added to cover this new behavior. This is a refactoring commit because no live generated code is affected - there are no cases where associated statements are present in linked definitions today. PR Close #45024 22 March 2022, 18:11:53 UTC
72e7d09 Alex Rickabaugh 10 February 2022, 23:31:10 UTC refactor(compiler): change NgModule scoping emit flag to enum (#45024) The `compileNgModule` operation previously supported a flag `emitInline`, which controlled whether template scoping information for the NgModule was emitted directly into the compiled NgModule definition, or whether an associated statement was generated which patched the information onto the NgModule definition. Both options are useful in different contexts. This commit changes this flag to an enum (and renames it), which allows for a third option - do not emit any template scoping information. This option is added to better represent the actual behavior of the Angular Linker, which sometimes configures `compileNgModule` to use the side-effectful statement generation but which does not actually emit such associated statements. In other words, the linker effectively does not generate scoping information for NgModules at all (in some configurations) and this option more directly expresses that behavior. This is a refactoring as no generated code is changed as a result of introducing this flag, due to the linker's behavior of not emitting associated statements. PR Close #45024 22 March 2022, 18:11:53 UTC
9d8ff5d Renovate Bot 21 March 2022, 23:36:57 UTC build: update dependency @types/chrome to ^0.0.180 (#45357) PR Close #45357 21 March 2022, 23:59:56 UTC
6507150 George Kalpakas 19 March 2022, 08:46:41 UTC build(docs-infra): upgrade cli command docs sources to bff1908b4 (#45395) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/a517160a2...bff1908b4): **Added** - help/cache.json **Modified** - help/add.json - help/analytics.json - help/build.json - help/config.json - help/deploy.json - help/doc.json - help/e2e.json - help/extract-i18n.json - help/generate.json - help/lint.json - help/new.json - help/run.json - help/serve.json - help/test.json - help/update.json - help/version.json ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/207de70b7...bff1908b4) since PR #45385: **Added** - help/cache.json **Modified** - help/config.json ## Closes #45330 Closes #45346 Closes #45361 Closes #45385 PR Close #45395 21 March 2022, 23:58:00 UTC
15dbb4d Ben Brook 09 March 2022, 19:56:19 UTC docs(docs-infra): fix TypeScript casing (#45307) PR Close #45307 21 March 2022, 23:57:11 UTC
b716a81 Alan Agius 21 March 2022, 17:36:00 UTC docs: replace `defaultCollection` with `schematicCollections` (#45406) `defaultCollection` has deprecated in favor of `schematicCollections`. Related to https://github.com/angular/angular-cli/pull/22860 PR Close #45406 21 March 2022, 23:56:10 UTC
e80df0d Paul Gschwendtner 21 March 2022, 20:27:51 UTC build: update to bazel v5 for new runfiles API used in dev-infra (#45407) https://blog.bazel.build/2022/01/19/bazel-5.0.html#starlark-build-language PR Close #45407 21 March 2022, 23:55:36 UTC
fffa023 JoostK 19 March 2022, 14:08:15 UTC fix(compiler): scope css rules within `@layer` blocks (#45396) This commit starts scoping CSS rules nested within `@layer` blocks. Fixes #45389 PR Close #45396 21 March 2022, 21:51:45 UTC
aec9abd Alan Agius 15 March 2022, 06:44:55 UTC fix(docs-infra): don't wrap subcommands in code element (#45343) With this change we no longer wrap subcommands titles and sub navigation items in code element for nicer UI PR Close #45343 21 March 2022, 21:49:27 UTC
c26915c Dylan Hunn 10 March 2022, 02:48:52 UTC refactor(core): Make the typed forms migration apply to all usages of the symbols. (#45311) Previously, the migration only migrated constructor calls. Now, the migration will rewrite every usage, in all contexts. Both ways are technically correct, but migrating all symbols is likely to produce clearer and more readable results. PR Close #45311 21 March 2022, 21:40:59 UTC
79d334b dario-piotrowicz 27 February 2022, 17:55:53 UTC feat(animations): provide warnings for non-animatable CSS properties (#45212) warn developers when they are trying to animate non-animatable CSS properties so that can more easily understand why something is not being animated as they would expect it to resolves #27577 PR Close #45212 21 March 2022, 21:33:19 UTC
a049840 Joey Perrott 14 March 2022, 20:14:03 UTC build(docs-infra): move to circleci v2 api for aio-builds (#45349) Move to the CircleCI v2 api as the authentication fails for downloading artifacts using the v1 methods. CircleCI v2 api now requires authentication to occur view the headers instead of being done in a query parameter, all of the CircleCI interactions are now performed through one fetchFromCircleCi method which ensures the token is provided in the headers as expected. PR Close #45349 17 March 2022, 21:03:26 UTC
2a75754 Kristiyan Kostadinov 13 March 2022, 10:37:59 UTC fix(animations): apply default params when resolved value is null or undefined (#45339) The animations package supports adding default parameter values to an animation that will be used as a fallback if some parameters aren't defined. The problem is that they're applied using a spread expression which means that any own property of the animation parameters will override the defaults, even if it resolves to null or undefined. This can lead to obscure errors like "Cannot read property toString of undefined" for an animation that looks like `{params: {foo: undefined}}` with defaults `{foo: 123}`. I ran into this issue while debugging some test failures on Material. These changes address the issue by: 1. Applying the defaults if the resolved value is null or undefined. 2. Updating the validation function to use a null check instead of `hasOwnProperty`. PR Close #45339 17 March 2022, 21:02:37 UTC
59a5b54 AlirezaEbrahimkhani 14 March 2022, 15:50:41 UTC docs: add how to access the resolved data (#45345) complete resolver example and add how to access the resolved data in component resolves angular#45313 PR Close #45345 16 March 2022, 22:05:24 UTC
9d5ad67 Renovate Bot 16 March 2022, 05:36:34 UTC build: lock file maintenance (#45341) PR Close #45341 16 March 2022, 21:36:28 UTC
2b6749f Andrew Scott 16 March 2022, 19:41:35 UTC release: cut the v14.0.0-next.7 release (#45368) 16 March 2022, 19:41:35 UTC
34c48a3 Andrew Scott 16 March 2022, 19:27:54 UTC docs: release notes for the v13.3.0 release (#45366) 16 March 2022, 19:27:54 UTC
306fb5e Andrew Scott 16 March 2022, 18:35:43 UTC docs: release notes for the v13.2.7 release (#45364) 16 March 2022, 18:35:43 UTC
3ad033c Renovate Bot 16 March 2022, 05:32:34 UTC build: update github/codeql-action action to v1.1.5 (#45358) PR Close #45358 16 March 2022, 18:21:45 UTC
e47ba49 why520crazy 15 March 2022, 02:06:50 UTC docs: add ngx-gantt to "EXPLORE ANGULAR RESOURCES" page (#45351) PR Close #45351 15 March 2022, 23:29:23 UTC
9db9091 Amer Yousuf 24 February 2022, 14:01:19 UTC fix(forms): improve error message for invalid value accessors (#45192) improve error message for invalid value accessors when accessor is not provided as array PR Close #45192 15 March 2022, 20:26:03 UTC
8a7e624 Lee Cooper 11 March 2022, 00:20:58 UTC fix(docs-infra): fix tour of heroes global styles (#45329) fix button styles in src/styles.css that are missing from code snippets PR Close #45329 15 March 2022, 20:24:52 UTC
c12b327 alirezaghey 14 March 2022, 09:21:17 UTC docs: fix small English typo (#45340) PR Close #45340 14 March 2022, 20:10:19 UTC
c305112 Andrew Scott 11 March 2022, 00:20:52 UTC docs: Fix typo in issue template (#45327) PR Close #45327 14 March 2022, 16:31:01 UTC
22d1dc0 Derek Cormier 13 January 2022, 23:43:39 UTC build(bazel): add bazel build and test targets for aio build (#45022) First step towards a migration of aio to bazel. Not yet built by ci. PR Close #45022 14 March 2022, 16:25:34 UTC
0dbd50b Renovate Bot 12 March 2022, 10:38:13 UTC build: update dependency eslint-plugin-jsdoc to v38 (#45332) PR Close #45332 14 March 2022, 16:23:42 UTC
7f043c9 Alan Agius 09 March 2022, 19:22:37 UTC build(docs-infra): upgrade cli command docs sources to a517160a2 (#45225) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). PR Close #45225 10 March 2022, 23:51:18 UTC
34218ec Alan Agius 04 March 2022, 16:21:53 UTC feat(docs-infra): remove hidden commands processor (#45225) Hidden commands are no longer included in help JSON output. PR Close #45225 10 March 2022, 23:51:18 UTC
8f06fa3 Alan Agius 02 March 2022, 08:49:57 UTC feat(docs-infra): update CLI templates to match changes with new parser and folder structure (#45225) The underlying parser that the CLI uses changed which caused minor changes in the generated JSON helps especially for subcommands. The folder structure of the Angular CLI repo also changed slightly. More context: https://github.com/angular/angular-cli/pull/22778 PR Close #45225 10 March 2022, 23:51:18 UTC
5f7c4f6 Jessica Janiuk 09 March 2022, 17:32:26 UTC refactor(core): Switch over to new closure LOCALE vs getLocale() (#45302) This is a change requested via an LSC due to a deprecation. PR Close #45302 10 March 2022, 20:48:29 UTC
8848d2d Paul Gschwendtner 10 March 2022, 19:46:50 UTC docs: add manual changelog edits from `13.3.x` to main branch (#45323) Adds the manual changelog edits from the `13.3.x` branch to the main branch (where users primarily will look at). PR Close #45323 10 March 2022, 20:08:26 UTC
79580bb Andrew Scott 10 March 2022, 19:31:59 UTC docs: release notes for the v13.3.0-rc.0 release (#45322) 10 March 2022, 19:31:59 UTC
a08ea3f Andrew Scott 09 March 2022, 19:48:19 UTC refactor(router): Make a few adjustments to createUrlTree for clarity (#45306) * `tree` function now accepts the old root rather than the old `UrlTree`. The `urlTree` argument was only used to get the `root`. This change makes it more clear what that pararmeter is used for and what's actually being used * Move the `oldRoot` (previously `urlTree`) to be the first argument of `tree`. This change now mirrors the argument order for `replaceSegment` and can be read from left to right more easily "in this root, replace this old segment group with this new segment group". * Extract `newRoot` to a variable. This just makes it more clear what's going on at the end rather than combining a bunch of operations into one. These changes are being made so that hopefully a future refactor can be done which does not rely on the `urlTree` argument at all in the `createUrlTree` function. These refactorings will make it easier to see 1:1 functionlity in these various places. PR Close #45306 09 March 2022, 21:52:38 UTC
2e2c80a Alistair Kane 12 February 2022, 19:52:06 UTC docs: update <div> to <p> in lifecycle-hooks.md (#45063) Changes <div> to <p> in description to match the elements in the screenshot. Update lifecycle-hooks.md Changes <div> to <p> in description to match the elements in the screenshot. PR Close #45063 09 March 2022, 21:52:15 UTC
c7cab69 JiaLiPassion 06 March 2022, 12:13:40 UTC docs(core): update triggerEventHandler samples (#45279) PR Close #45279 09 March 2022, 21:51:54 UTC
225e4f2 JiaLiPassion 06 March 2022, 12:11:16 UTC feat(core): triggerEventHandler accept optional eventObj (#45279) Close #44724 `DebugNode.triggerEventHandler()` should accept the `eventObj` as an optional parameter. So the user don't have to write code like ``` elem.triggerEventHandler('click', null); ``` PR Close #45279 09 March 2022, 21:51:54 UTC
89d71b5 Andrew Kushnir 09 March 2022, 19:31:22 UTC docs: update CHANGELOG to fix broken markdown (#45305) PR Close #45305 09 March 2022, 21:51:26 UTC
a301b36 Andrew Kushnir 09 March 2022, 17:04:59 UTC release: cut the v14.0.0-next.6 release (#45301) 09 March 2022, 17:04:59 UTC
51b67eb Andrew Kushnir 09 March 2022, 17:02:09 UTC docs: release notes for the v13.2.6 release (#45300) 09 March 2022, 17:02:09 UTC
be220fa Andrew Scott 08 March 2022, 21:32:31 UTC fix(language-service): Prioritize Angular-specific completions over DOM completions (#45293) When authoring Angular templates, developers are likely to be most interested in the current Directive/Component inputs and outputs, then potential attributes which would match other directives to the element, and lastly the plethora of DOM events and attributes. This change ensures that Angular-specific information appears above DOM information by prepending the first printable ASCII characters to the sort text. Fixes https://github.com/angular/vscode-ng-language-service/issues/1537 PR Close #45293 08 March 2022, 22:48:37 UTC
dc6094a Paul Gschwendtner 08 March 2022, 11:40:37 UTC ci: update payload size goldens to reflect zone.js update (#45289) ZoneJS has been updated as part of the lock file refresh by Renovate. The polyfills bundle reduced in size by around 4k which is due to some code simplication in ZoneJS being finally released. This is the commit responsible for the major reduction (also mentioning the reduction): https://github.com/angular/angular/commit/0f298a13dbd141e5440d1388b124d03384641efe PR Close #45289 08 March 2022, 21:15:14 UTC
6d240c4 Renovate Bot 08 March 2022, 06:44:43 UTC build: lock file maintenance (#45289) Refreshes the lock file through Renovate. PR Close #45289 08 March 2022, 21:15:13 UTC
e78a928 Andrew Scott 08 March 2022, 16:46:25 UTC refactor(migrations): update `isReferenceToImport` to not use `valueDeclaration` (#45292) valueDeclaration is only set when the Symbol type is a `Value`: * [setValueDeclaration](https://sourcegraph.com/github.com/microsoft/TypeScript@d8b21a8d6cef772fea5cf2a507b651c5d38194bd/-/blob/src/compiler/binder.ts?L321-322) * [Value union](https://sourcegraph.com/github.com/microsoft/TypeScript@d8b21a8d6cef772fea5cf2a507b651c5d38194bd/-/blob/src/compiler/types.ts?L4849:9#tab=references) This won't be the case if the symbol is an interface (notice that `Interface` is not in the union for `Value` above). For this reason, we can't rely on the `valueDeclaration` property of the symbol. Instead, it's more reliable to just compare the first items in the `declarations` list. PR Close #45292 08 March 2022, 21:13:24 UTC
ba0efd1 Alan Agius 07 March 2022, 08:11:08 UTC refactor: replace deprecated `HTMLDocument` with `Document` (#45282) `HTMLDocument` is deprecated in favor of `Document`. This change replaces the usages of `HTMLDocument`. See: https://github.com/microsoft/TypeScript/blob/20c93d3b1da44d8ee740b466a5cde7894e8b3260/lib/lib.dom.d.ts#L6370-L6376 PR Close #45282 08 March 2022, 21:12:14 UTC
6cec8aa Dylan Hunn 08 March 2022, 01:47:56 UTC refactor(core): Improve the efficiency of the Typed Forms migration. (#45288) Consider a file that imports `FormControl` and then never uses it. In that case, we don't need to add the import for `UntypedFormControl`. By examining constructor calls *first*, we can identify these cases and skip over them. This will reduce the memory footprint of the migration when run in tsunami, hopefully making OOM errors less likely. PR Close #45288 08 March 2022, 20:06:16 UTC
6eaaefd Alan Agius 07 March 2022, 15:43:13 UTC feat(core): drop support for Node.js 12 (#45286) Node.js v12 will become EOL on 2022-04-30. As a result, Angular CLI v14 will no longer support Node.js v12. BREAKING CHANGE: Support for Node.js v12 has been removed as it will become EOL on 2022-04-30. Please use Node.js v14.15 or later. PR Close #45286 08 March 2022, 20:05:03 UTC
f58b8a9 Renovate Bot 07 March 2022, 18:38:20 UTC build: update all non-major dependencies (#45250) PR Close #45250 08 March 2022, 18:35:17 UTC
f25c8be Renovate Bot 07 March 2022, 22:38:18 UTC build: update scorecard action dependencies (#45249) PR Close #45249 08 March 2022, 18:31:16 UTC
2ca4ef7 Renovate Bot 03 March 2022, 06:10:30 UTC build: update actions/checkout action to v3 (#45248) PR Close #45248 08 March 2022, 18:28:31 UTC
9e56e40 Mladen Jakovljević 07 March 2022, 18:37:51 UTC fix(docs-infra): remove anchor tags from heritage docs (#45287) Remove anchor tags from heritage docs and let `autoLinkCode` insert them properly. PR Close #45287 08 March 2022, 18:26:49 UTC
4478dff George Kalpakas 08 March 2022, 12:58:24 UTC docs(service-worker): improve description of `NoNewVersionDetectedEvent` (#45266) The `NoNewVersionDetectedEvent` does not imply that the latest version on the server is the same as the version the client is on (because a client could be on an older version). Update the description of the event to better describe what it actually means (i.e. that the SW didn't find a version it didn't already know about, but without implying anything about the version the current client is using). PR Close #45266 08 March 2022, 18:26:05 UTC
3ecf930 Luca 08 March 2022, 13:57:23 UTC fix(service-worker): file system hash in batch of 500 elements (#45262) Add file system concurrency hash test Fixes #45133 PR Close #45262 08 March 2022, 18:23:38 UTC
2b7553d Andrew Scott 21 January 2022, 22:41:03 UTC fix(compiler): compute correct offsets when interpolations have HTML entities (#44811) When parsing interpolations, the input string is _decoded_ from what was in the orginal template. This means that we cannot soley rely on the input string to compute source spans because it does not necessarily reflect the exact content of the original template. Specifically, when there is an HTML entity (i.e. `&nbsp;`), this will show up in its decoded form when processing the interpolation (' '). We need to compute offsets using the original _encoded_ string. Note that this problem only surfaces in the splitting of interpolations. The spans to this point have already been tracked accurately. For example, given the template `&nbsp;<div></div>`, the source span for the `div` is already correctly determined to be 6. Only when we encounter interpolations with many parts do we run into situations where we need to compute new spans for the individual parts of the interpolation. PR Close #44811 08 March 2022, 18:23:07 UTC
9fa6f5a Kristiyan Kostadinov 22 February 2022, 12:53:24 UTC fix(core): incorrectly inserting elements inside <template> element (#43429) Currently whenever we insert element we do it directly on the node using `appendChild` or `insertBefore`, however this doesn't work with `<template>` elements where the `template.content` has to be used. These changes add a few checks to call `appendChild` and `insertBefore` on the `content` of the template. Fixes #15557. PR Close #43429 08 March 2022, 18:22:18 UTC
a659d15 Srikanth Kolli 04 March 2022, 01:04:46 UTC docs: Change tag name to TD from TR in context of colspan usage (#45257) PR Close #45257 07 March 2022, 23:41:35 UTC
0b31c8e nanda18 04 March 2022, 17:48:34 UTC docs: update `flush` description to include microtasks (#45237) PR Close #45237 07 March 2022, 23:41:07 UTC
1a5cd06 Renovate Bot 05 March 2022, 09:08:31 UTC build: update dependency google-closure-compiler to v20220301 (#45260) PR Close #45260 07 March 2022, 22:30:45 UTC
68eda48 Renovate Bot 03 March 2022, 11:11:57 UTC build: update dependency magic-string to v0.26.1 (#45247) PR Close #45247 07 March 2022, 22:29:45 UTC
d336ba9 Dylan Hunn 07 March 2022, 04:21:40 UTC fix(forms): Update the typed forms migration. (#45281) The typed forms migration was previously designed to add `<any>` type parameters to existing forms classes. However, due to some design changes, the new opt-out strategy requires untyped versions of the classes, as introduced in #45205 and #45268. This PR updates the migration to import these new classes (in an idempotent manner), and replace constructor calls with the new classes. It respects qualified imports as well. Finally, the code has been refactored to move as much common code as possible into `util.ts`. PR Close #45281 07 March 2022, 20:24:59 UTC
d87f66c Kristiyan Kostadinov 07 March 2022, 13:28:40 UTC test(compiler): fix deprecation warning (#45285) Jasmine logs a warning when there's a `describe` with no tests. These changes fix one such case in the compiler that happens when the tests are run against Windows. PR Close #45285 07 March 2022, 19:36:47 UTC
886cfe8 JiaLiPassion 05 March 2022, 12:06:03 UTC ci: components CI test should use local zone.js build (#45277) CI components test install the angular package from the local version, but still use the zone.js from npm, so this commit let components also install zone.js from local too. PR Close #45277 07 March 2022, 19:34:58 UTC
0bb55f8 George Kalpakas 05 March 2022, 08:46:06 UTC build(docs-infra): upgrade cli command docs sources to 9aa2eb03f (#45275) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/ac175ff10...9aa2eb03f): **Modified** - help/build.json - help/generate.json PR Close #45275 07 March 2022, 19:34:31 UTC
back to top