Skip to main content

Browse the archive

Revision 7ab96ca42be6ce12b7bf98088d5d154f8f15be59 authored by Morten Stenshorne on 05 April 2018, 06:52:57 UTC, committed by Chromium WPT Sync on 05 April 2018, 06:52:57 UTC 
Out-of-flow descendants may still be part of the flow thread.
 
When changing a layout object from in-flow to out-of-flow positioned, we
used to just remove it from the flow thread, risking that there'd no
longer be a column set to associate it with. However, an out-of-flow
positioned descendant may be contained by something that's inside the
flow thread, e.g. if the containing block of an absolutely positioned
object is a relatively positioned object, and that relatively positioned
object is contained by the flow thread.

Since it's hard to detect what the new containing block of an object is
going to be before it has actually gone out of flow, we'll still remove
it from the flow thread, but we'll now detect that we need to re-insert
it when computed style has updated.

Bug: 827424
Change-Id: I413348b0d3ecd0c4b5051e6e9d2a4526863bef60
Reviewed-on: https://chromium-review.googlesource.com/995439
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548354}
1 parent 54f844c
Raw File
nav2_test_navigation_type_backforward.html 
<!DOCTYPE html>
<html>
    <head>
        <meta charset="utf-8" />
        <title>Navigation Timing 2 WPT</title>
        <link rel="author" title="Google" href="http://www.google.com/" />
        <link rel="help" href="http://www.w3.org/TR/navigation-timing/#sec-navigation-timing-interface"/>
        <script src="/resources/testharness.js"></script>
        <script src="/resources/testharnessreport.js"></script>
        <script>

            function onload_test()
            {
                // do this with a timeout to see the visuals of the navigations.
                setTimeout("nav_frame();", 100);
            }

            var step = 1;
            function nav_frame()
            {
                var navigation_frame = document.getElementById("frameContext").contentWindow;
                switch (step)
                {
                    case 1:
                    {
                        navigation_frame.location.href = '/navigation-timing/resources/blank_page_green_with_onunload.html';
                        step++;
                        break;
                    }
                    case 2:
                    {
                        assert_equals(navigation_frame.performance.getEntriesByType("navigation")[0].type,
                                "navigate",
                                'Expected navigation type to be navigate.');
                        navigation_frame.history.back();
                        step++;
                        break;
                    }
                    case 3:
                    {
                        assert_equals(navigation_frame.performance.getEntriesByType("navigation")[0].type,
                                "back_forward",
                                'Expected navigation type to be back_forward.');
                        step++;
                        navigation_frame.history.forward();
                        break;
                    }
                    case 4:
                    {
                        assert_equals(navigation_frame.performance.getEntriesByType("navigation")[0].type,
                                "back_forward",
                                'Expected navigation type to be back_forward.');
                        done();
                        step++;
                        break;
                    }
                    default:
                        break;
                }
            }
        </script>

    </head>
    <body>
        <h1>
            Description</h1>
        <p>
            This test validates the value of window.performance.getEntriesByType("navigation")[0].type with a forward
            and back navigation.</p>

        <p>This page should be loaded with a yellow background frame below.  It should turn green for a starting
            navigation, back to yellow for a back navigation and then back to green again for a forward navigation.</p>

        <p>Along the navigation timeline the window.performance.getEntriesByType("navigation")[0].type is checked for back_forward.</p>

        <p>This test passes if all of the checks to the window.performance.getEntriesByType("navigation")[0].type are correct throughout the navigation
            scenario and the frame below ends with a green background.  Otherwise, this test fails.</p>

        <iframe id="frameContext" onload="onload_test();" src="resources/blank_page_yellow_with_onunload.html" style="width: 250px; height: 250px;"></iframe>
    </body>
</html>
back to top