7ab96ca | Morten Stenshorne | 05 April 2018, 06:52:57 UTC | Out-of-flow descendants may still be part of the flow thread. When changing a layout object from in-flow to out-of-flow positioned, we used to just remove it from the flow thread, risking that there'd no longer be a column set to associate it with. However, an out-of-flow positioned descendant may be contained by something that's inside the flow thread, e.g. if the containing block of an absolutely positioned object is a relatively positioned object, and that relatively positioned object is contained by the flow thread. Since it's hard to detect what the new containing block of an object is going to be before it has actually gone out of flow, we'll still remove it from the flow thread, but we'll now detect that we need to re-insert it when computed style has updated. Bug: 827424 Change-Id: I413348b0d3ecd0c4b5051e6e9d2a4526863bef60 Reviewed-on: https://chromium-review.googlesource.com/995439 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#548354} | 05 April 2018, 06:52:57 UTC |
54f844c | Fergal Daly | 05 April 2018, 06:33:47 UTC | CSS: Add WPT tests for basic ::part() functionality. https://drafts.csswg.org/css-shadow-parts/ Tests cover the following: - Simple - Part in selected host is styled - Host Stylesheet - Part in selected host is not styled by ::part in a stylesheet inside the host - Different Host - Part is not styled when host is not selected - Inner Host - Part in outer host is styled by document style sheet - Part in inner host is not styled by document style sheet - Compound Positive - Compound selector for host works - Compound Negative - Non-matching compound selector for host does not style - All Hosts - ::part with host selector styles in first host - ::part with host selector styles in second host - Chaining Negative - ::part cannot be chained to reach elements in the inner host Bug: 805271 Change-Id: I8c16ae09547bd833dbcc1eb0afb8be91a40c0a8e Reviewed-on: https://chromium-review.googlesource.com/983833 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#548349} | 05 April 2018, 06:43:31 UTC |
1d21646 | Darren Shen | 05 April 2018, 02:55:33 UTC | [css-typed-om] Add support for grid properties. This patch adds support for some grid properties. We add a new <flex> CSS value object, which meant rebaselining all the tests. We're failing some tests because the 'grid', 'grid-template' and 'grid-gap' shorthands don't serialize to anything [1], so Typed OM can't create an unsupported style value from it. Not sure if this is a bug... [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp?type=cs&l=406 Bug: 820299 Change-Id: I8ff871fffed2977ca20a623bd283d7cbdc247870 Reviewed-on: https://chromium-review.googlesource.com/984756 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#548296} | 05 April 2018, 06:20:38 UTC |
8e19a80 | Yoav Weiss | 05 April 2018, 04:45:21 UTC | Merge pull request #10302 from cvazac/server-timing-parsing-tests Fix Server-Timing tests for Webkit | 05 April 2018, 04:45:21 UTC |
8de5d18 | L. David Baron | 05 April 2018, 01:47:40 UTC | Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/071ee904485e21e19ca08456d32bce6825b77a26 . (#10324) | 05 April 2018, 01:47:40 UTC |
c148004 | Stephen McGruer | 04 April 2018, 19:41:56 UTC | Web Animations: Fix bug with Document::getAnimations Per spec, we should exclude effects that do not target an element in the called document: https://drafts.csswg.org/web-animations-1/#dom-document-getanimations Bug: 828424 Change-Id: I41405d82184b17c1185931e34735a5f946573844 Reviewed-on: https://chromium-review.googlesource.com/992812 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#548156} | 04 April 2018, 23:11:52 UTC |
7ba8056 | Henrik Boström | 04 April 2018, 19:14:49 UTC | RTCPeerConnection.getStats(MediaStreamTrack? selector = null) added. Implements the RTCPeerConnection.getStats(MediaStreamTrack) version[1] of the stats selection algorithm behind flag. This is the equivalent of doing RTCRtpSender.getStats() or RTCRtpReceiver.getStats() for the track's sender or receiver. This is tested in external/wpt/. Due to limitations of the generated V8 bindings it is not possible to express all versions of RTCPeerConnection.getStats() at the same time in IDL. Thus this CL introduces a version of getStats() taking "optional any callbacksOrSelector" as argument, with custom binding logic performed in RTCPeerConnection.cpp. A fast/peerconnection/ LayoutTest is added to test all combinations. [1] https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-getstats Bug: 680172 Change-Id: I8c64fc64c708d266c926dfa3eb3587c4cbb31210 Reviewed-on: https://chromium-review.googlesource.com/978128 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#548149} | 04 April 2018, 22:52:05 UTC |
400beb3 | L. David Baron | 04 April 2018, 22:28:35 UTC | Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/c44f60c43432d468639b5fe078420e60c13fd3de . (#10273) | 04 April 2018, 22:28:35 UTC |
47d7cdf | James Graham | 04 April 2018, 18:33:40 UTC | Add long timeout to unstable CSP tests, a=testonly on a CLOSED TREE bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1450577 gecko-commit: ad03d48baa47af437fbf6db482aa315071886211 gecko-integration-branch: central gecko-reviewers: testonly | 04 April 2018, 22:04:02 UTC |
9a3fdb4 | moz-wptsync-bot | 04 April 2018, 21:51:55 UTC | part 2. Combine HTMLConstructor and CreateXULOrHTMLElement into a single function. (#10311) This fixes an observable bug we had due to doing the steps in a different order from the spec: the 'prototype' get can have side-effects so needs to happen after some of the other sanity checks. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1446246 gecko-commit: 9ed0718ede32ea01c67a47b8f143152e860a8be2 gecko-integration-branch: central gecko-reviewers: peterv | 04 April 2018, 21:51:55 UTC |
fc53891 | Brad Werth | 04 April 2018, 18:08:08 UTC | Part 4: Add a web-platform test of getBoxQuads on block and flex boxes with auto margins. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1298008 gecko-commit: c37ba131291e3bc58bc64a5d188a45f28da58f05 gecko-integration-branch: central gecko-reviewers: dholbert | 04 April 2018, 21:40:31 UTC |
904a59b | James Graham | 04 April 2018, 18:13:44 UTC | Fix handling of missing manifest_path in wptcommandline, Ensure that check_paths is always called in set_from_config, and allow the manifest_path to be empty before we set the default. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1447609 gecko-commit: e1cf99d8213dc7455959b75f1ab0116e69c5f095 gecko-integration-branch: central gecko-reviewers: maja_zf | 04 April 2018, 20:46:03 UTC |
9741b4e | Emilio Cobos Álvarez | 04 April 2018, 18:00:47 UTC | Fix the logic to do layout stuff after reassigning a slot. The dirty bit fiddling is nontrivial, but it's pretty much what we do for invalidation and allows to keep this incrementally easily. The only caller that we cared about for the GetFlattenedTreeParent check in DestroyFramesForAndRestyle was the old ShadowRoot invalidation functions that went away. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1435632 gecko-commit: 284b9d43b1135581e88a14c2b135b63cc4720fd1 gecko-integration-branch: central gecko-reviewers: smaug, xidorn | 04 April 2018, 19:49:41 UTC |
98fce6a | Andrea Marchesini | 04 April 2018, 17:43:55 UTC | setTimeout/setInterval should silently fail if the worker is shutting down, bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1450416 gecko-commit: b537ebde3ae1393efb0d8ff29ff6838f4b02b914 gecko-integration-branch: central gecko-reviewers: asuth | 04 April 2018, 19:22:12 UTC |
148f026 | Conley Owens | 04 April 2018, 18:03:08 UTC | bluetooth: web: test: Use AllResponsesConsumed This change uses AllResponsesConsumed in the bluetooth Web Platform Tests in order to make sure we have consumed all the anticipatory responses that we've set on our fakes. BUG=569709 Change-Id: I9767792fcd5dda71fabf2f8941638f744aefa2dc Reviewed-on: https://chromium-review.googlesource.com/988422 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#548125} | 04 April 2018, 19:00:44 UTC |
f1a7713 | Kartikaya Gupta | 04 April 2018, 17:42:05 UTC | Update web-platform-tests annotations for webrender on linux. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1425589 gecko-commit: 6e0605add1f5831268cf99f80b91f78b1f12874b gecko-integration-branch: central gecko-reviewers: jgraham | 04 April 2018, 18:51:48 UTC |
fbaa8f9 | vinoth | 04 April 2018, 17:38:55 UTC | Cache control headers added to png image. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1433617 gecko-commit: e84c93b3a8ab7234247828edcf7019d8f7393ee7 gecko-integration-branch: central gecko-reviewers: ckerschb | 04 April 2018, 18:15:36 UTC |
6a7101f | Boris Zbarsky | 04 April 2018, 17:30:07 UTC | Remove support for the 'type' parameter to document.open. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1444872 gecko-commit: 72cdb625f0ce333db35b7e98195d649495e2eb9d gecko-integration-branch: central gecko-reviewers: qdot | 04 April 2018, 18:00:19 UTC |
ef7fe9a | Anne van Kesteren | 04 April 2018, 17:04:57 UTC | New MIME type parsing tests Tests suggested at https://github.com/w3c/web-platform-tests/issues/1851#issuecomment-378032606. Co-Authored-By: Matt Menke <mmenke@google.com> | 04 April 2018, 17:04:57 UTC |
48df374 | Navid Zolghadr | 04 April 2018, 16:12:37 UTC | Fix up the touch-action tests Move the touch-action: pan-left/right/up/down tests to the next version of the spec. https://github.com/w3c/pointerevents/pull/238 Bug: 826726 Change-Id: Icab0e439e0c2281f0c9fc78eec0a41a044f37f71 Reviewed-on: https://chromium-review.googlesource.com/984736 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#548078} | 04 April 2018, 16:48:34 UTC |
168e0e1 | Philip Jägenstedt | 04 April 2018, 15:24:36 UTC | Simplify assert_throws in two places where error messages were passed This was discovered in https://chromium-review.googlesource.com/c/chromium/src/+/980757 by letting assert_throws also check that the message matches. That change itself isn't a good idea, but it's still just as well to use plain TypeErrors here to not make it seems like more is being tested than in fact is. Change-Id: I8f964e9b25cc94942cb86f3ee0017530f230e04a Reviewed-on: https://chromium-review.googlesource.com/995192 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#548060} | 04 April 2018, 15:45:44 UTC |
6fe9207 | Charles Vazac | 04 April 2018, 14:19:53 UTC | clean up same- and cross-origin urls | 04 April 2018, 14:19:53 UTC |
e502344 | Darren Shen | 04 April 2018, 10:55:28 UTC | [css-typed-om] Support animation and transition properties. This patch supports all the animation/transition properties except animation-name and transition-property (need spec feedback first). We also fix the <time> tests so that computed time values use canonical units as spec'd in [1]. [1] https://github.com/w3c/css-houdini-drafts/issues/725 Bug: 820299 Change-Id: I7c038ce419f8bdb1c789493554776c5e7f9810c7 Reviewed-on: https://chromium-review.googlesource.com/983094 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#548017} | 04 April 2018, 13:15:06 UTC |
162e9dd | Philip Jägenstedt | 04 April 2018, 06:14:57 UTC | Document useful arguments for `wpt run chrome` (#10238) | 04 April 2018, 06:14:57 UTC |
e7b6f07 | Charles Vazac | 04 April 2018, 02:35:53 UTC | Merge branch 'master' of github.com:w3c/web-platform-tests into server-timing-parsing-tests | 04 April 2018, 02:35:53 UTC |
bcbb3c2 | Charles Vazac | 04 April 2018, 02:34:00 UTC | remove load order dependency from consistent assert order | 04 April 2018, 02:34:00 UTC |
2b3f901 | Mike Pennisi | 03 April 2018, 22:15:29 UTC | Correct reference to certificate file | 04 April 2018, 01:59:10 UTC |
c218fe3 | Koji Ishii | 03 April 2018, 22:27:32 UTC | Fix a typo in wpt/css/css-text-decor/text-emphasis-style-001.html This test does not pass because of a typo in the ref file. Change-Id: I2673137789267359544a50e126d3ba16b728770b Reviewed-on: https://chromium-review.googlesource.com/989455 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#547847} | 03 April 2018, 23:05:24 UTC |
9921476 | Marijn Kruisselbrink | 03 April 2018, 22:03:09 UTC | [Mojo Blob URLs] Resolve navigation blob URLs in blink. This makes sure that no race conditions exist between navigating to a blob URL and revoking it. Currently only implemented for the network service code path. Also add one more navigation-then-revoke WPT test, as the existing tests didn't cover the NavigationScheduler code-path. Design doc: https://docs.google.com/document/d/1DqVcTWE9Qb_3KpIRH2bFV-6hWEr8S92c4ppY67YL1KI/edit#heading=h.n4fzuc6mgziv Further navigation cases are handled in https://chromium-review.googlesource.com/c/chromium/src/+/899508. Bug: 800901 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Icf9a4725526b4329a2841626977292802ad2fa7a Reviewed-on: https://chromium-review.googlesource.com/898009 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#547842} | 03 April 2018, 22:15:44 UTC |
81e900a | Luke Bjerring | 03 April 2018, 14:27:59 UTC | Throw IdlHarnessError outside try | 03 April 2018, 21:24:15 UTC |
2bbb6b4 | Luke Bjerring | 03 April 2018, 19:59:59 UTC | Updated filter-effects IDL file (#9884) * Updated filter-effects IDL file | 03 April 2018, 19:59:59 UTC |
8f93a78 | Jonathon Kereliuk | 03 April 2018, 19:12:01 UTC | Automated Keyboard Input (#10113) | 03 April 2018, 19:12:01 UTC |
51b2242 | Luke Bjerring | 03 April 2018, 18:38:12 UTC | Updated ServiceWorker IDL file (#9886) * Updated ServiceWorker IDL file | 03 April 2018, 18:38:12 UTC |
0030814 | Chris Lilley | 03 April 2018, 18:17:39 UTC | Merge pull request #9373 from w3c/user/frremy/contribute-css-fonts-4-tests [css-fonts-4] Contribute Microsoft tests for Font Variations | 03 April 2018, 18:17:39 UTC |
09329e8 | Chris Nardi | 13 March 2018, 21:27:03 UTC | Correct serialization of overflow | 03 April 2018, 18:09:56 UTC |
d30e620 | Chris Nardi | 13 March 2018, 20:45:10 UTC | Rewrite CSSOM index tests index-001.html and index-002.html had nondescript names, and index-002.html used generate_tests. Merge index-001.html into shorthand-serialization.html, and create shorthand-values.html from index-002.html. Builds off the work of #5331. | 03 April 2018, 18:09:56 UTC |
6e2b4a7 | Harald Alvestrand | 03 April 2018, 17:28:06 UTC | Don't enforce name rule for RTCDTMFToneChangeEvent Since the constructor of RTCDTMFToneChangeEvent is exposed, creating such events with other names than "tonechange" is possible. No reason to discriminate against such. Also adds tests for constructor. Bug: chromium:822799 Change-Id: I4b36f3094acee200dd4200c4d24f6b46e10a06e6 Reviewed-on: https://chromium-review.googlesource.com/992038 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#547742} | 03 April 2018, 17:58:46 UTC |
f527ada | Boris Zbarsky | 03 April 2018, 17:30:40 UTC | Merge pull request #10286 from bzbarsky/stable-error-messages-for-link-load Use stable error messages in the link onload event tests by default. | 03 April 2018, 17:30:40 UTC |
be666a5 | Boris Zbarsky | 03 April 2018, 17:09:28 UTC | Use stable error messages in the link onload event tests by default. | 03 April 2018, 17:09:28 UTC |
7c51ebb | Cameron McCormack | 03 April 2018, 14:45:32 UTC | fix reftest-wait typo (#10276) | 03 April 2018, 14:45:32 UTC |
ea469b6 | Adam Rice | 02 April 2018, 06:38:50 UTC | ReadableStream: getReader() should call ToString() on mode When the "mode" option is not undefined, getReader({mode}) algorithm calls ToString() on it before checking whether or not it is "blob". Add a test to ensure this conversion is done. | 03 April 2018, 14:34:59 UTC |
7164dbb | Darren Shen | 03 April 2018, 10:47:38 UTC | [css-typed-om] Add a few keyword properties. Add support for the following properties: - image-rendering - text-anchor - text-combine-upright - text-overflow - text-rendering - transform-style - user-select Lots of failing tests, usually because a keyword isn't implemented in Blink yet. Bug: 820299 Change-Id: Ifd0193ac55d12a31d28b486166ad78a38012314b Reviewed-on: https://chromium-review.googlesource.com/985337 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#547665} | 03 April 2018, 11:03:18 UTC |
02bf900 | Ovidio Henriquez | 03 April 2018, 01:30:23 UTC | bluetooth: web: test: Update blocklist UUID tests This change updates the blocklisted UUID tests to use the Web Bluetooth Test API. This will allow the test to be migrated into wpt/. BUG=509038 Change-Id: I72acd10e5aabc4c03f955dc4c7b2a8620930cc2d Reviewed-on: https://chromium-review.googlesource.com/894738 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#547588} | 03 April 2018, 08:05:09 UTC |
939b30a | Chris Nardi | 03 April 2018, 03:08:55 UTC | Serialize font shorthand like any other shorthand The font shorthand had a short-circuit in StylePropertySerializer, which meant that it was never serialized as a shorthand for style.cssText, citing reasons of web incompatibility. However, it appears that all other major browsers serialize font as a shorthand instead of having style.cssText expand to all properties. Remove this short-circuit to match other browsers. Bug: 827921 Change-Id: I4d522b41a6153808b6b8dab17831afdd8315fdc3 Reviewed-on: https://chromium-review.googlesource.com/989834 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547607} | 03 April 2018, 03:19:07 UTC |
5b68d21 | Domenic Denicola | 03 April 2018, 00:54:04 UTC | Fix customElements.upgrade() tests for <template> (#10272) * Fix customElements.upgrade() tests for <template> See https://github.com/w3c/web-platform-tests/pull/9869#issuecomment-378002725. * Actually fix things | 03 April 2018, 00:54:04 UTC |
24f7e6d | Lukasz Anforowicz | 02 April 2018, 23:48:36 UTC | Make CORB MIME type classification consistent with the web specs. https://tools.ietf.org/html/rfc7303 says that if "new media type is introduced for an XML-based format, the name of the media type SHOULD end with '+xml'". https://tools.ietf.org/html/rfc6839 covers '+xml' and '+json' suffixes. https://mimesniff.spec.whatwg.org/#xml-mime-type says "An XML MIME type is any MIME type whose subtype ends in '+xml' or whose essence is 'text/xml' or 'application/xml'. [RFC7303]". https://mimesniff.spec.whatwg.org/#json-mime-type says "A JSON MIME type is any MIME type whose subtype ends in '+json' or whose essence is 'application/json' or 'text/json'." There are no occurences of "application/xml+", "text/xml+", "application/json+", "text/json+" or "text/x-json" in the specs above and on various lists of MIME types like: - https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Complete_list_of_MIME_types - https://en.wikipedia.org/wiki/Media_type - https://www.freeformatter.com/mime-types-list.html - https://www.sitepoint.com/mime-types-complete-list/ Bug: 826756 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ied30f9728bd4f082bb620fea150f342457ea4833 Reviewed-on: https://chromium-review.googlesource.com/985211 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547565} | 02 April 2018, 23:59:02 UTC |
94b7255 | Joshua Bell | 02 April 2018, 23:05:43 UTC | Cookie Store API: Split out and enable test cases Split out cases from a master "cookie-store-tests.js" suite, allowing them to be enabled/debugged separately. Also updates observation tests to use the new "change" event, and deletes "static" since we can assume a dependency on a test server here. Bug: 783229 Change-Id: I9e29ea74a2f0513a033a8f9c71da2836c000ee27 Reviewed-on: https://chromium-review.googlesource.com/986649 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#547543} | 02 April 2018, 23:27:06 UTC |
4bb4e6e | Lukasz Anforowicz | 02 April 2018, 20:04:17 UTC | Tests and docs for the current CORB vs <link rel="preload"> behavior. Bug: 809261 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Idafb2b4cc5da3d6c7a054e479745288cc3b86513 Reviewed-on: https://chromium-review.googlesource.com/984338 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547494} | 02 April 2018, 20:13:29 UTC |
af485dc | Chris Nardi | 02 April 2018, 17:04:26 UTC | Remove test that CSSStyleSheet.media is read-only style-sheet-interfaces-001.html tested that styleSheet.media was read-only, but the spec changed to add a [PutForwards] attribute to |media|, meanining that the attribute is no longer truly read-only. assert_readonly can have side-effects if the property has a [PutForwards] attribute, so remove this check, as it was causing the next test to fail. Bug: 821780 Change-Id: I77bee2f11484f6e679e4aee6b0641179c686d1d3 Reviewed-on: https://chromium-review.googlesource.com/989407 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547451} | 02 April 2018, 17:13:45 UTC |
e4efc10 | Manuel Rego Casasnovas | 02 April 2018, 06:19:45 UTC | [css-grid] Fix resolution of percentage paddings and margins of grid items We were not resolving properly percentage paddings and margins for tracks that have something like minmax(auto, 100px). The reason was that while computing the minimum size of a grid item, the percentages were resolved against the inline size of the grid container. But for grid items we shouldn't never use the grid container size, but the grid area size, as that's their containing block. The patch modifies ContainingBlockLogicalWidthForContent() and ContainingBlockLogicalHeightForContent() in LayoutBox, so for grid items we return 0 if the area size hasn't been set yet. We never want to use the grid container's sizes in these cases. BUG=808758 TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-margins-* TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-paddings-* Change-Id: Ib142e51aee1fe623d38688469b179f01f82eb07b Reviewed-on: https://chromium-review.googlesource.com/980756 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#547417} | 02 April 2018, 13:45:00 UTC |
bc209c3 | Kent Tamura | 02 April 2018, 08:48:54 UTC | custom-elements: Add tests for callback timing with HTML parser. Bug: 821831 Change-Id: I5b3e1978e37ce34e6fb885ca1077ea90ab2f494c Reviewed-on: https://chromium-review.googlesource.com/987972 Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#547424} | 02 April 2018, 08:59:11 UTC |
94b33b5 | Chris Nardi | 02 April 2018, 08:24:10 UTC | Update IRC archive link (#10266) The link was dead; update to the new link. | 02 April 2018, 08:24:10 UTC |
d68f044 | Tsuyoshi Horo | 02 April 2018, 03:41:31 UTC | Set SkipServiceWorker flag for synchronous loads from the main thread. Before 5e1b52dd7e828fb2e4bd69f599c0c30eec3e873c, synchronous XHR on worker was handled by service workers. It is because the |is_sync_load| was false when the sync request is from worker thread. But after the CL, the |is_sync_load| flag for the sync request from worker became true, so the request will not go to the service worker. This CL will fix this by - Set the SkipServiceWorker flag for synchronous loads from the main thread in the renderer process. (FetchParameters.cpp) - Don't set skip_service_worker even if is_sync_load is true in the browser process. (resource_dispatcher_host_impl.cc) Bug: 706331,827473 Change-Id: I186bc97f3f8d298e0a04942d0ec4b708b3022cc1 Reviewed-on: https://chromium-review.googlesource.com/989376 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#547407} | 02 April 2018, 03:50:01 UTC |
3589b85 | Chris Lilley | 31 March 2018, 22:48:39 UTC | Merge pull request #10172 from liamquin/svg-lists-have-length [svg 2 text] add scripted tests for length and indexed access | 31 March 2018, 22:48:39 UTC |
1331d68 | kaixinjxq | 07 December 2017, 07:45:07 UTC | Add a DataTransfer test The types attribute must return this DataTransfer object's types array | 31 March 2018, 15:23:20 UTC |
fc33be9 | Eric Holk | 31 March 2018, 00:33:45 UTC | Delete wasm/many-memories.window.js WPT test Testing for a specific number is causing problems and determining the right number is problematic in general, as running out of memory is always a legitimate possiblity. See https://github.com/WebAssembly/design/issues/1167 for more discussion. In light of this, it's best to just remove the test. Bug: Change-Id: I66e248c8ab851bca0c54fa6fe13b6e93e55f1264 Reviewed-on: https://chromium-review.googlesource.com/851081 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#547333} | 31 March 2018, 00:43:14 UTC |
21be95d | Luke Bjerring | 30 March 2018, 22:10:25 UTC | Revert #10240 | 30 March 2018, 22:17:29 UTC |
771a209 | Tom Anderson | 30 March 2018, 19:57:10 UTC | Replace Arial with Arimo GCS font BUG=787020 TBR=dpranke,asvitkine Change-Id: I38740d1ee9fe621eabd5416f1a87b23a71fbb7e7 Reviewed-on: https://chromium-review.googlesource.com/986812 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#547246} | 30 March 2018, 20:17:58 UTC |
067f918 | Luke Bjerring | 29 March 2018, 17:34:58 UTC | Update the name of webaudio to web-audio-api | 30 March 2018, 09:08:30 UTC |
d01ce10 | Florian Rivoal | 30 March 2018, 04:28:47 UTC | Merge pull request #10232 from frivoal/gap-normal [css-align] tests for row-gap / column-gap normal | 30 March 2018, 04:28:47 UTC |
fda5b2f | Florian Rivoal | 30 March 2018, 04:19:15 UTC | [css-align] Fix typo and clean-up markup | 30 March 2018, 04:19:15 UTC |
709111a | François Doray | 29 March 2018, 16:39:25 UTC | Revert "bluetooth: FakeBluetoothChooser impl." This reverts commit 6a337f19713e049cd42969b0c909c59aff4146cd. Reason for revert: https://crbug.com/824704 These tests are failing: external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services-with-uuid.https.html external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html Original change's description: > bluetooth: FakeBluetoothChooser impl. > > Implements the interfaces that FakeBluetoothChooser overrides. The > mojom::FakeBluetoothChooser overrides are implemented by running > |event_handler_| with the appropriate arguments. The BluetoothChooser > overrides do nothing at the moment, since the base class is only meant > to update the chooser user interface. > > This change also begins to partially convert a Bluetooth chooser test to test > the interface and deletes the temporary tests that were created to test this > API. > > This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which > reverted the original change. The original change caused the > new-scan-device-added.html test to fail because of a Mojo validation error > resulting from not updating the > third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js > file needed by the test. > > Bug: 719827, 719826, 824704, 826787 > Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527 > Reviewed-on: https://chromium-review.googlesource.com/985195 > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546729} TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org Change-Id: Ie2ef2af1ae74e8dd5ca01441027adaa59e6e0c0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 719827, 719826, 824704, 826787 Reviewed-on: https://chromium-review.googlesource.com/986592 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#546851} | 29 March 2018, 22:30:42 UTC |
68f87b7 | Dave Tapuska | 29 March 2018, 18:37:39 UTC | Add wpt test for back/forward mouse buttons. Test that back and forward mouseup events are received and can be preventDefaulted. BUG=680741 Change-Id: I381a3c3dacc344ae4f49c8a35cdcc0ef83907917 Reviewed-on: https://chromium-review.googlesource.com/986508 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#546857} | 29 March 2018, 19:17:58 UTC |
3adbaa2 | Luke Bjerring | 29 March 2018, 18:35:46 UTC | Check inherited interfaces exist (#10240) * Check inherited interfaces exist * Re-jig IdlHarness error capture + report ordering | 29 March 2018, 18:35:46 UTC |
149116d | Luke Bjerring | 29 March 2018, 17:48:23 UTC | Update the webauthn IDL file (#9850) * Add webauthn idl file * Simplify webauthn/interfaces.https.html test | 29 March 2018, 17:48:23 UTC |
a149250 | Luke Bjerring | 29 March 2018, 17:08:11 UTC | Update the geometry IDL file (#9787) * Update geometry IDL * Prevent multiple testing of the same interfaces. | 29 March 2018, 17:08:11 UTC |
8c66f53 | Luke Bjerring | 29 March 2018, 16:47:19 UTC | Update the webrtc-pc IDL file (#9853) * Update webrtc-pc IDL | 29 March 2018, 16:47:19 UTC |
4091ab0 | Florian Rivoal | 29 March 2018, 16:46:52 UTC | [css-overflow-3] test the flow-relative overflow properties (#10233) Corresponding to the spec changes decided in https://github.com/w3c/csswg-drafts/issues/2000 | 29 March 2018, 16:46:52 UTC |
afcd47b | Florian Rivoal | 29 March 2018, 16:26:36 UTC | [css-overflow] Add the spec editors as OWNERS (#10234) | 29 March 2018, 16:26:36 UTC |
f30b60b | Henrik Boström | 29 March 2018, 13:27:36 UTC | RTCRtpReceiver.getStats() in blink added behind flag. This exposes RTCRtpReceiver.getStats() in JavaScript (behind flag) which implements the stats selection algorithm[1] for receivers. (This is similar to RTCRtpSender.getStats(): https://chromium-review.googlesource.com/c/chromium/src/+/975306) [1] https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm Bug: 680172 Change-Id: I8049a52fcaa3c2bd51e5541c7149d9b3aee57e3d Reviewed-on: https://chromium-review.googlesource.com/976121 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#546801} | 29 March 2018, 13:47:10 UTC |
8efcf2b | Philip Jägenstedt | 29 March 2018, 13:44:01 UTC | Invert (fix) the order of `wpt make-hosts-file` instructions (#10237) This was inverted so that the Windows instructions were printed on Linux. Rather than just changing the condition, switch the messages, to match the order of some preceding code. | 29 March 2018, 13:44:01 UTC |
604d17e | Darren Shen | 28 March 2018, 23:15:07 UTC | [css-typed-om] Add support for marker properties. This patch adds support for marker, marker-start, marker-end, marker-mid We also had to add a new CSS data type <url>, but because it's not spec'd yet, we can't really test it. Bug: 820299 Change-Id: Ie3f851be3d65396705594d99582ac3e87e3fc57d Reviewed-on: https://chromium-review.googlesource.com/983192 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#546645} | 29 March 2018, 12:10:26 UTC |
9c86b93 | Ovidio Henriquez | 29 March 2018, 05:32:23 UTC | bluetooth: FakeBluetoothChooser impl. Implements the interfaces that FakeBluetoothChooser overrides. The mojom::FakeBluetoothChooser overrides are implemented by running |event_handler_| with the appropriate arguments. The BluetoothChooser overrides do nothing at the moment, since the base class is only meant to update the chooser user interface. This change also begins to partially convert a Bluetooth chooser test to test the interface and deletes the temporary tests that were created to test this API. This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which reverted the original change. The original change caused the new-scan-device-added.html test to fail because of a Mojo validation error resulting from not updating the third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js file needed by the test. Bug: 719827, 719826, 824704, 826787 Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527 Reviewed-on: https://chromium-review.googlesource.com/985195 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#546729} | 29 March 2018, 12:08:58 UTC |
a87d055 | Kenichi Ishibashi | 29 March 2018, 08:11:29 UTC | Remove create_file_system_file() This function isn't used. Bug: 658997,402387 Change-Id: I01d751dfebaafd1580beaeb12ebcd124df132b26 Reviewed-on: https://chromium-review.googlesource.com/984919 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#546765} | 29 March 2018, 08:21:08 UTC |
f9881ff | Florian Rivoal | 29 March 2018, 05:34:17 UTC | [css-aling] tests for row-gap / column-gap normal Matching the https://github.com/w3c/csswg-drafts/issues/2294 spec change Not including tests for used value in multicol, because (so far) it is UA defined. | 29 March 2018, 05:34:17 UTC |
55846d5 | Zhuoyu Qian | 29 March 2018, 01:09:38 UTC | Check BackgroundEdgeOrigin when check BackgroundPosition. We should check Background{X/Y}Origin when check BackgroundPosition{X/Y}. BackgroundPosition same but BackgroundEdgeOrigin different is not the same position, we should return false when FillLayersEqual(). Bug: 823046 Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ia7d0c5af33e1ee5986420dc054c2ce1b1f65e9b0 Reviewed-on: https://chromium-review.googlesource.com/967912 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#546679} | 29 March 2018, 01:19:15 UTC |
592e2ed | Brian Burg | 29 March 2018, 00:42:03 UTC | webdriver: add more WebKit workarounds to detect whether a window is fullscreen (#10226) WebKit doesn't implement the Fullscreen API yet, so we need to use the vendor prefixed property to check whether the window is fullscreen. This workaround was previously applied to fullscreen_window.py, but it needs to happen in other places as wel. | 29 March 2018, 00:42:03 UTC |
bc7c640 | Luke Bjerring | 28 March 2018, 22:30:58 UTC | Support partial dictionaries (#10159) * Support partial dictionaries | 28 March 2018, 22:30:58 UTC |
d5fea75 | François Doray | 28 March 2018, 20:58:32 UTC | Revert "bluetooth: FakeBluetoothChooser impl." This reverts commit 188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7. Reason for revert: https://crbug.com/826787 Original change's description: > bluetooth: FakeBluetoothChooser impl. > > Implements the interfaces that FakeBluetoothChooser overrides. The > mojom::FakeBluetoothChooser overrides are implemented by running > |event_handler_| with the appropriate arguments. The BluetoothChooser > overrides do nothing at the moment, since the base class is only meant > to update the chooser user interface. > > This change also begins to partially convert a Bluetooth chooser test to test > the interface and deletes the temporary tests that were created to test this > API. > > BUG=719827,719826,824704 > > Change-Id: I56a04e6bdb2de38d9163d7bc350db578deeb9ba3 > Reviewed-on: https://chromium-review.googlesource.com/962983 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Conley Owens <cco3@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546509} TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org Change-Id: I0597151ec5878d41ac631b72296203bc99b1f2c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 719827, 719826, 824704, 826787 Reviewed-on: https://chromium-review.googlesource.com/984299 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#546572} | 28 March 2018, 21:20:02 UTC |
c2cd757 | Ian Kilpatrick | 28 March 2018, 04:35:58 UTC | [css-layout-api] Implementation of LayoutConstraints#fixedInlineSize. This adds the bare bones for the LayoutConstraints object. It just handles the fixedInlineSize parameter. I expect the information in this object after the next F2F. The layout for the test will simply output an autoBlockSize of 100, if the fixedInlineSize is 100. The tests impose various conditions in how this can occur, but is certainly not exhaustive. Change-Id: I6be4a7b77d7b737c778dc2de8b235035b8d3fa22 Bug: 726125 Reviewed-on: https://chromium-review.googlesource.com/981517 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#546393} | 28 March 2018, 21:08:43 UTC |
107dd46 | Ovidio Henriquez | 28 March 2018, 16:19:20 UTC | bluetooth: FakeBluetoothChooser impl. Implements the interfaces that FakeBluetoothChooser overrides. The mojom::FakeBluetoothChooser overrides are implemented by running |event_handler_| with the appropriate arguments. The BluetoothChooser overrides do nothing at the moment, since the base class is only meant to update the chooser user interface. This change also begins to partially convert a Bluetooth chooser test to test the interface and deletes the temporary tests that were created to test this API. BUG=719827,719826,824704 Change-Id: I56a04e6bdb2de38d9163d7bc350db578deeb9ba3 Reviewed-on: https://chromium-review.googlesource.com/962983 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Conley Owens <cco3@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#546509} | 28 March 2018, 20:53:27 UTC |
7c782f4 | Ben Kelly | 28 March 2018, 19:46:15 UTC | P2 Add a WPT test verifying synthetic responses work when a request fragment is present. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1443850 gecko-commit: 7b66eb1629750401eb5768646d8381ff4e631cac gecko-integration-branch: central gecko-reviewers: asuth | 28 March 2018, 20:23:21 UTC |
49b9015 | Boris Zbarsky | 28 March 2018, 19:09:05 UTC | part 2. Add a bunch of web platform tests for load and error events on stylesheet links. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1443652 gecko-commit: 7daaf289c085e05e0e4a0327a13748002fb467a0 gecko-integration-branch: central gecko-reviewers: bholley | 28 March 2018, 19:49:20 UTC |
7b35f2c | Boris Zbarsky | 28 March 2018, 19:09:02 UTC | part 1. Fix the buggy existing load-event test for stylesheets. The test was adding the load listener to the <link> _after_ the load event on the <link> had already fired. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1443652 gecko-commit: ba6cef216a171782bd8abcd00a08c9ae88cbfe43 gecko-integration-branch: central gecko-reviewers: bholley | 28 March 2018, 19:49:20 UTC |
355c2d7 | Luke Bjerring | 28 March 2018, 19:30:20 UTC | Handle idlharness.js expected errors as an IdlArray.assert_throw option (#10164) * Handle idlharness.js expected errors as an IdlArray.assert_throw option | 28 March 2018, 19:30:20 UTC |
94ab26e | jgraham | 28 March 2018, 19:03:58 UTC | fixup! Fix indentation | 28 March 2018, 19:29:52 UTC |
d79e8d2 | Henrik Skupin | 28 March 2018, 18:32:49 UTC | Use detailed failure message for wdspec test failures (pytest). When adding failures to the test report, the hook for pytest_runtest_logreport missed to extract the failure message from the stack, and as such passed in no message for the failure. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1433923 gecko-commit: 849020c741de1e3bca2e22f5902e7d3b40f64ebd gecko-integration-branch: central gecko-reviewers: jgraham | 28 March 2018, 19:29:52 UTC |
c2707bb | Henrik Skupin | 28 March 2018, 18:49:31 UTC | Find element for (partial) link text has to use rendered content. To retrieve links via "link text" or "partial link text" the rendered content of the element has to be used. This can be the case for CSS transformations like "uppercase". bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1381519 gecko-commit: 3e204686f1b10441f48435890241dff6706d04dd gecko-integration-branch: central gecko-reviewers: ato | 28 March 2018, 19:09:49 UTC |
42f4395 | Henrik Boström | 28 March 2018, 15:48:04 UTC | RTCRtpSender.getStats() in blink added behind flag. This exposes RTCRtpSender.getStats() in JavaScript (behind flag) which implements the stats selection algorithm[1] for senders. [1] https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm Bug: 680172 Change-Id: I8117c87f475d1c78fa3301fc2d821f0c3a21281f Reviewed-on: https://chromium-review.googlesource.com/975306 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#546493} | 28 March 2018, 15:58:25 UTC |
f9c1a50 | Rouslan Solomakhin | 28 March 2018, 13:39:47 UTC | Merge pull request #10203 from w3c/fixup_show_test fix: assert_equals check is wrong | 28 March 2018, 13:39:47 UTC |
cb4fe6c | Rouslan Solomakhin | 28 March 2018, 13:38:21 UTC | Merge pull request #10204 from w3c/marcoscaceres-patch-1 Add @edenchuang again 🎊 | 28 March 2018, 13:38:21 UTC |
e6cc359 | Rouslan Solomakhin | 28 March 2018, 13:37:44 UTC | Merge pull request #10206 from w3c/marcoscaceres-patch-2 fix copy/pasta | 28 March 2018, 13:37:44 UTC |
2f758ac | Anne van Kesteren | 28 March 2018, 12:50:32 UTC | DOM: reset target/relatedTarget For https://github.com/whatwg/dom/pull/585. | 28 March 2018, 12:50:32 UTC |
97d4646 | Darren Shen | 27 March 2018, 09:18:24 UTC | [css-typed-om] Stub list-valued tests. Currently we're just adding a TODO when we want to test a list-valued property. It's probably easier if we stub that test function and then implement it later. Bug: 774887 Change-Id: Iab3cea915afbcc8490cacbd45e5632a18e7dece1 Reviewed-on: https://chromium-review.googlesource.com/981956 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#546067} | 28 March 2018, 12:45:23 UTC |
1d25beb | Hayato Ito | 28 March 2018, 12:08:08 UTC | Keep track of all pending slot assignments, and recalc all before UpdateStyle phase For the purpose of rendering, Blink must calculate all pending slot assignments before UpdateStyle phase. Unless that, a recursive RecalcStyle() may not traverse a node which should be re-attached. e.g. Suppose the following tree, where #d1 is assigned to a slot. host ├──/shadow-root │ └── slot name=s1 └── div id=d1 slot=s1 Then, we change #d1's slot attribute to s2, like: > document.querySelector('#d1').setAttribute('slot', 's2'); host ├──/shadow-root │ └── slot name=s1 └── div id=d1 slot=s2 In this case, #d1 should be removed from a LayoutTree. In other words, Blink has to reattach #d1 somehow. However, if we don't recalc a slot assignment for the shadow tree before UpdateStyle, a recursive RecalcStyle never traverses the sub-tree because child-needs-style-recalc flag is not set for the node (and its ancestor nodes). A flag should be set as a result of slot assignment recalc. Thanks to the Incremental Shadow DOM, a slot assignemt recalc now becomes a local operatoin on each shadow tree, rather than one global operation for every shadow trees. We don't need to traverse a composed tree to recalc all. We can recalc a slot assignment for each shadow tree directly, without traversing a composed tree. For a shadow tree which is not connected, we don't need to recalc its slot assignment before UpdateStyle because such a shadow tree shouldn't have any effect on rendering. Lazy slot assignment recalc is enough for such a shadow tree. This CL doesn't introduce any optimization to minimize the number of to-be-reattached nodes. I'll optimize that as a next task. I'll use a sort of dynamic programming there, as I did at https://chromium-review.googlesource.com/c/chromium/src/+/535493 for non-Incremental Shadow DOM. Except for the performance, this CL should be the last part of Incremental Shadow DOM from the external behavior's perspective. Style and Layout should work correctly after this CL, even with Incremental Shadow DOM. BUG=776656 Change-Id: Id18e87ff59d92863c68c571e7db09253c08aa91f Reviewed-on: https://chromium-review.googlesource.com/964062 Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#546458} | 28 March 2018, 12:17:59 UTC |
6fca0b2 | Kriti Singh | 28 March 2018, 08:40:30 UTC | Test that event handlers set on the window object are found on the body element (#10169) Based on event-handler-attributes-body-window.html. | 28 March 2018, 08:40:30 UTC |
3db7bb7 | Hwanseung Lee | 28 March 2018, 06:47:36 UTC | [css-typed-om] support x, y, cx, cy properties x[1], y[2], cx[3], cy[4] are added to support in whitelist. and test file are also added. [1]https://svgwg.org/svg2-draft/geometry.html#X [2]https://svgwg.org/svg2-draft/geometry.html#Y [3]https://svgwg.org/svg2-draft/geometry.html#CX [4]https://svgwg.org/svg2-draft/geometry.html#CY Bug: 820299 Change-Id: I46ced4427a5e7b2e08aa132fc0b8c5d2e1f19d22 Reviewed-on: https://chromium-review.googlesource.com/983077 Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#546426} | 28 March 2018, 07:07:27 UTC |
67ae39c | Marcos Cáceres | 28 March 2018, 06:12:01 UTC | fix copy/pasta | 28 March 2018, 06:12:01 UTC |
e343b5d | Marcos Cáceres | 28 March 2018, 03:52:58 UTC | Add @edenchuang again 🎊 | 28 March 2018, 03:52:58 UTC |
4b535ba | Marcos Cáceres | 28 March 2018, 03:39:52 UTC | fix: assert_equals check is wrong | 28 March 2018, 03:39:52 UTC |