https://github.com/torvalds/linux
Revision 7b2b55da1db10a5525460633ae4b6fb0be060c41 authored by Jason Xing on 25 August 2019, 00:54:53 UTC, committed by Linus Torvalds on 25 August 2019, 02:48:42 UTC
Only when calling the poll syscall the first time can user receive
POLLPRI correctly.  After that, user always fails to acquire the event
signal.

Reproduce case:
 1. Get the monitor code in Documentation/accounting/psi.txt
 2. Run it, and wait for the event triggered.
 3. Kill and restart the process.

The question is why we can end up with poll_scheduled = 1 but the work
not running (which would reset it to 0).  And the answer is because the
scheduling side sees group->poll_kworker under RCU protection and then
schedules it, but here we cancel the work and destroy the worker.  The
cancel needs to pair with resetting the poll_scheduled flag.

Link: http://lkml.kernel.org/r/1566357985-97781-1-git-send-email-joseph.qi@linux.alibaba.com
Signed-off-by: Jason Xing <kerneljasonxing@linux.alibaba.com>
Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Reviewed-by: Caspar Zhang <caspar@linux.alibaba.com>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent bb65f89
History
Tip revision: 7b2b55da1db10a5525460633ae4b6fb0be060c41 authored by Jason Xing on 25 August 2019, 00:54:53 UTC
psi: get poll_work to run when calling poll syscall next time
Tip revision: 7b2b55d
File Mode Size
Kconfig -rw-r--r-- 551 bytes
Makefile -rw-r--r-- 365 bytes
attributes.c -rw-r--r-- 8.5 KB
bfind.c -rw-r--r-- 6.1 KB
bitmap.c -rw-r--r-- 5.0 KB
bnode.c -rw-r--r-- 15.3 KB
brec.c -rw-r--r-- 13.6 KB
btree.c -rw-r--r-- 12.2 KB
catalog.c -rw-r--r-- 14.1 KB
dir.c -rw-r--r-- 13.8 KB
extents.c -rw-r--r-- 15.5 KB
hfsplus_fs.h -rw-r--r-- 16.3 KB
hfsplus_raw.h -rw-r--r-- 9.5 KB
inode.c -rw-r--r-- 17.2 KB
ioctl.c -rw-r--r-- 3.7 KB
options.c -rw-r--r-- 5.3 KB
part_tbl.c -rw-r--r-- 4.2 KB
super.c -rw-r--r-- 17.9 KB
tables.c -rw-r--r-- 119.1 KB
unicode.c -rw-r--r-- 10.5 KB
wrapper.c -rw-r--r-- 7.0 KB
xattr.c -rw-r--r-- 23.3 KB
xattr.h -rw-r--r-- 1.2 KB
xattr_security.c -rw-r--r-- 2.0 KB
xattr_trusted.c -rw-r--r-- 1017 bytes
xattr_user.c -rw-r--r-- 963 bytes

back to top