https://github.com/torvalds/linux
Revision 7b2b55da1db10a5525460633ae4b6fb0be060c41 authored by Jason Xing on 25 August 2019, 00:54:53 UTC, committed by Linus Torvalds on 25 August 2019, 02:48:42 UTC
Only when calling the poll syscall the first time can user receive
POLLPRI correctly.  After that, user always fails to acquire the event
signal.

Reproduce case:
 1. Get the monitor code in Documentation/accounting/psi.txt
 2. Run it, and wait for the event triggered.
 3. Kill and restart the process.

The question is why we can end up with poll_scheduled = 1 but the work
not running (which would reset it to 0).  And the answer is because the
scheduling side sees group->poll_kworker under RCU protection and then
schedules it, but here we cancel the work and destroy the worker.  The
cancel needs to pair with resetting the poll_scheduled flag.

Link: http://lkml.kernel.org/r/1566357985-97781-1-git-send-email-joseph.qi@linux.alibaba.com
Signed-off-by: Jason Xing <kerneljasonxing@linux.alibaba.com>
Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Reviewed-by: Caspar Zhang <caspar@linux.alibaba.com>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent bb65f89
History
Tip revision: 7b2b55da1db10a5525460633ae4b6fb0be060c41 authored by Jason Xing on 25 August 2019, 00:54:53 UTC
psi: get poll_work to run when calling poll syscall next time
Tip revision: 7b2b55d
File Mode Size
Makefile -rw-r--r-- 381 bytes
clnt4xdr.c -rw-r--r-- 12.9 KB
clntlock.c -rw-r--r-- 7.5 KB
clntproc.c -rw-r--r-- 21.7 KB
clntxdr.c -rw-r--r-- 13.2 KB
host.c -rw-r--r-- 17.4 KB
mon.c -rw-r--r-- 14.4 KB
netns.h -rw-r--r-- 395 bytes
procfs.c -rw-r--r-- 1.8 KB
procfs.h -rw-r--r-- 474 bytes
svc.c -rw-r--r-- 19.4 KB
svc4proc.c -rw-r--r-- 14.6 KB
svclock.c -rw-r--r-- 27.0 KB
svcproc.c -rw-r--r-- 15.3 KB
svcshare.c -rw-r--r-- 2.4 KB
svcsubs.c -rw-r--r-- 10.4 KB
xdr.c -rw-r--r-- 7.2 KB
xdr4.c -rw-r--r-- 7.5 KB

back to top