https://github.com/torvalds/linux
Revision 7b2b55da1db10a5525460633ae4b6fb0be060c41 authored by Jason Xing on 25 August 2019, 00:54:53 UTC, committed by Linus Torvalds on 25 August 2019, 02:48:42 UTC
Only when calling the poll syscall the first time can user receive
POLLPRI correctly.  After that, user always fails to acquire the event
signal.

Reproduce case:
 1. Get the monitor code in Documentation/accounting/psi.txt
 2. Run it, and wait for the event triggered.
 3. Kill and restart the process.

The question is why we can end up with poll_scheduled = 1 but the work
not running (which would reset it to 0).  And the answer is because the
scheduling side sees group->poll_kworker under RCU protection and then
schedules it, but here we cancel the work and destroy the worker.  The
cancel needs to pair with resetting the poll_scheduled flag.

Link: http://lkml.kernel.org/r/1566357985-97781-1-git-send-email-joseph.qi@linux.alibaba.com
Signed-off-by: Jason Xing <kerneljasonxing@linux.alibaba.com>
Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Reviewed-by: Caspar Zhang <caspar@linux.alibaba.com>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent bb65f89
History
Tip revision: 7b2b55da1db10a5525460633ae4b6fb0be060c41 authored by Jason Xing on 25 August 2019, 00:54:53 UTC
psi: get poll_work to run when calling poll syscall next time
Tip revision: 7b2b55d
File Mode Size
Kconfig -rw-r--r-- 7.8 KB
Makefile -rw-r--r-- 891 bytes
block.c -rw-r--r-- 4.9 KB
cache.c -rw-r--r-- 11.0 KB
decompressor.c -rw-r--r-- 3.3 KB
decompressor.h -rw-r--r-- 1.3 KB
decompressor_multi.c -rw-r--r-- 4.5 KB
decompressor_multi_percpu.c -rw-r--r-- 2.2 KB
decompressor_single.c -rw-r--r-- 1.7 KB
dir.c -rw-r--r-- 5.2 KB
export.c -rw-r--r-- 4.0 KB
file.c -rw-r--r-- 13.5 KB
file_cache.c -rw-r--r-- 887 bytes
file_direct.c -rw-r--r-- 4.1 KB
fragment.c -rw-r--r-- 2.6 KB
id.c -rw-r--r-- 2.3 KB
inode.c -rw-r--r-- 11.8 KB
lz4_wrapper.c -rw-r--r-- 2.8 KB
lzo_wrapper.c -rw-r--r-- 2.4 KB
namei.c -rw-r--r-- 6.8 KB
page_actor.c -rw-r--r-- 2.5 KB
page_actor.h -rw-r--r-- 1.9 KB
squashfs.h -rw-r--r-- 3.4 KB
squashfs_fs.h -rw-r--r-- 10.3 KB
squashfs_fs_i.h -rw-r--r-- 764 bytes
squashfs_fs_sb.h -rw-r--r-- 1.5 KB
super.c -rw-r--r-- 12.9 KB
symlink.c -rw-r--r-- 3.0 KB
xattr.c -rw-r--r-- 6.7 KB
xattr.h -rw-r--r-- 923 bytes
xattr_id.c -rw-r--r-- 2.0 KB
xz_wrapper.c -rw-r--r-- 3.6 KB
zlib_wrapper.c -rw-r--r-- 2.4 KB
zstd_wrapper.c -rw-r--r-- 2.9 KB

back to top