Revision 7b34d5257a90c419d67c1c3b52f87a679845ef1e authored by Andrea Righi on 19 August 2010, 21:13:29 UTC, committed by Linus Torvalds on 20 August 2010, 16:34:54 UTC
The scatterlist is used uninitialized in kfifo_dma_in_prepare().  This
triggers the following bug if CONFIG_DEBUG_SG=y:

  ------------[ cut here ]------------
  kernel BUG at include/linux/scatterlist.h:65!
  invalid opcode: 0000 [#1] PREEMPT SMP
  ...
  Call Trace:
   [<ffffffff810a1eab>] setup_sgl+0x6b/0xe0
   [<ffffffffa03d7000>] ? example_init+0x0/0x265 [dma_example]
   [<ffffffff810a2021>] __kfifo_dma_in_prepare+0x21/0x30
   [<ffffffffa03d7124>] example_init+0x124/0x265 [dma_example]
   [<ffffffff810f9c55>] ? trace_module_notify+0x25/0x370
   [<ffffffff81110c6e>] ? free_pages_prepare+0x11e/0x1e0
   [<ffffffff8106f2b1>] ? get_parent_ip+0x11/0x50
   [<ffffffff810f9c55>] ? trace_module_notify+0x25/0x370
   [<ffffffff810b65fd>] ? trace_hardirqs_on+0xd/0x10
   [<ffffffff814beade>] ? mutex_unlock+0xe/0x10
   [<ffffffff810f9c71>] ? trace_module_notify+0x41/0x370
   [<ffffffff810a77d5>] ? __blocking_notifier_call_chain+0x45/0x80
   [<ffffffff81137b7a>] ? vfree+0x2a/0x30
   [<ffffffff810a6ac3>] ? up_read+0x23/0x40
   [<ffffffff810a77f5>] ? __blocking_notifier_call_chain+0x65/0x80
   [<ffffffff810001e3>] do_one_initcall+0x43/0x180
   [<ffffffff810c577a>] sys_init_module+0xba/0x200
   [<ffffffff8103819b>] system_call_fastpath+0x16/0x1b
  RIP  [<ffffffff810a1e31>] setup_sgl_buf+0x1a1/0x1b0
   RSP <ffff88006720dc98>
  ---[ end trace a72b979fd3c1d3a5 ]---

Add the proper initialization to avoid the bug.

Signed-off-by: Andrea Righi <arighi@develer.com>
Acked-by: Stefani Seibold <stefani@seibold.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 2aaf209
History
File Mode Size
.gitignore -rw-r--r-- 20 bytes
00-INDEX -rw-r--r-- 1.2 KB
Makefile -rw-r--r-- 263 bytes
active_mm.txt -rw-r--r-- 3.7 KB
balance -rw-r--r-- 5.0 KB
hugepage-mmap.c -rw-r--r-- 2.0 KB
hugepage-shm.c -rw-r--r-- 2.5 KB
hugetlbpage.txt -rw-r--r-- 14.8 KB
hwpoison.txt -rw-r--r-- 5.6 KB
ksm.txt -rw-r--r-- 4.3 KB
locking -rw-r--r-- 6.0 KB
map_hugetlb.c -rw-r--r-- 1.7 KB
numa -rw-r--r-- 8.7 KB
numa_memory_policy.txt -rw-r--r-- 22.6 KB
overcommit-accounting -rw-r--r-- 2.2 KB
page-types.c -rw-r--r-- 21.4 KB
page_migration -rw-r--r-- 6.5 KB
pagemap.txt -rw-r--r-- 5.5 KB
slabinfo.c -rw-r--r-- 32.4 KB
slub.txt -rw-r--r-- 10.2 KB
unevictable-lru.txt -rw-r--r-- 32.9 KB

back to top