Revision 7b34d5257a90c419d67c1c3b52f87a679845ef1e authored by Andrea Righi on 19 August 2010, 21:13:29 UTC, committed by Linus Torvalds on 20 August 2010, 16:34:54 UTC
The scatterlist is used uninitialized in kfifo_dma_in_prepare(). This triggers the following bug if CONFIG_DEBUG_SG=y: ------------[ cut here ]------------ kernel BUG at include/linux/scatterlist.h:65! invalid opcode: 0000 [#1] PREEMPT SMP ... Call Trace: [<ffffffff810a1eab>] setup_sgl+0x6b/0xe0 [<ffffffffa03d7000>] ? example_init+0x0/0x265 [dma_example] [<ffffffff810a2021>] __kfifo_dma_in_prepare+0x21/0x30 [<ffffffffa03d7124>] example_init+0x124/0x265 [dma_example] [<ffffffff810f9c55>] ? trace_module_notify+0x25/0x370 [<ffffffff81110c6e>] ? free_pages_prepare+0x11e/0x1e0 [<ffffffff8106f2b1>] ? get_parent_ip+0x11/0x50 [<ffffffff810f9c55>] ? trace_module_notify+0x25/0x370 [<ffffffff810b65fd>] ? trace_hardirqs_on+0xd/0x10 [<ffffffff814beade>] ? mutex_unlock+0xe/0x10 [<ffffffff810f9c71>] ? trace_module_notify+0x41/0x370 [<ffffffff810a77d5>] ? __blocking_notifier_call_chain+0x45/0x80 [<ffffffff81137b7a>] ? vfree+0x2a/0x30 [<ffffffff810a6ac3>] ? up_read+0x23/0x40 [<ffffffff810a77f5>] ? __blocking_notifier_call_chain+0x65/0x80 [<ffffffff810001e3>] do_one_initcall+0x43/0x180 [<ffffffff810c577a>] sys_init_module+0xba/0x200 [<ffffffff8103819b>] system_call_fastpath+0x16/0x1b RIP [<ffffffff810a1e31>] setup_sgl_buf+0x1a1/0x1b0 RSP <ffff88006720dc98> ---[ end trace a72b979fd3c1d3a5 ]--- Add the proper initialization to avoid the bug. Signed-off-by: Andrea Righi <arighi@develer.com> Acked-by: Stefani Seibold <stefani@seibold.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 2aaf209
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 683 bytes |
| datagram.c | -rw-r--r-- | 18.1 KB |
| dev.c | -rw-r--r-- | 147.3 KB |
| dev_addr_lists.c | -rw-r--r-- | 17.3 KB |
| drop_monitor.c | -rw-r--r-- | 8.6 KB |
| dst.c | -rw-r--r-- | 8.1 KB |
| ethtool.c | -rw-r--r-- | 38.3 KB |
| fib_rules.c | -rw-r--r-- | 16.5 KB |
| filter.c | -rw-r--r-- | 14.7 KB |
| flow.c | -rw-r--r-- | 10.2 KB |
| gen_estimator.c | -rw-r--r-- | 8.6 KB |
| gen_stats.c | -rw-r--r-- | 6.7 KB |
| iovec.c | -rw-r--r-- | 5.6 KB |
| kmap_skb.h | -rw-r--r-- | 360 bytes |
| link_watch.c | -rw-r--r-- | 5.4 KB |
| neighbour.c | -rw-r--r-- | 65.5 KB |
| net-sysfs.c | -rw-r--r-- | 22.7 KB |
| net-sysfs.h | -rw-r--r-- | 190 bytes |
| net-traces.c | -rw-r--r-- | 771 bytes |
| net_namespace.c | -rw-r--r-- | 13.3 KB |
| netevent.c | -rw-r--r-- | 2.0 KB |
| netpoll.c | -rw-r--r-- | 21.7 KB |
| pktgen.c | -rw-r--r-- | 93.9 KB |
| request_sock.c | -rw-r--r-- | 3.5 KB |
| rtnetlink.c | -rw-r--r-- | 43.7 KB |
| scm.c | -rw-r--r-- | 7.6 KB |
| skbuff.c | -rw-r--r-- | 75.2 KB |
| sock.c | -rw-r--r-- | 63.4 KB |
| stream.c | -rw-r--r-- | 5.1 KB |
| sysctl_net_core.c | -rw-r--r-- | 5.2 KB |
| timestamping.c | -rw-r--r-- | 2.9 KB |
| user_dma.c | -rw-r--r-- | 3.3 KB |
| utils.c | -rw-r--r-- | 6.2 KB |
Computing file changes ...
