Revision 7b34d5257a90c419d67c1c3b52f87a679845ef1e authored by Andrea Righi on 19 August 2010, 21:13:29 UTC, committed by Linus Torvalds on 20 August 2010, 16:34:54 UTC
The scatterlist is used uninitialized in kfifo_dma_in_prepare(). This triggers the following bug if CONFIG_DEBUG_SG=y: ------------[ cut here ]------------ kernel BUG at include/linux/scatterlist.h:65! invalid opcode: 0000 [#1] PREEMPT SMP ... Call Trace: [<ffffffff810a1eab>] setup_sgl+0x6b/0xe0 [<ffffffffa03d7000>] ? example_init+0x0/0x265 [dma_example] [<ffffffff810a2021>] __kfifo_dma_in_prepare+0x21/0x30 [<ffffffffa03d7124>] example_init+0x124/0x265 [dma_example] [<ffffffff810f9c55>] ? trace_module_notify+0x25/0x370 [<ffffffff81110c6e>] ? free_pages_prepare+0x11e/0x1e0 [<ffffffff8106f2b1>] ? get_parent_ip+0x11/0x50 [<ffffffff810f9c55>] ? trace_module_notify+0x25/0x370 [<ffffffff810b65fd>] ? trace_hardirqs_on+0xd/0x10 [<ffffffff814beade>] ? mutex_unlock+0xe/0x10 [<ffffffff810f9c71>] ? trace_module_notify+0x41/0x370 [<ffffffff810a77d5>] ? __blocking_notifier_call_chain+0x45/0x80 [<ffffffff81137b7a>] ? vfree+0x2a/0x30 [<ffffffff810a6ac3>] ? up_read+0x23/0x40 [<ffffffff810a77f5>] ? __blocking_notifier_call_chain+0x65/0x80 [<ffffffff810001e3>] do_one_initcall+0x43/0x180 [<ffffffff810c577a>] sys_init_module+0xba/0x200 [<ffffffff8103819b>] system_call_fastpath+0x16/0x1b RIP [<ffffffff810a1e31>] setup_sgl_buf+0x1a1/0x1b0 RSP <ffff88006720dc98> ---[ end trace a72b979fd3c1d3a5 ]--- Add the proper initialization to avoid the bug. Signed-off-by: Andrea Righi <arighi@develer.com> Acked-by: Stefani Seibold <stefani@seibold.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 2aaf209
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 2.8 KB |
| Makefile | -rw-r--r-- | 338 bytes |
| addr.c | -rw-r--r-- | 3.6 KB |
| addr.h | -rw-r--r-- | 3.0 KB |
| bcast.c | -rw-r--r-- | 22.8 KB |
| bcast.h | -rw-r--r-- | 3.6 KB |
| bearer.c | -rw-r--r-- | 17.4 KB |
| bearer.h | -rw-r--r-- | 5.9 KB |
| cluster.c | -rw-r--r-- | 14.6 KB |
| cluster.h | -rw-r--r-- | 3.6 KB |
| config.c | -rw-r--r-- | 20.4 KB |
| config.h | -rw-r--r-- | 3.0 KB |
| core.c | -rw-r--r-- | 7.6 KB |
| core.h | -rw-r--r-- | 9.4 KB |
| dbg.c | -rw-r--r-- | 11.0 KB |
| dbg.h | -rw-r--r-- | 2.8 KB |
| discover.c | -rw-r--r-- | 9.7 KB |
| discover.h | -rw-r--r-- | 2.3 KB |
| eth_media.c | -rw-r--r-- | 8.7 KB |
| handler.c | -rw-r--r-- | 4.0 KB |
| link.c | -rw-r--r-- | 86.1 KB |
| link.h | -rw-r--r-- | 10.5 KB |
| msg.c | -rw-r--r-- | 11.3 KB |
| msg.h | -rw-r--r-- | 16.3 KB |
| name_distr.c | -rw-r--r-- | 9.1 KB |
| name_distr.h | -rw-r--r-- | 2.1 KB |
| name_table.c | -rw-r--r-- | 28.2 KB |
| name_table.h | -rw-r--r-- | 4.1 KB |
| net.c | -rw-r--r-- | 9.5 KB |
| net.h | -rw-r--r-- | 2.4 KB |
| netlink.c | -rw-r--r-- | 3.4 KB |
| node.c | -rw-r--r-- | 19.9 KB |
| node.h | -rw-r--r-- | 5.5 KB |
| node_subscr.c | -rw-r--r-- | 2.8 KB |
| node_subscr.h | -rw-r--r-- | 2.6 KB |
| port.c | -rw-r--r-- | 40.3 KB |
| port.h | -rw-r--r-- | 6.2 KB |
| ref.c | -rw-r--r-- | 8.8 KB |
| ref.h | -rw-r--r-- | 2.1 KB |
| socket.c | -rw-r--r-- | 45.8 KB |
| subscr.c | -rw-r--r-- | 16.2 KB |
| subscr.h | -rw-r--r-- | 3.2 KB |
| user_reg.c | -rw-r--r-- | 6.5 KB |
| user_reg.h | -rw-r--r-- | 2.1 KB |
| zone.c | -rw-r--r-- | 4.6 KB |
| zone.h | -rw-r--r-- | 2.8 KB |
Computing file changes ...
