https://github.com/torvalds/linux
Revision 7ba1b689038726d34e3244c1ac9e2e18c2ea4787 authored by Ralf Baechle on 09 February 2017, 13:12:11 UTC, committed by David S. Miller on 10 February 2017, 18:41:13 UTC
If a USB-to-serial adapter is unplugged, the driver re-initializes, with dev->hard_header_len and dev->addr_len set to zero, instead of the correct values. If then a packet is sent through the half-dead interface, the kernel will panic due to running out of headroom in the skb when pushing for the AX.25 headers resulting in this panic: [<c0595468>] (skb_panic) from [<c0401f70>] (skb_push+0x4c/0x50) [<c0401f70>] (skb_push) from [<bf0bdad4>] (ax25_hard_header+0x34/0xf4 [ax25]) [<bf0bdad4>] (ax25_hard_header [ax25]) from [<bf0d05d4>] (ax_header+0x38/0x40 [mkiss]) [<bf0d05d4>] (ax_header [mkiss]) from [<c041b584>] (neigh_compat_output+0x8c/0xd8) [<c041b584>] (neigh_compat_output) from [<c043e7a8>] (ip_finish_output+0x2a0/0x914) [<c043e7a8>] (ip_finish_output) from [<c043f948>] (ip_output+0xd8/0xf0) [<c043f948>] (ip_output) from [<c043f04c>] (ip_local_out_sk+0x44/0x48) This patch makes mkiss behave like the 6pack driver. 6pack does not panic. In 6pack.c sp_setup() (same function name here) the values for dev->hard_header_len and dev->addr_len are set to the same values as in my mkiss patch. [ralf@linux-mips.org: Massages original submission to conform to the usual standards for patch submissions.] Signed-off-by: Thomas Osterried <thomas@osterried.de> Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent b85ea00
Tip revision: 7ba1b689038726d34e3244c1ac9e2e18c2ea4787 authored by Ralf Baechle on 09 February 2017, 13:12:11 UTC
NET: mkiss: Fix panic
NET: mkiss: Fix panic
Tip revision: 7ba1b68
File | Mode | Size |
---|---|---|
encrypted-keys | ||
Kconfig | -rw-r--r-- | 3.2 KB |
Makefile | -rw-r--r-- | 522 bytes |
big_key.c | -rw-r--r-- | 8.5 KB |
compat.c | -rw-r--r-- | 3.7 KB |
dh.c | -rw-r--r-- | 3.3 KB |
gc.c | -rw-r--r-- | 9.7 KB |
internal.h | -rw-r--r-- | 9.4 KB |
key.c | -rw-r--r-- | 30.1 KB |
keyctl.c | -rw-r--r-- | 41.3 KB |
keyring.c | -rw-r--r-- | 37.8 KB |
permission.c | -rw-r--r-- | 2.9 KB |
persistent.c | -rw-r--r-- | 4.5 KB |
proc.c | -rw-r--r-- | 8.7 KB |
process_keys.c | -rw-r--r-- | 20.6 KB |
request_key.c | -rw-r--r-- | 19.7 KB |
request_key_auth.c | -rw-r--r-- | 7.0 KB |
sysctl.c | -rw-r--r-- | 1.8 KB |
trusted.c | -rw-r--r-- | 29.4 KB |
trusted.h | -rw-r--r-- | 3.2 KB |
user_defined.c | -rw-r--r-- | 4.6 KB |
Computing file changes ...