https://github.com/Kitware/CMake
Revision 7beba98652212c7a44f291b51dd03681e5193c49 authored by Robert Maynard on 03 April 2014, 15:27:58 UTC, committed by Brad King on 03 April 2014, 16:58:58 UTC
QT4_CREATE_MOC_COMMAND is given a moc_flags argument that contains the
COMPILE_DEFINITIONS and a potentially large list of include directories.
Since it is a macro, the ${moc_flags} reference is replaced with this
content and sent through cmMakefile::ExpandVariablesInString (EVIS).
Since commit v3.0.0-rc1~138^2 (Qt4: Use generator expression in
COMPILE_DEFINITIONS, 2014-01-13) the COMPILE_DEFINITIONS value contains
a '$' so the EVIS fast-path is no longer used. Instead the full
cmCommandArgumentParserHelper is now used on the large input, which is
very slow (since it was originally created for hand-written code).
Change QT4_CREATE_MOC_COMMAND to a function instead of a macro to avoid
passing large content through EVIS. This makes it significantly faster.
1 parent a48de7d
Tip revision: 7beba98652212c7a44f291b51dd03681e5193c49 authored by Robert Maynard on 03 April 2014, 15:27:58 UTC
Qt4Macros: Make QT4_CREATE_MOC_COMMAND a function
Qt4Macros: Make QT4_CREATE_MOC_COMMAND a function
Tip revision: 7beba98
| File | Mode | Size |
|---|---|---|
| Auxiliary | ||
| Help | ||
| Licenses | ||
| Modules | ||
| Source | ||
| Templates | ||
| Tests | ||
| Utilities | ||
| .gitattributes | -rw-r--r-- | 569 bytes |
| .hooks-config.bash | -rw-r--r-- | 866 bytes |
| CMakeCPack.cmake | -rw-r--r-- | 5.1 KB |
| CMakeCPackOptions.cmake.in | -rw-r--r-- | 2.7 KB |
| CMakeGraphVizOptions.cmake | -rw-r--r-- | 153 bytes |
| CMakeLists.txt | -rw-r--r-- | 21.8 KB |
| CMakeLogo.gif | -rw-r--r-- | 4.4 KB |
| CONTRIBUTING.rst | -rw-r--r-- | 1001 bytes |
| CTestConfig.cmake | -rw-r--r-- | 1.0 KB |
| CTestCustom.cmake.in | -rw-r--r-- | 3.3 KB |
| CTestCustom.ctest.in | -rw-r--r-- | 145 bytes |
| CompileFlags.cmake | -rw-r--r-- | 2.5 KB |
| Copyright.txt | -rw-r--r-- | 2.6 KB |
| DartConfig.cmake | -rw-r--r-- | 809 bytes |
| DartLocal.conf.in | -rw-r--r-- | 4.0 KB |
| README.rst | -rw-r--r-- | 2.5 KB |
| bootstrap | -rwxr-xr-x | 55.2 KB |
| cmake_uninstall.cmake.in | -rw-r--r-- | 796 bytes |
| configure | -rwxr-xr-x | 99 bytes |
| doxygen.config | -rw-r--r-- | 27.4 KB |
Computing file changes ...
