Skip to main content

Browse the archive

Revision 7c1c8ce5acc882fa0496b71b9a9813d1dff47e0f authored by Andrew Kryczka on 05 May 2017, 00:40:29 UTC, committed by Facebook Github Bot on 05 May 2017, 00:43:22 UTC 
Avoid calling fallocate with UINT64_MAX
 
Summary:
When user doesn't set a limit on compaction output file size, let's use the sum of the input files' sizes. This will avoid passing UINT64_MAX as fallocate()'s length. Reported in #2249.

Test setup:
- command: `TEST_TMPDIR=/data/rocksdb-test/ strace -e fallocate ./db_compaction_test --gtest_filter=DBCompactionTest.ManualCompactionUnknownOutputSize`
- filesystem: xfs

before this diff:
`fallocate(10, 01, 0, 1844674407370955160) = -1 ENOSPC (No space left on device)`

after this diff:
`fallocate(10, 01, 0, 1977)              = 0`
Closes https://github.com/facebook/rocksdb/pull/2252

Differential Revision: D5007275

Pulled By: ajkr

fbshipit-source-id: 4491404a6ae8a41328aede2e2d6f4d9ac3e38880
1 parent a45e98a
History
File Mode Size
2014-03-27-how-to-backup-rocksdb.markdown -rw-r--r-- 7.6 KB
2014-03-27-how-to-persist-in-memory-rocksdb-database.markdown -rw-r--r-- 3.4 KB
2014-04-02-the-1st-rocksdb-local-meetup-held-on-march-27-2014.markdown -rw-r--r-- 2.1 KB
2014-04-07-rocksdb-2-8-release.markdown -rw-r--r-- 1.6 KB
2014-04-21-indexing-sst-files-for-better-lookup-performance.markdown -rw-r--r-- 3.8 KB
2014-05-14-lock.markdown -rw-r--r-- 9.3 KB
2014-05-19-rocksdb-3-0-release.markdown -rw-r--r-- 662 bytes
2014-05-22-rocksdb-3-1-release.markdown -rw-r--r-- 577 bytes
2014-06-23-plaintable-a-new-file-format.markdown -rw-r--r-- 3.0 KB
2014-06-27-avoid-expensive-locks-in-get.markdown -rw-r--r-- 4.7 KB
2014-06-27-rocksdb-3-2-release.markdown -rw-r--r-- 1.0 KB
2014-07-29-rocksdb-3-3-release.markdown -rw-r--r-- 1.6 KB
2014-09-12-cuckoo.markdown -rw-r--r-- 4.4 KB
2014-09-12-new-bloom-filter-format.markdown -rw-r--r-- 3.1 KB
2014-09-15-rocksdb-3-5-release.markdown -rw-r--r-- 1.3 KB
2015-01-16-migrating-from-leveldb-to-rocksdb-2.markdown -rw-r--r-- 3.1 KB
2015-02-24-reading-rocksdb-options-from-a-file.markdown -rw-r--r-- 1.7 KB
2015-02-27-write-batch-with-index.markdown -rw-r--r-- 3.8 KB
2015-04-22-integrating-rocksdb-with-mongodb-2.markdown -rw-r--r-- 902 bytes
2015-06-12-rocksdb-in-osquery.markdown -rw-r--r-- 502 bytes
2015-07-15-rocksdb-2015-h2-roadmap.markdown -rw-r--r-- 3.0 KB
2015-07-17-spatial-indexing-in-rocksdb.markdown -rw-r--r-- 4.8 KB
2015-07-22-rocksdb-is-now-available-in-windows-platform.markdown -rw-r--r-- 1.0 KB
2015-07-23-dynamic-level.markdown -rw-r--r-- 4.3 KB
2015-10-27-getthreadlist.markdown -rw-r--r-- 5.0 KB
2015-11-10-use-checkpoints-for-efficient-snapshots.markdown -rw-r--r-- 2.0 KB
2015-11-16-analysis-file-read-latency-by-level.markdown -rw-r--r-- 12.1 KB
2016-01-29-compaction_pri.markdown -rw-r--r-- 6.9 KB
2016-02-24-rocksdb-4-2-release.markdown -rw-r--r-- 1.3 KB
2016-02-25-rocksdb-ama.markdown -rw-r--r-- 731 bytes
2016-03-07-rocksdb-options-file.markdown -rw-r--r-- 1.2 KB
2016-04-26-rocksdb-4-5-1-released.markdown -rw-r--r-- 2.8 KB
2016-07-26-rocksdb-4-8-released.markdown -rw-r--r-- 3.5 KB
2016-09-28-rocksdb-4-11-2-released.markdown -rw-r--r-- 2.2 KB
2017-01-06-rocksdb-5-0-1-released.markdown -rw-r--r-- 2.0 KB
2017-02-07-rocksdb-5-1-2-released.markdown -rw-r--r-- 662 bytes
2017-02-17-bulkoad-ingest-sst-file.markdown -rw-r--r-- 2.3 KB
2017-03-02-rocksdb-5-2-1-released.markdown -rw-r--r-- 1.3 KB
back to top