Revision 7c1c8ce5acc882fa0496b71b9a9813d1dff47e0f authored by Andrew Kryczka on 05 May 2017, 00:40:29 UTC, committed by Facebook Github Bot on 05 May 2017, 00:43:22 UTC
Summary:
When user doesn't set a limit on compaction output file size, let's use the sum of the input files' sizes. This will avoid passing UINT64_MAX as fallocate()'s length. Reported in #2249.

Test setup:
- command: `TEST_TMPDIR=/data/rocksdb-test/ strace -e fallocate ./db_compaction_test --gtest_filter=DBCompactionTest.ManualCompactionUnknownOutputSize`
- filesystem: xfs

before this diff:
`fallocate(10, 01, 0, 1844674407370955160) = -1 ENOSPC (No space left on device)`

after this diff:
`fallocate(10, 01, 0, 1977)              = 0`
Closes https://github.com/facebook/rocksdb/pull/2252

Differential Revision: D5007275

Pulled By: ajkr

fbshipit-source-id: 4491404a6ae8a41328aede2e2d6f4d9ac3e38880
1 parent a45e98a
History
File Mode Size
_base.scss -rw-r--r-- 7.6 KB
_blog.scss -rw-r--r-- 695 bytes
_buttons.scss -rw-r--r-- 779 bytes
_footer.scss -rw-r--r-- 1.4 KB
_gridBlock.scss -rw-r--r-- 1.9 KB
_header.scss -rw-r--r-- 2.2 KB
_poweredby.scss -rw-r--r-- 1.0 KB
_promo.scss -rw-r--r-- 787 bytes
_react_docs_nav.scss -rw-r--r-- 5.4 KB
_react_header_nav.scss -rw-r--r-- 2.6 KB
_reset.scss -rw-r--r-- 988 bytes
_search.scss -rw-r--r-- 3.1 KB
_slideshow.scss -rw-r--r-- 803 bytes
_syntax-highlighting.scss -rw-r--r-- 5.2 KB
_tables.scss -rw-r--r-- 838 bytes

back to top