Revision 7c96c90ed8f1b469c37f06c37f248c42535060b8 authored by Hiroki Nakagawa on 26 March 2018, 09:29:42 UTC, committed by Chromium WPT Sync on 26 March 2018, 09:29:42 UTC
This CL allows dynamic import() on DedicatedWorkerGlobalScope and adds WPT tests. Note that ES Modules on DedicatedWorker is an experimental feature behind the runtime flag. Design doc: https://docs.google.com/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit#heading=h.637avx8i5qtn Bug: 680046 Change-Id: I1f8fed5c319aab634f96bcfabeb3c95f5dc7d9a7 Reviewed-on: https://chromium-review.googlesource.com/970127 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#545748}
1 parent 4ff4c66
RTCPeerConnection-setLocalDescription-answer.html
<!doctype html>
<meta charset=utf-8>
<title>RTCPeerConnection.prototype.setLocalDescription</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="RTCPeerConnection-helper.js"></script>
<script>
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
// generateOffer
// generateAnswer
// assert_session_desc_equals
// test_state_change_event
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setRemoteDescription(
RTCSessionDescriptionInit description);
readonly attribute RTCSessionDescription? remoteDescription;
readonly attribute RTCSessionDescription? currentRemoteDescription;
readonly attribute RTCSessionDescription? pendingRemoteDescription;
...
};
4.6.2. RTCSessionDescription Class
dictionary RTCSessionDescriptionInit {
required RTCSdpType type;
DOMString sdp = "";
};
4.6.1. RTCSdpType
enum RTCSdpType {
"offer",
"pranswer",
"answer",
"rollback"
};
*/
/*
4.3.1.6. Set the RTCSessionSessionDescription
2.2.2. If description is set as a local description, then run one of the following
steps:
- If description is of type "answer", then this completes an offer answer
negotiation.
Set connection's currentLocalDescription to description and
currentRemoteDescription to the value of pendingRemoteDescription.
Set both pendingRemoteDescription and pendingLocalDescription to null.
Finally set connection's signaling state to stable.
*/
promise_test(t => {
const pc = new RTCPeerConnection();
test_state_change_event(t, pc, ['have-remote-offer', 'stable']);
return pc.createOffer({ offerToReceiveVideo: true })
.then(offer =>
pc.setRemoteDescription(offer)
.then(() => pc.createAnswer())
.then(answer =>
pc.setLocalDescription(answer)
.then(() => {
assert_equals(pc.signalingState, 'stable');
assert_session_desc_equals(pc.localDescription, answer);
assert_session_desc_equals(pc.remoteDescription, offer);
assert_session_desc_equals(pc.currentLocalDescription, answer);
assert_session_desc_equals(pc.currentRemoteDescription, offer);
assert_equals(pc.pendingLocalDescription, null);
assert_equals(pc.pendingRemoteDescription, null);
})));
}, 'setLocalDescription() with valid answer should succeed');
/*
4.3.2. setLocalDescription
3. Let lastAnswer be the result returned by the last call to createAnswer.
4. If description.sdp is null and description.type is answer, set description.sdp
to lastAnswer.
*/
promise_test(t => {
const pc = new RTCPeerConnection();
return pc.createOffer({ offerToReceiveVideo: true })
.then(offer =>
pc.setRemoteDescription(offer)
.then(() => pc.createAnswer())
.then(answer =>
pc.setLocalDescription({ type: 'answer' })
.then(() => {
assert_equals(pc.signalingState, 'stable');
assert_session_desc_equals(pc.localDescription, answer);
assert_session_desc_equals(pc.remoteDescription, offer);
assert_session_desc_equals(pc.currentLocalDescription, answer);
assert_session_desc_equals(pc.currentRemoteDescription, offer);
assert_equals(pc.pendingLocalDescription, null);
assert_equals(pc.pendingRemoteDescription, null);
})));
}, 'setLocalDescription() with type answer and null sdp should use lastAnswer generated from createAnswer');
/*
4.3.2. setLocalDescription
3. Let lastAnswer be the result returned by the last call to createAnswer.
7. If description.type is answer and description.sdp does not match lastAnswer,
reject the promise with a newly created InvalidModificationError and abort these
steps.
*/
promise_test(t => {
const pc = new RTCPeerConnection();
return pc.createOffer({ offerToReceiveVideo: true })
.then(offer =>
pc.setRemoteDescription(offer)
.then(() => generateAnswer(offer))
.then(answer =>
promise_rejects(t, 'InvalidModificationError',
pc.setLocalDescription(answer))));
}, 'setLocalDescription() with answer not created by own createAnswer() should reject with InvalidModificationError');
/*
4.3.1.6. Set the RTCSessionSessionDescription
2.3. If the description's type is invalid for the current signaling state of
connection, then reject p with a newly created InvalidStateError and abort
these steps.
[jsep]
5.5. If the type is "pranswer" or "answer", the PeerConnection
state MUST be either "have-remote-offer" or "have-local-pranswer".
*/
promise_test(t => {
const pc = new RTCPeerConnection();
return pc.createOffer()
.then(offer =>
promise_rejects(t, 'InvalidStateError',
pc.setLocalDescription({ type: 'answer', sdp: offer.sdp })));
}, 'Calling setLocalDescription(answer) from stable state should reject with InvalidStateError');
promise_test(t => {
const pc = new RTCPeerConnection();
return pc.createOffer()
.then(offer =>
pc.setLocalDescription(offer)
.then(() => generateAnswer(offer)))
.then(answer =>
promise_rejects(t, 'InvalidStateError',
pc.setLocalDescription(answer)));
}, 'Calling setLocalDescription(answer) from have-local-offer state should reject with InvalidStateError');
</script>
Computing file changes ...