Revision 7ce9d5d1f3c8736511daa413c64985a05b2feee3 authored by Eric Sandeen on 04 March 2009, 23:38:18 UTC, committed by Theodore Ts'o on 04 March 2009, 23:38:18 UTC
I was seeing fsck errors on inode bitmaps after a 4 thread dbench run on a 4 cpu machine: Inode bitmap differences: -50736 -(50752--50753) etc... I believe that this is because ext4_free_inode() uses atomic bitops, and although ext4_new_inode() *used* to also use atomic bitops for synchronization, commit 393418676a7602e1d7d3f6e560159c65c8cbd50e changed this to use the sb_bgl_lock, so that we could also synchronize against read_inode_bitmap and initialization of uninit inode tables. However, that change left ext4_free_inode using atomic bitops, which I think leaves no synchronization between setting & unsetting bits in the inode table. The below patch fixes it for me, although I wonder if we're getting at all heavy-handed with this spinlock... Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
1 parent fec6c6f
| File | Mode | Size |
|---|---|---|
| aoe | ||
| paride | ||
| DAC960.c | -rw-r--r-- | 259.5 KB |
| DAC960.h | -rw-r--r-- | 148.2 KB |
| Kconfig | -rw-r--r-- | 15.9 KB |
| Makefile | -rw-r--r-- | 1.1 KB |
| amiflop.c | -rw-r--r-- | 46.2 KB |
| ataflop.c | -rw-r--r-- | 51.1 KB |
| brd.c | -rw-r--r-- | 13.7 KB |
| cciss.c | -rw-r--r-- | 112.1 KB |
| cciss.h | -rw-r--r-- | 7.0 KB |
| cciss_cmd.h | -rw-r--r-- | 7.9 KB |
| cciss_scsi.c | -rw-r--r-- | 47.1 KB |
| cciss_scsi.h | -rw-r--r-- | 3.1 KB |
| cpqarray.c | -rw-r--r-- | 47.1 KB |
| cpqarray.h | -rw-r--r-- | 3.0 KB |
| cryptoloop.c | -rw-r--r-- | 4.9 KB |
| floppy.c | -rw-r--r-- | 116.6 KB |
| hd.c | -rw-r--r-- | 19.0 KB |
| ida_cmd.h | -rw-r--r-- | 6.8 KB |
| ida_ioctl.h | -rw-r--r-- | 2.6 KB |
| loop.c | -rw-r--r-- | 39.1 KB |
| nbd.c | -rw-r--r-- | 20.0 KB |
| pktcdvd.c | -rw-r--r-- | 76.4 KB |
| ps3disk.c | -rw-r--r-- | 14.3 KB |
| smart1,2.h | -rw-r--r-- | 7.1 KB |
| sunvdc.c | -rw-r--r-- | 19.3 KB |
| swim3.c | -rw-r--r-- | 29.3 KB |
| sx8.c | -rw-r--r-- | 40.0 KB |
| ub.c | -rw-r--r-- | 62.4 KB |
| umem.c | -rw-r--r-- | 30.0 KB |
| umem.h | -rw-r--r-- | 3.6 KB |
| viodasd.c | -rw-r--r-- | 21.7 KB |
| virtio_blk.c | -rw-r--r-- | 9.4 KB |
| xd.c | -rw-r--r-- | 33.7 KB |
| xd.h | -rw-r--r-- | 5.7 KB |
| xen-blkfront.c | -rw-r--r-- | 26.7 KB |
| xsysace.c | -rw-r--r-- | 33.4 KB |
| z2ram.c | -rw-r--r-- | 8.8 KB |
Computing file changes ...
