Revision 7ce9d5d1f3c8736511daa413c64985a05b2feee3 authored by Eric Sandeen on 04 March 2009, 23:38:18 UTC, committed by Theodore Ts'o on 04 March 2009, 23:38:18 UTC
I was seeing fsck errors on inode bitmaps after a 4 thread dbench run on a 4 cpu machine: Inode bitmap differences: -50736 -(50752--50753) etc... I believe that this is because ext4_free_inode() uses atomic bitops, and although ext4_new_inode() *used* to also use atomic bitops for synchronization, commit 393418676a7602e1d7d3f6e560159c65c8cbd50e changed this to use the sb_bgl_lock, so that we could also synchronize against read_inode_bitmap and initialization of uninit inode tables. However, that change left ext4_free_inode using atomic bitops, which I think leaves no synchronization between setting & unsetting bits in the inode table. The below patch fixes it for me, although I wonder if we're getting at all heavy-handed with this spinlock... Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
1 parent fec6c6f
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 2.8 KB |
| Makefile | -rw-r--r-- | 362 bytes |
| fw-card.c | -rw-r--r-- | 14.0 KB |
| fw-cdev.c | -rw-r--r-- | 25.9 KB |
| fw-device.c | -rw-r--r-- | 27.7 KB |
| fw-device.h | -rw-r--r-- | 4.8 KB |
| fw-iso.c | -rw-r--r-- | 3.9 KB |
| fw-ohci.c | -rw-r--r-- | 72.0 KB |
| fw-ohci.h | -rw-r--r-- | 6.9 KB |
| fw-sbp2.c | -rw-r--r-- | 47.5 KB |
| fw-topology.c | -rw-r--r-- | 14.6 KB |
| fw-topology.h | -rw-r--r-- | 1.8 KB |
| fw-transaction.c | -rw-r--r-- | 26.3 KB |
| fw-transaction.h | -rw-r--r-- | 13.4 KB |
Computing file changes ...
