Revision 7ce9d5d1f3c8736511daa413c64985a05b2feee3 authored by Eric Sandeen on 04 March 2009, 23:38:18 UTC, committed by Theodore Ts'o on 04 March 2009, 23:38:18 UTC
I was seeing fsck errors on inode bitmaps after a 4 thread dbench run on a 4 cpu machine: Inode bitmap differences: -50736 -(50752--50753) etc... I believe that this is because ext4_free_inode() uses atomic bitops, and although ext4_new_inode() *used* to also use atomic bitops for synchronization, commit 393418676a7602e1d7d3f6e560159c65c8cbd50e changed this to use the sb_bgl_lock, so that we could also synchronize against read_inode_bitmap and initialization of uninit inode tables. However, that change left ext4_free_inode using atomic bitops, which I think leaves no synchronization between setting & unsetting bits in the inode table. The below patch fixes it for me, although I wonder if we're getting at all heavy-handed with this spinlock... Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
1 parent fec6c6f
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 5.9 KB |
| Makefile | -rw-r--r-- | 600 bytes |
| config_roms.c | -rw-r--r-- | 4.5 KB |
| config_roms.h | -rw-r--r-- | 588 bytes |
| csr.c | -rw-r--r-- | 25.8 KB |
| csr.h | -rw-r--r-- | 2.6 KB |
| csr1212.c | -rw-r--r-- | 37.8 KB |
| csr1212.h | -rw-r--r-- | 14.2 KB |
| dma.c | -rw-r--r-- | 6.2 KB |
| dma.h | -rw-r--r-- | 2.5 KB |
| dv1394-private.h | -rw-r--r-- | 17.1 KB |
| dv1394.c | -rw-r--r-- | 72.5 KB |
| dv1394.h | -rw-r--r-- | 10.2 KB |
| eth1394.c | -rw-r--r-- | 47.1 KB |
| eth1394.h | -rw-r--r-- | 6.4 KB |
| highlevel.c | -rw-r--r-- | 17.5 KB |
| highlevel.h | -rw-r--r-- | 5.2 KB |
| hosts.c | -rw-r--r-- | 6.3 KB |
| hosts.h | -rw-r--r-- | 5.9 KB |
| ieee1394-ioctl.h | -rw-r--r-- | 3.6 KB |
| ieee1394.h | -rw-r--r-- | 5.6 KB |
| ieee1394_core.c | -rw-r--r-- | 36.7 KB |
| ieee1394_core.h | -rw-r--r-- | 5.2 KB |
| ieee1394_hotplug.h | -rw-r--r-- | 549 bytes |
| ieee1394_transactions.c | -rw-r--r-- | 14.2 KB |
| ieee1394_transactions.h | -rw-r--r-- | 1.6 KB |
| ieee1394_types.h | -rw-r--r-- | 1.7 KB |
| init_ohci1394_dma.c | -rw-r--r-- | 9.2 KB |
| iso.c | -rw-r--r-- | 13.0 KB |
| iso.h | -rw-r--r-- | 5.9 KB |
| nodemgr.c | -rw-r--r-- | 51.3 KB |
| nodemgr.h | -rw-r--r-- | 5.6 KB |
| ohci1394.c | -rw-r--r-- | 102.3 KB |
| ohci1394.h | -rw-r--r-- | 15.9 KB |
| pcilynx.c | -rw-r--r-- | 52.0 KB |
| pcilynx.h | -rw-r--r-- | 15.8 KB |
| raw1394-private.h | -rw-r--r-- | 2.1 KB |
| raw1394.c | -rw-r--r-- | 82.9 KB |
| raw1394.h | -rw-r--r-- | 5.0 KB |
| sbp2.c | -rw-r--r-- | 63.5 KB |
| sbp2.h | -rw-r--r-- | 9.9 KB |
| video1394.c | -rw-r--r-- | 42.0 KB |
| video1394.h | -rw-r--r-- | 2.0 KB |
Computing file changes ...
