Revision 7ce9d5d1f3c8736511daa413c64985a05b2feee3 authored by Eric Sandeen on 04 March 2009, 23:38:18 UTC, committed by Theodore Ts'o on 04 March 2009, 23:38:18 UTC
I was seeing fsck errors on inode bitmaps after a 4 thread dbench run on a 4 cpu machine: Inode bitmap differences: -50736 -(50752--50753) etc... I believe that this is because ext4_free_inode() uses atomic bitops, and although ext4_new_inode() *used* to also use atomic bitops for synchronization, commit 393418676a7602e1d7d3f6e560159c65c8cbd50e changed this to use the sb_bgl_lock, so that we could also synchronize against read_inode_bitmap and initialization of uninit inode tables. However, that change left ext4_free_inode using atomic bitops, which I think leaves no synchronization between setting & unsetting bits in the inode table. The below patch fixes it for me, although I wonder if we're getting at all heavy-handed with this spinlock... Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
1 parent fec6c6f
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 7.3 KB |
Makefile | -rw-r--r-- | 1.2 KB |
asic3.c | -rw-r--r-- | 15.3 KB |
da903x.c | -rw-r--r-- | 13.1 KB |
dm355evm_msp.c | -rw-r--r-- | 10.5 KB |
htc-egpio.c | -rw-r--r-- | 10.8 KB |
htc-pasic3.c | -rw-r--r-- | 6.1 KB |
mcp-core.c | -rw-r--r-- | 5.8 KB |
mcp-sa11x0.c | -rw-r--r-- | 5.7 KB |
mcp.h | -rw-r--r-- | 1.9 KB |
menelaus.c | -rw-r--r-- | 29.7 KB |
mfd-core.c | -rw-r--r-- | 2.7 KB |
pcf50633-adc.c | -rw-r--r-- | 6.3 KB |
pcf50633-core.c | -rw-r--r-- | 16.1 KB |
pcf50633-gpio.c | -rw-r--r-- | 3.3 KB |
sm501.c | -rw-r--r-- | 40.5 KB |
t7l66xb.c | -rw-r--r-- | 10.4 KB |
tc6387xb.c | -rw-r--r-- | 4.1 KB |
tc6393xb.c | -rw-r--r-- | 20.9 KB |
tps65010.c | -rw-r--r-- | 27.7 KB |
twl4030-core.c | -rw-r--r-- | 21.1 KB |
twl4030-irq.c | -rw-r--r-- | 19.2 KB |
ucb1400_core.c | -rw-r--r-- | 2.3 KB |
ucb1x00-assabet.c | -rw-r--r-- | 2.1 KB |
ucb1x00-core.c | -rw-r--r-- | 16.4 KB |
ucb1x00-ts.c | -rw-r--r-- | 10.3 KB |
ucb1x00.h | -rw-r--r-- | 6.7 KB |
wm8350-core.c | -rw-r--r-- | 42.8 KB |
wm8350-gpio.c | -rw-r--r-- | 6.1 KB |
wm8350-i2c.c | -rw-r--r-- | 2.8 KB |
wm8350-regmap.c | -rw-r--r-- | 124.1 KB |
wm8400-core.c | -rw-r--r-- | 12.8 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...