Revision 7ce9d5d1f3c8736511daa413c64985a05b2feee3 authored by Eric Sandeen on 04 March 2009, 23:38:18 UTC, committed by Theodore Ts'o on 04 March 2009, 23:38:18 UTC
I was seeing fsck errors on inode bitmaps after a 4 thread dbench run on a 4 cpu machine: Inode bitmap differences: -50736 -(50752--50753) etc... I believe that this is because ext4_free_inode() uses atomic bitops, and although ext4_new_inode() *used* to also use atomic bitops for synchronization, commit 393418676a7602e1d7d3f6e560159c65c8cbd50e changed this to use the sb_bgl_lock, so that we could also synchronize against read_inode_bitmap and initialization of uninit inode tables. However, that change left ext4_free_inode using atomic bitops, which I think leaves no synchronization between setting & unsetting bits in the inode table. The below patch fixes it for me, although I wonder if we're getting at all heavy-handed with this spinlock... Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
1 parent fec6c6f
| File | Mode | Size |
|---|---|---|
| cs5345.h | -rw-r--r-- | 1.2 KB |
| cs53l32a.h | -rw-r--r-- | 1.2 KB |
| cx2341x.h | -rw-r--r-- | 7.1 KB |
| cx25840.h | -rw-r--r-- | 2.5 KB |
| i2c-addr.h | -rw-r--r-- | 1.2 KB |
| ir-common.h | -rw-r--r-- | 6.6 KB |
| ir-kbd-i2c.h | -rw-r--r-- | 453 bytes |
| m52790.h | -rw-r--r-- | 2.7 KB |
| msp3400.h | -rw-r--r-- | 8.3 KB |
| ov772x.h | -rw-r--r-- | 510 bytes |
| ovcamchip.h | -rw-r--r-- | 2.5 KB |
| pwc-ioctl.h | -rw-r--r-- | 10.5 KB |
| rds.h | -rw-r--r-- | 1.3 KB |
| saa6752hs.h | -rw-r--r-- | 887 bytes |
| saa7115.h | -rw-r--r-- | 2.0 KB |
| saa7127.h | -rw-r--r-- | 1.2 KB |
| saa7146.h | -rw-r--r-- | 17.7 KB |
| saa7146_vv.h | -rw-r--r-- | 7.5 KB |
| sh_mobile_ceu.h | -rw-r--r-- | 203 bytes |
| soc_camera.h | -rw-r--r-- | 9.0 KB |
| soc_camera_platform.h | -rw-r--r-- | 637 bytes |
| tuner-types.h | -rw-r--r-- | 4.6 KB |
| tuner.h | -rw-r--r-- | 7.3 KB |
| tvaudio.h | -rw-r--r-- | 1.0 KB |
| tveeprom.h | -rw-r--r-- | 828 bytes |
| tvp514x.h | -rw-r--r-- | 3.1 KB |
| tvp5150.h | -rw-r--r-- | 1.0 KB |
| tw9910.h | -rw-r--r-- | 823 bytes |
| upd64031a.h | -rw-r--r-- | 1.3 KB |
| upd64083.h | -rw-r--r-- | 2.2 KB |
| v4l2-chip-ident.h | -rw-r--r-- | 5.2 KB |
| v4l2-common.h | -rw-r--r-- | 12.0 KB |
| v4l2-dev.h | -rw-r--r-- | 4.2 KB |
| v4l2-device.h | -rw-r--r-- | 4.3 KB |
| v4l2-i2c-drv-legacy.h | -rw-r--r-- | 5.0 KB |
| v4l2-i2c-drv.h | -rw-r--r-- | 2.8 KB |
| v4l2-int-device.h | -rw-r--r-- | 7.7 KB |
| v4l2-ioctl.h | -rw-r--r-- | 11.1 KB |
| v4l2-subdev.h | -rw-r--r-- | 7.0 KB |
| videobuf-core.h | -rw-r--r-- | 7.4 KB |
| videobuf-dma-contig.h | -rw-r--r-- | 1.0 KB |
| videobuf-dma-sg.h | -rw-r--r-- | 3.8 KB |
| videobuf-dvb.h | -rw-r--r-- | 1.6 KB |
| videobuf-vmalloc.h | -rw-r--r-- | 1.2 KB |
| wm8775.h | -rw-r--r-- | 1.2 KB |
Computing file changes ...
