Revision 7ce9d5d1f3c8736511daa413c64985a05b2feee3 authored by Eric Sandeen on 04 March 2009, 23:38:18 UTC, committed by Theodore Ts'o on 04 March 2009, 23:38:18 UTC
I was seeing fsck errors on inode bitmaps after a 4 thread dbench run on a 4 cpu machine: Inode bitmap differences: -50736 -(50752--50753) etc... I believe that this is because ext4_free_inode() uses atomic bitops, and although ext4_new_inode() *used* to also use atomic bitops for synchronization, commit 393418676a7602e1d7d3f6e560159c65c8cbd50e changed this to use the sb_bgl_lock, so that we could also synchronize against read_inode_bitmap and initialization of uninit inode tables. However, that change left ext4_free_inode using atomic bitops, which I think leaves no synchronization between setting & unsetting bits in the inode table. The below patch fixes it for me, although I wonder if we're getting at all heavy-handed with this spinlock... Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
1 parent fec6c6f
| File | Mode | Size |
|---|---|---|
| fc | ||
| fc_encode.h | -rw-r--r-- | 7.7 KB |
| fc_frame.h | -rw-r--r-- | 6.6 KB |
| fc_transport_fcoe.h | -rw-r--r-- | 1.6 KB |
| iscsi_if.h | -rw-r--r-- | 11.5 KB |
| iscsi_proto.h | -rw-r--r-- | 14.9 KB |
| libfc.h | -rw-r--r-- | 23.7 KB |
| libfcoe.h | -rw-r--r-- | 4.7 KB |
| libiscsi.h | -rw-r--r-- | 12.3 KB |
| libiscsi_tcp.h | -rw-r--r-- | 4.2 KB |
| libsas.h | -rw-r--r-- | 17.4 KB |
| libsrp.h | -rw-r--r-- | 1.5 KB |
| sas.h | -rw-r--r-- | 11.7 KB |
| sas_ata.h | -rw-r--r-- | 1.6 KB |
| scsi.h | -rw-r--r-- | 16.3 KB |
| scsi_cmnd.h | -rw-r--r-- | 8.0 KB |
| scsi_dbg.h | -rw-r--r-- | 968 bytes |
| scsi_device.h | -rw-r--r-- | 16.3 KB |
| scsi_devinfo.h | -rw-r--r-- | 1.9 KB |
| scsi_dh.h | -rw-r--r-- | 2.4 KB |
| scsi_driver.h | -rw-r--r-- | 995 bytes |
| scsi_eh.h | -rw-r--r-- | 2.7 KB |
| scsi_host.h | -rw-r--r-- | 26.0 KB |
| scsi_ioctl.h | -rw-r--r-- | 1.2 KB |
| scsi_netlink.h | -rw-r--r-- | 4.2 KB |
| scsi_netlink_fc.h | -rw-r--r-- | 1.9 KB |
| scsi_tcq.h | -rw-r--r-- | 4.3 KB |
| scsi_tgt.h | -rw-r--r-- | 807 bytes |
| scsi_tgt_if.h | -rw-r--r-- | 2.5 KB |
| scsi_transport.h | -rw-r--r-- | 3.9 KB |
| scsi_transport_fc.h | -rw-r--r-- | 23.9 KB |
| scsi_transport_iscsi.h | -rw-r--r-- | 9.3 KB |
| scsi_transport_sas.h | -rw-r--r-- | 6.1 KB |
| scsi_transport_spi.h | -rw-r--r-- | 6.9 KB |
| scsi_transport_srp.h | -rw-r--r-- | 902 bytes |
| scsicam.h | -rw-r--r-- | 674 bytes |
| sg.h | -rw-r--r-- | 14.0 KB |
| srp.h | -rw-r--r-- | 5.5 KB |
Computing file changes ...
