Revision 7ce9d5d1f3c8736511daa413c64985a05b2feee3 authored by Eric Sandeen on 04 March 2009, 23:38:18 UTC, committed by Theodore Ts'o on 04 March 2009, 23:38:18 UTC
I was seeing fsck errors on inode bitmaps after a 4 thread dbench run on a 4 cpu machine: Inode bitmap differences: -50736 -(50752--50753) etc... I believe that this is because ext4_free_inode() uses atomic bitops, and although ext4_new_inode() *used* to also use atomic bitops for synchronization, commit 393418676a7602e1d7d3f6e560159c65c8cbd50e changed this to use the sb_bgl_lock, so that we could also synchronize against read_inode_bitmap and initialization of uninit inode tables. However, that change left ext4_free_inode using atomic bitops, which I think leaves no synchronization between setting & unsetting bits in the inode table. The below patch fixes it for me, although I wonder if we're getting at all heavy-handed with this spinlock... Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
1 parent fec6c6f
| File | Mode | Size |
|---|---|---|
| Kbuild | -rw-r--r-- | 210 bytes |
| ac97_codec.h | -rw-r--r-- | 27.7 KB |
| ad1816a.h | -rw-r--r-- | 5.1 KB |
| ad1843.h | -rw-r--r-- | 1.5 KB |
| ak4114.h | -rw-r--r-- | 10.0 KB |
| ak4117.h | -rw-r--r-- | 9.0 KB |
| ak4531_codec.h | -rw-r--r-- | 3.1 KB |
| ak4xxx-adda.h | -rw-r--r-- | 3.3 KB |
| asequencer.h | -rw-r--r-- | 24.2 KB |
| asound.h | -rw-r--r-- | 38.9 KB |
| asound_fm.h | -rw-r--r-- | 4.2 KB |
| asoundef.h | -rw-r--r-- | 13.9 KB |
| control.h | -rw-r--r-- | 5.8 KB |
| core.h | -rw-r--r-- | 14.9 KB |
| cs4231-regs.h | -rw-r--r-- | 8.3 KB |
| cs46xx.h | -rw-r--r-- | 72.0 KB |
| cs46xx_dsp_scb_types.h | -rw-r--r-- | 27.5 KB |
| cs46xx_dsp_spos.h | -rw-r--r-- | 6.1 KB |
| cs46xx_dsp_task_types.h | -rw-r--r-- | 7.1 KB |
| cs8403.h | -rw-r--r-- | 8.6 KB |
| cs8427.h | -rw-r--r-- | 10.3 KB |
| driver.h | -rw-r--r-- | 35 bytes |
| emu10k1.h | -rw-r--r-- | 104.6 KB |
| emu10k1_synth.h | -rw-r--r-- | 1.3 KB |
| emu8000.h | -rw-r--r-- | 4.0 KB |
| emu8000_reg.h | -rw-r--r-- | 10.2 KB |
| emux_legacy.h | -rw-r--r-- | 5.4 KB |
| emux_synth.h | -rw-r--r-- | 7.4 KB |
| es1688.h | -rw-r--r-- | 3.5 KB |
| gus.h | -rw-r--r-- | 20.2 KB |
| hda_hwdep.h | -rw-r--r-- | 1.4 KB |
| hdsp.h | -rw-r--r-- | 3.0 KB |
| hdspm.h | -rw-r--r-- | 4.0 KB |
| hwdep.h | -rw-r--r-- | 2.4 KB |
| i2c.h | -rw-r--r-- | 3.5 KB |
| info.h | -rw-r--r-- | 7.1 KB |
| initval.h | -rw-r--r-- | 2.8 KB |
| jack.h | -rw-r--r-- | 1.9 KB |
| l3.h | -rw-r--r-- | 287 bytes |
| memalloc.h | -rw-r--r-- | 3.8 KB |
| minors.h | -rw-r--r-- | 4.2 KB |
| mixer_oss.h | -rw-r--r-- | 2.3 KB |
| mpu401.h | -rw-r--r-- | 4.4 KB |
| opl3.h | -rw-r--r-- | 12.4 KB |
| opl4.h | -rw-r--r-- | 1.1 KB |
| pcm-indirect.h | -rw-r--r-- | 5.6 KB |
| pcm.h | -rw-r--r-- | 35.4 KB |
| pcm_oss.h | -rw-r--r-- | 2.6 KB |
| pcm_params.h | -rw-r--r-- | 7.7 KB |
| pt2258.h | -rw-r--r-- | 1.2 KB |
| pxa2xx-lib.h | -rw-r--r-- | 1.7 KB |
| rawmidi.h | -rw-r--r-- | 6.1 KB |
| s3c24xx_uda134x.h | -rw-r--r-- | 212 bytes |
| sb.h | -rw-r--r-- | 10.9 KB |
| sb16_csp.h | -rw-r--r-- | 5.5 KB |
| seq_device.h | -rw-r--r-- | 2.5 KB |
| seq_kernel.h | -rw-r--r-- | 4.2 KB |
| seq_midi_emul.h | -rw-r--r-- | 7.3 KB |
| seq_midi_event.h | -rw-r--r-- | 2.2 KB |
| seq_oss.h | -rw-r--r-- | 2.9 KB |
| seq_oss_legacy.h | -rw-r--r-- | 1.0 KB |
| seq_virmidi.h | -rw-r--r-- | 2.7 KB |
| sfnt_info.h | -rw-r--r-- | 7.2 KB |
| snd_wavefront.h | -rw-r--r-- | 5.5 KB |
| soc-dai.h | -rw-r--r-- | 6.6 KB |
| soc-dapm.h | -rw-r--r-- | 14.2 KB |
| soc-of-simple.h | -rw-r--r-- | 608 bytes |
| soc.h | -rw-r--r-- | 14.5 KB |
| soundfont.h | -rw-r--r-- | 4.5 KB |
| sscape_ioctl.h | -rw-r--r-- | 375 bytes |
| tea575x-tuner.h | -rw-r--r-- | 1.8 KB |
| tea6330t.h | -rw-r--r-- | 1.1 KB |
| timer.h | -rw-r--r-- | 5.4 KB |
| tlv.h | -rw-r--r-- | 2.3 KB |
| trident.h | -rw-r--r-- | 13.9 KB |
| uda1341.h | -rw-r--r-- | 1.9 KB |
| uda134x.h | -rw-r--r-- | 571 bytes |
| util_mem.h | -rw-r--r-- | 2.3 KB |
| version.h | -rw-r--r-- | 88 bytes |
| vx_core.h | -rw-r--r-- | 15.6 KB |
| wavefront.h | -rw-r--r-- | 18.8 KB |
| wss.h | -rw-r--r-- | 8.5 KB |
| ymfpci.h | -rw-r--r-- | 11.3 KB |
Computing file changes ...
