Revision 7ce9d5d1f3c8736511daa413c64985a05b2feee3 authored by Eric Sandeen on 04 March 2009, 23:38:18 UTC, committed by Theodore Ts'o on 04 March 2009, 23:38:18 UTC
I was seeing fsck errors on inode bitmaps after a 4 thread dbench run on a 4 cpu machine: Inode bitmap differences: -50736 -(50752--50753) etc... I believe that this is because ext4_free_inode() uses atomic bitops, and although ext4_new_inode() *used* to also use atomic bitops for synchronization, commit 393418676a7602e1d7d3f6e560159c65c8cbd50e changed this to use the sb_bgl_lock, so that we could also synchronize against read_inode_bitmap and initialization of uninit inode tables. However, that change left ext4_free_inode using atomic bitops, which I think leaves no synchronization between setting & unsetting bits in the inode table. The below patch fixes it for me, although I wonder if we're getting at all heavy-handed with this spinlock... Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
1 parent fec6c6f
| File | Mode | Size |
|---|---|---|
| Kbuild | -rw-r--r-- | 51 bytes |
| atmel_lcdc.h | -rw-r--r-- | 7.1 KB |
| aty128.h | -rw-r--r-- | 13.3 KB |
| cirrus.h | -rw-r--r-- | 5.6 KB |
| cvisionppc.h | -rw-r--r-- | 1.5 KB |
| cyblafb.h | -rw-r--r-- | 3.8 KB |
| edid.h | -rw-r--r-- | 284 bytes |
| epson1355.h | -rw-r--r-- | 2.4 KB |
| gbe.h | -rw-r--r-- | 10.5 KB |
| hecubafb.h | -rw-r--r-- | 1.5 KB |
| iga.h | -rw-r--r-- | 787 bytes |
| ili9320.h | -rw-r--r-- | 5.8 KB |
| kyro.h | -rw-r--r-- | 2.4 KB |
| mach64.h | -rw-r--r-- | 47.1 KB |
| maxinefb.h | -rw-r--r-- | 1.2 KB |
| mbxfb.h | -rw-r--r-- | 2.1 KB |
| metronomefb.h | -rw-r--r-- | 1.5 KB |
| neomagic.h | -rw-r--r-- | 4.9 KB |
| newport.h | -rw-r--r-- | 18.6 KB |
| permedia2.h | -rw-r--r-- | 9.0 KB |
| platform_lcd.h | -rw-r--r-- | 550 bytes |
| pm3fb.h | -rw-r--r-- | 45.3 KB |
| pmag-ba-fb.h | -rw-r--r-- | 1.0 KB |
| pmagb-b-fb.h | -rw-r--r-- | 2.3 KB |
| radeon.h | -rw-r--r-- | 109.7 KB |
| s1d13xxxfb.h | -rw-r--r-- | 9.8 KB |
| sgivw.h | -rw-r--r-- | 24.2 KB |
| sh_mobile_lcdc.h | -rw-r--r-- | 2.3 KB |
| sisfb.h | -rw-r--r-- | 7.7 KB |
| sstfb.h | -rw-r--r-- | 11.0 KB |
| tdfx.h | -rw-r--r-- | 4.7 KB |
| tgafb.h | -rw-r--r-- | 6.9 KB |
| trident.h | -rw-r--r-- | 3.2 KB |
| uvesafb.h | -rw-r--r-- | 3.7 KB |
| vga.h | -rw-r--r-- | 14.2 KB |
| w100fb.h | -rw-r--r-- | 3.7 KB |
Computing file changes ...
