https://github.com/torvalds/linux
Revision 7d1ce682d08625258524d23ef5eb9e7ae261c1d0 authored by Tejun Heo on 18 November 2005, 05:09:05 UTC, committed by Jeff Garzik on 18 November 2005, 18:11:39 UTC
When an error condition is raised by device via D2H FIS or SDB. sil24 controller should be restarted by setting PORT_CS_INIT and waiting until PORT_CS_RDY is asserted instead of resetting the controller. This patch implements sil24_restart_controller for those cases. This patch also makes sure that PORT_CS_RDY is asserted on sil24_reset_controller completion. Signed-off-by: Tejun Heo <htejun@gmail.com> -- Jeff, delay is reduced to 1us and cnt increased to 10k. My sil3124 turns on PORT_CS_RDY on the second iteration even without any delay. I think 10k * 1us should be more than enough. I tried to convert both restart and reset to use msleep's with work queue, but if we do that, host_set lock should be released after initiating restart or reset, leading to race condition among reset/restart, other interrupts and timeout. Implementing synchronization among those in low-level driver doesn't seem right. Well, reduced timeout should work for the time being. Thanks. Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
1 parent fc71fe4
Tip revision: 7d1ce682d08625258524d23ef5eb9e7ae261c1d0 authored by Tejun Heo on 18 November 2005, 05:09:05 UTC
[PATCH] sil24: add sil24_restart_controller
[PATCH] sil24: add sil24_restart_controller
Tip revision: 7d1ce68
| File | Mode | Size |
|---|---|---|
| Documentation | ||
| arch | ||
| block | ||
| crypto | ||
| drivers | ||
| fs | ||
| include | ||
| init | ||
| ipc | ||
| kernel | ||
| lib | ||
| mm | ||
| net | ||
| scripts | ||
| security | ||
| sound | ||
| usr | ||
| .gitignore | -rw-r--r-- | 391 bytes |
| COPYING | -rw-r--r-- | 18.3 KB |
| CREDITS | -rw-r--r-- | 87.2 KB |
| Kbuild | -rw-r--r-- | 1.2 KB |
| MAINTAINERS | -rw-r--r-- | 61.2 KB |
| Makefile | -rw-r--r-- | 42.8 KB |
| README | -rw-r--r-- | 14.7 KB |
| REPORTING-BUGS | -rw-r--r-- | 3.0 KB |
Computing file changes ...
