https://github.com/JuliaLang/julia
Revision 7d64f07b5062fc7634f7ef7158bc56d6cb6f214e authored by Keno Fischer on 13 March 2020, 02:20:29 UTC, committed by GitHub on 13 March 2020, 02:20:29 UTC
Previously if the library was not found, we would try to look for
the directory of an empty file, which ironicall does something almost
sensible:
```
$ gfortran -print-file-name=
/usr/lib/gcc/x86_64-linux-gnu/9/
```
Unfortunately, we then `dirname` the directory, stripping the last path
component. Often this is harmless, but on some systems, the 32bit path
is e.g. `/usr/lib/gcc/x86_64-linux-gnu/9/32/`, which can cause the
64 bit path to be copied instead of the 32 bit path. This is of course
only an issue if the appropriate runtime libraries are missing, but an
arch mismatch error is harder to debug than a missing libraries error
(as well as it being of course incorrect to copy the 64 bit libraries
to our build directory). This fixes fixup-libgfortran to no try and
look for the directory of an empty libname.
1 parent 558eec9
History
Tip revision: 7d64f07b5062fc7634f7ef7158bc56d6cb6f214e authored by Keno Fischer on 13 March 2020, 02:20:29 UTC
fixup-libgfortran: Bail out if libgfortran can't be found (#35096)
Tip revision: 7d64f07
File Mode Size
.devcontainer
base
contrib
deps
doc
etc
src
stdlib
test
ui
.appveyor.yml -rw-r--r-- 2.1 KB
.gitattributes -rw-r--r-- 65 bytes
.gitignore -rw-r--r-- 273 bytes
.mailmap -rw-r--r-- 11.0 KB
.travis.yml -rw-r--r-- 6.1 KB
CITATION.bib -rw-r--r-- 2.6 KB
CONTRIBUTING.md -rw-r--r-- 21.4 KB
HISTORY.md -rw-r--r-- 275.6 KB
LICENSE.md -rw-r--r-- 5.0 KB
Make.inc -rw-r--r-- 41.4 KB
Makefile -rw-r--r-- 27.1 KB
NEWS.md -rw-r--r-- 6.2 KB
README.md -rw-r--r-- 6.3 KB
VERSION -rw-r--r-- 10 bytes
sysimage.mk -rw-r--r-- 3.8 KB

README.md

back to top