Skip to main content

Browse the archive

Revision 7df9127088bda3c9d29937a04287b87dc2045ea7 authored by Dylan Hunn on 03 December 2021, 18:33:53 UTC, committed by Alex Rickabaugh on 10 December 2021, 22:13:24 UTC 
refactor(forms): Fix weak helper types in the Forms package, mostly `Function` types that can be strengthened to specific callbacks. This was originally proposed as part of Typed Forms, but it may be possible to submit at least some of these changes separately and unconditionally (i.e. without relying on `TypedOrUntyped`.) (#44370)
 
It is desirable to land this separately to reduce the scope of the Typed Forms PR, by focusing it only on the new type parameters (rather than incidental strictness fixes).

PR Close #44370
1 parent 78bdb1f
Raw File
review-pr 
#!/usr/bin/env node

const shell = require('shelljs');
shell.config.fatal = true;
const util = require('./utils/git_util');

if (require.main === module) {
  main(process.argv.splice(2)).then(
    (v) => process.exitCode = v, 
    (e) => console.error(process.exitCode = 1, e)
  );
}

async function main(args) {
  let prNumber = 0;

  args.forEach((arg) => {
    if (prNumber == 0 && arg > 0) {
        prNumber = arg;
    } else {
        shell.echo('Unexpected argument: ', arg);
    }
  });

  if (prNumber === 0) {
    shell.echo('Bring github pull request onto your local repo for review and edit');
    shell.echo('');
    shell.echo(`${process.argv[1]} PR_NUMBER`);
    shell.echo('');
    return 1;
  }

  if (util.gitHasLocalModifications()) {
    shell.echo('Local modification detected. exiting...');
    return 1;
  }

  let prShaCount = (await util.githubPrInfo(prNumber)).commits;

  shell.exec(`git checkout master`);
  if (util.execNoFatal(`git rev-parse --verify --quiet pr/${prNumber}`).code == 0) {
    shell.exec(`git branch -D pr/${prNumber}`);
  }

  shell.echo(`Fetching pull request #${prNumber} with ${prNumber} SHA(s) into branch range: pr/${prNumber}_base..pr/${prNumber}_top`);
  shell.exec(`git fetch -f git@github.com:angular/angular.git pull/${prNumber}/head:pr/${prNumber}_top`);

  shell.exec(`git branch -f pr/${prNumber}_bottom pr/${prNumber}_top~${prShaCount - 1}`);
  shell.exec(`git branch -f pr/${prNumber}_base pr/${prNumber}_top~${prShaCount}`);

  // Create aliases
  shell.exec(`git branch -f pr/TOP pr/${prNumber}_top`);
  shell.exec(`git branch -f pr/BASE pr/${prNumber}_base`);
  shell.exec(`git branch -f pr/BOTTOM pr/${prNumber}_bottom`);

  shell.echo(`======================================================================================`);
  shell.exec(`git log --oneline --color pr/${prNumber}_base..pr/${prNumber}_top`);
  shell.echo(`======================================================================================`);

  // Reset the HEAD so that we can see changed files for review
  shell.exec(`git checkout --force -b pr/${prNumber} pr/${prNumber}_top`);
  shell.exec(`git reset pr/${prNumber}_base`);
  shell.exec(`git status`);

  return 0;
}
back to top