Revision - 7e241f6 - libceph: fall back to sendmsg for slab pages - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

17 May 2024, 11:00:25 UTC

Revision 7e241f647dc7087a0401418a187f3f5b527cc690 authored by Ilya Dryomov on 08 November 2018, 14:55:37 UTC, committed by Ilya Dryomov on 19 November 2018, 16:59:47 UTC

libceph: fall back to sendmsg for slab pages

skb_can_coalesce() allows coalescing neighboring slab objects into
a single frag:

  return page == skb_frag_page(frag) &&
         off == frag->page_offset + skb_frag_size(frag);

ceph_tcp_sendpage() can be handed slab pages.  One example of this is
XFS: it passes down sector sized slab objects for its metadata I/O.  If
the kernel client is co-located on the OSD node, the skb may go through
loopback and pop on the receive side with the exact same set of frags.
When tcp_recvmsg() attempts to copy out such a frag, hardened usercopy
complains because the size exceeds the object's allocated size:

  usercopy: kernel memory exposure attempt detected from ffff9ba917f20a00 (kmalloc-512) (1024 bytes)

Although skb_can_coalesce() could be taught to return false if the
resulting frag would cross a slab object boundary, we already have
a fallback for non-refcounted pages.  Utilize it for slab pages too.

Cc: stable@vger.kernel.org # 4.8+
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

1 parent 9ff0119

Files
Changes

Permalinks

Tip revision: 7e241f647dc7087a0401418a187f3f5b527cc690 authored by Ilya Dryomov on 08 November 2018, 14:55:37 UTC
libceph: fall back to sendmsg for slab pages

Tip revision: 7e241f6

File	Mode	Size
Documentation
LICENSES
arch
block
certs
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.clang-format	-rw-r--r--	12.7 KB
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	31 bytes
.gitattributes	-rw-r--r--	30 bytes
.gitignore	-rw-r--r--	1.5 KB
.mailmap	-rw-r--r--	10.5 KB
COPYING	-rw-r--r--	423 bytes
CREDITS	-rw-r--r--	96.5 KB
Kbuild	-rw-r--r--	2.2 KB
Kconfig	-rw-r--r--	563 bytes
MAINTAINERS	-rw-r--r--	470.7 KB
Makefile	-rw-r--r--	59.7 KB
README	-rw-r--r--	727 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

libceph: fall back to sendmsg for slab pages

README