Skip to main content

Browse the archive

https://github.com/JuliaLang/julia
19 April 2024, 06:28:37 UTC
Revision 7e297def65c658bcc4f86521e04a15478c7cf402 authored by Tim Holy on 16 September 2023, 20:32:51 UTC, committed by Tim Holy on 16 September 2023, 20:32:51 UTC 
Make `min/max` use `isless` even for `Real`
 
In #23155, we made the generic `min/max` use `isless` rather than `<`.
This is motivated by the observation that the implementation

    min(a, b) = cmp(a, b) ? a : b

implies that `cmp` satisfies the same properties as `isless` (either
`cmp(a, b)` in which case we return `a`, otherwise either `cmp(b, a)`
or they are equal, in which case returning `b` is correct).

However, this is not true for `Real` types, including AbstractFloat
(due to `NaN`).

Part of the motivation here is that many packages seem to subtype
`Real` when, theoretically, perhaps they shouldn't. Prominent examples
include `IntervalArithmetic.Interval` and `ForwardDiff.Dual`.
1 parent ebe1a37
History
Tip revision: 7e297def65c658bcc4f86521e04a15478c7cf402 authored by Tim Holy on 16 September 2023, 20:32:51 UTC
Make `min/max` use `isless` even for `Real`
Tip revision: 7e297de
File Mode Size
trampolines
.gitignore -rw-r--r-- 33 bytes
Makefile -rw-r--r-- 8.1 KB
README.md -rw-r--r-- 4.1 KB
jl_exports.h -rw-r--r-- 2.2 KB
julia.expmap.in -rw-r--r-- 45 bytes
list_strip_symbols.h -rw-r--r-- 284 bytes
loader.h -rw-r--r-- 2.9 KB
loader_exe.c -rw-r--r-- 2.2 KB
loader_lib.c -rw-r--r-- 20.9 KB
loader_win_utils.c -rw-r--r-- 5.6 KB

README.md

back to top