sort by:
Revision Author Date Message Commit Date
416f870 Fix a typo in an SQL statement 08 October 2016, 12:02:18 UTC
5b5c954 pixelpipe_picker_helper(): if sampling just one point, make sure to actually sample it. Unification of codepaths broke it. It previously used <=, but now < is used. So we need to actually make sure that point results in bounding box of non-zero size. Fixes e.g. color picker in color zones iop. Reported-by: houz 07 October 2016, 12:32:48 UTC
17047df Fix error in lua api docs This was probably a copy&paste error. Note that the XML needs to be regenerated! 07 October 2016, 10:42:31 UTC
ac1ad45 opencl: follow-up or PR1279: this should fix color-picker for opencl 07 October 2016, 04:34:30 UTC
e988f75 Merge remote-tracking branch 'upstream/pr/1279' Color picker fixes. Spot whitebalance and spot invert was broken by un-demosaicing of preview pipe. This fixes it. According to @upegelow, OpenCL part of the changes is unsufficient. Since i have no opencl to fix it, and this already is much better than what git master currently have, i'm merging it as it is. Fixes #11163. Fixes #11164. * upstream/pr/1279: Invert iop: fix deadlock Invert iop: 4Bayer changes Temperature iop: spot wb: support 4Bayer Color picker: support 4Bayer. pixelpipe_picker_cl(): roi_copy: passthrough proper x,y Color picker: support picking from X-Trans mosaic Color picker: support picking from Bayer mosaic Color picker: refactor computations into worker, properly check input type pixelpipe_picker_cl(): use dt_iop_buffer_dsc_to_bpp() Color picker: take dt_iop_buffer_dsc_t* Pixelpipe: pixelpipe_picker{,_cl}: refactor common setup code into helper Refactor actual color picking into new .[CH] 06 October 2016, 21:03:42 UTC
40b6a4c Invert iop: fix deadlock 06 October 2016, 20:45:48 UTC
f71e2ce Invert iop: 4Bayer changes 06 October 2016, 20:45:48 UTC
cd2764f cmake/compiler-warnings: if gcc, enable -Wshadow only for gcc-5+ 06 October 2016, 16:16:27 UTC
a443729 CMake: fine-tune CHECK_COMPILER_FLAG_AND_ENABLE_IT() Acc. to #11199, in order to check some flags, we need to make sure to set other flags too. 06 October 2016, 16:16:27 UTC
598154a Conf.h: dt_conf_init(): avoid g_strdup_printf(), use macro. Avoids -Wformat-nonliteral warning 06 October 2016, 16:16:26 UTC
aa2070a CMake: drop modules which are already distributed by cmake-3.0.0 CMake's FindThreads.cmake looks strange. 06 October 2016, 16:16:25 UTC
82bd738 Temperature iop: spot wb: support 4Bayer 06 October 2016, 15:58:04 UTC
06098d1 Color picker: support 4Bayer. 06 October 2016, 15:58:04 UTC
ee18b95 pixelpipe_picker_cl(): roi_copy: passthrough proper x,y Should be important for mosaiced picker. 06 October 2016, 15:58:03 UTC
6b744f7 Color picker: support picking from X-Trans mosaic 06 October 2016, 15:58:03 UTC
c1f6fff Color picker: support picking from Bayer mosaic 06 October 2016, 15:58:03 UTC
e515ac1 Color picker: refactor computations into worker, properly check input type 06 October 2016, 15:58:03 UTC
0e60c00 pixelpipe_picker_cl(): use dt_iop_buffer_dsc_to_bpp() 06 October 2016, 15:58:03 UTC
cc91c6b Color picker: take dt_iop_buffer_dsc_t* 06 October 2016, 15:58:03 UTC
469401e Pixelpipe: pixelpipe_picker{,_cl}: refactor common setup code into helper 06 October 2016, 15:58:03 UTC
6e927f9 Refactor actual color picking into new .[CH] 06 October 2016, 15:57:58 UTC
cd58a33 CMake: lower stack/frame/object limits a bit 05 October 2016, 18:34:12 UTC
1f23822 Rawspeed: Cr2Decoder::decodeRawInternal(): don't stack-allocate LJpegPlain Was taking ~27Kb 05 October 2016, 18:34:12 UTC
779c5a3 Rawspeed: Rw2Decoder::decodeThreaded(): don't stack-allocate PanaBitpump() Was taking ~16Kb. 05 October 2016, 18:34:12 UTC
9491bbe dt_opencl_init(): don't stack [over-]allocate infointtab dt_opencl_init() uses ~40Kb stack. CL_DEVICE_MAX_WORK_ITEM_SIZES will probably return 3+ entries. Pre-allocating 1024 entries is wasteful, and does not actually protect us from overflow. Let's instead do malloc() FIXME: other places that get CL_DEVICE_MAX_WORK_ITEM_SIZES, use just size_t[3] buffer... 05 October 2016, 18:34:11 UTC
d699c74 Rawspeed: ArwDecoder::decodeRawInternal(): don't stack-allocate curve. Takes almost 40Kb. 05 October 2016, 18:34:11 UTC
6eadbde Rawspeed: NefDecoder::decodeRawInternal(): don't stack-allocate NikonDecompressor. Takes almost 140Kb. 05 October 2016, 18:34:10 UTC
6eb88ee Update French translation. 05 October 2016, 16:23:49 UTC
e369959 Fix memory corruption and crash (same as generate-cache). We need +1 for the last NULL parameter. I did not reproduced this one but it is the same issue as generate-cache. 05 October 2016, 15:48:18 UTC
5e22744 Fix memory corruption and crash. We need +1 for the last NULL parameter. 05 October 2016, 15:47:48 UTC
2d8570f Fix some -Wold-style-declaration warnings. It was enabled before, just wrongly 05 October 2016, 15:07:38 UTC
4773633 CMake rework: compiler warning flags cleanup 05 October 2016, 15:07:38 UTC
7f58d40 dt-chart: chart: parse_cht(): don't take sizeof() of malloc()'ed buf Coverity CID 1363761 05 October 2016, 13:16:50 UTC
a6e8bd1 Demosaic iop: process_vng_cl(): don't double-free ips in case of error Coverity CID 1363764 05 October 2016, 13:16:50 UTC
a312826 Rawoverexposed iop: process_cl(): actually properly free buf in case of errors Coverity CID 1363762 05 October 2016, 13:16:49 UTC
246b791 rawspeed-identify: be less C 05 October 2016, 12:35:51 UTC
6cd065d Rename dt_undo_clear_list to _undo_clear_list (static function). 05 October 2016, 12:22:12 UTC
4f1f133 Use DT_SIGNAL_DEVELOP_MODULE_REMOVE signal to invalidate history. 05 October 2016, 12:22:12 UTC
820546f Free memory leak in gui_cleanup. 05 October 2016, 12:22:12 UTC
1d889ca New routine dt_dev_invalidate_history_module. Tag all history's module to NULL (invalidated) for a given module. This is used when a module is removed. 05 October 2016, 12:22:12 UTC
9548ed3 Add new signal DT_SIGNAL_DEVELOP_MODULE_REMOVE. This signal is raised when a module is remove from the interface. It will be used to invalidate such module in the undo/redo history stack. 05 October 2016, 12:22:12 UTC
2b8bf1c Add missing field for DT_SIGNAL_VIEWMANAGER_FILMSTRIP_ACTIVATE 05 October 2016, 12:22:12 UTC
4734f7f Fix map undo/redo key accels. First for consistency with the darkroom, use the Ctrl-Y for redo. Also use two separate callbacks for undo and redo as the key accels can be redefined (we do not want to check explicitely for key accels). 05 October 2016, 12:22:12 UTC
17f9b4e Free memory where it is allocated. 05 October 2016, 12:22:12 UTC
e8caec5 Fix memory leak for undo items. 05 October 2016, 12:22:12 UTC
cfb8bcd Use malloc/free for undo data. 05 October 2016, 12:22:12 UTC
cb270ba Add undo/redo support for the darkroom. 05 October 2016, 12:22:12 UTC
13a374c Use dt_dev_free_history_item where possible. Minor code cleanup. We now have a single point where we free the history. 05 October 2016, 12:22:12 UTC
da400cb New function to free history params and blend_params. 05 October 2016, 12:22:12 UTC
8ed386d Allow a free callback for the undo clean-up. When cleaning the undo list we may want to pass a callback to free data passed recorded into the undo/redo lists. 05 October 2016, 12:22:12 UTC
64a40dc Fix wrong use of g_build_filename() Found by Jan Ingwer Baer. 05 October 2016, 11:29:13 UTC
984c3e7 Notify user when import/export is done Tell the window manager to draw the user's attention to dt when an import of a folder or an export is finished. Those two can take a long time to be processed so the user might want to do something else outside of dt in the meantime. Instead of listening to the CPU fan slowing down as an indication he will now be told by his window manager/desktop environment. On KDE for example the entry in the taskbar is highlighted. 05 October 2016, 11:09:08 UTC
a29c0b9 Fix a race when updating view while importing It could happen that the collection string was changed while the update was running. Minimize that by duplicating it early. This might still have a slight chance of SQL errors but those will be "fixed" by the next update. 05 October 2016, 11:06:35 UTC
e1d45ab [manpage] Fix some wordings Thank you Michel Leblond for spotting these. They just got lost due to being in the wrong bug tracker. Fixes #10710 05 October 2016, 10:19:03 UTC
1b789fc Merge pull request #1277 from michleb/master Update French translation of the user manual 05 October 2016, 09:44:46 UTC
e4e448e Merge branch 'master' of https://github.com/darktable-org/darktable 05 October 2016, 09:18:20 UTC
f0be74f French translation of some messages in the user manual after update of its English version 05 October 2016, 09:10:56 UTC
e59a411 Fix db update with degenerated tags+tagged_images 05 October 2016, 08:41:00 UTC
09a3de2 dt_lua_init_lock(): do lock-unlock too. Coverity is stupid. Coverity CID 1363059 05 October 2016, 07:55:12 UTC
f93ef9d Lua prefs: destroy_pref_element(): add missing break after case pref_enum: Coverity CID 1363058 05 October 2016, 07:52:36 UTC
7b72601 opencl: highlight reconstruction with lch mode for xtrans sensors 04 October 2016, 19:42:59 UTC
f572a27 Merge remote-tracking branch 'upstream/pr/1276' Dont be so stack greedy. Reduces stack pressure. Right now this only fixes unbound stack usage. No more unbound stack-based VLA's - mostly via -Wstack-usage After previous step, i looked at the -Wvla output, and almost none of them should actually be VLA, so i enabled -Wvla too and fixed the code. This is a preparatory work to support running on Musl libc. (pr #1086, refs #10541) It has default Thread stack size of 80k. There will be next steps. * upstream/pr/1276: (72 commits) CMake: make -Wvla warning a error. dt-chart: thinplate_match(): ignore VLA for now Png format: read_header(): no need for VLA. use #define Colormapping iop: kmeans(): ignore VLA for now Colortransfer iop: kmeans(): ignore VLA for now Clahe iop: process(): no need for VLA. use #define Denoiseprofile iop: process_wavelets(): no need for VLA. use #define Metadata view lib: _metadata_view_update_values(): no need for VLA. Recentcollect lib: _lib_recentcollection_updated(): no need for VLA. Focus: dt_focus_draw_clusters(): use malloc(), not VLA Cups_print: dt_get_papers(): no need for VLA. Imageio png: read_header(): no need for VLA. use #define CMake: let's also enable -Wvla CMake: make stack/object size warning a error. dt-view: don't do unbound stack-based VLA's dt-chart: thinplate: thinplate_match(): don't do unbound stack-based VLA's dt-chart: thinplate: solve(): don't do unbound stack-based VLA's dt-chart: parse_cht(): don't do unbound stack-based VLA's dt-chart: process_data(): don't do unbound stack-based VLA's dt-g-c: don't do unbound stack-based VLA's ... 04 October 2016, 18:17:46 UTC
735f5a5 CMake: make -Wvla warning a error. Now that all the issues i see are fixed, this is safe to do. 04 October 2016, 18:06:50 UTC
2817f11 dt-chart: thinplate_match(): ignore VLA for now 04 October 2016, 18:06:50 UTC
c8d3e35 Png format: read_header(): no need for VLA. use #define 04 October 2016, 18:06:50 UTC
f284078 Colormapping iop: kmeans(): ignore VLA for now 04 October 2016, 18:06:50 UTC
4d7a955 Colortransfer iop: kmeans(): ignore VLA for now 04 October 2016, 18:06:50 UTC
518a2dd Clahe iop: process(): no need for VLA. use #define 04 October 2016, 18:06:50 UTC
8088f2c Denoiseprofile iop: process_wavelets(): no need for VLA. use #define 04 October 2016, 18:06:50 UTC
0bd5206 Metadata view lib: _metadata_view_update_values(): no need for VLA. 04 October 2016, 18:06:50 UTC
872311a Recentcollect lib: _lib_recentcollection_updated(): no need for VLA. 04 October 2016, 18:06:49 UTC
a633f04 Focus: dt_focus_draw_clusters(): use malloc(), not VLA 04 October 2016, 18:06:49 UTC
a1763d0 Cups_print: dt_get_papers(): no need for VLA. 04 October 2016, 18:06:49 UTC
0839c1a Imageio png: read_header(): no need for VLA. use #define 04 October 2016, 18:06:49 UTC
df58e87 CMake: let's also enable -Wvla 04 October 2016, 18:06:49 UTC
7a0ed95 CMake: make stack/object size warning a error. Now that all the issues i see are fixed, this is safe to do. 04 October 2016, 18:06:49 UTC
c7cdbd8 dt-view: don't do unbound stack-based VLA's 04 October 2016, 18:06:49 UTC
aa83ea1 dt-chart: thinplate: thinplate_match(): don't do unbound stack-based VLA's 04 October 2016, 18:06:49 UTC
a17f31b dt-chart: thinplate: solve(): don't do unbound stack-based VLA's 04 October 2016, 18:06:48 UTC
c0f72e8 dt-chart: parse_cht(): don't do unbound stack-based VLA's 04 October 2016, 18:06:48 UTC
bd8235f dt-chart: process_data(): don't do unbound stack-based VLA's 04 October 2016, 18:06:48 UTC
3dcc78c dt-g-c: don't do unbound stack-based VLA's 04 October 2016, 18:06:48 UTC
a37034d dt-cli: don't do unbound stack-based VLA's 04 October 2016, 18:06:48 UTC
8d01bc1 Png format: write_image(): don't do unbound stack-based VLA's 04 October 2016, 18:06:48 UTC
5d1e7b1 Jpeg format: write_image(): don't do unbound stack-based VLA's 04 October 2016, 18:06:48 UTC
6b7410f Pdf format: write_image(): don't do unbound stack-based VLA's 04 October 2016, 18:06:47 UTC
95eb869 Demosaic iop: process_vng_cl(): don't do unbound stack-based VLA's Tes, this was technically not VLA, but gcc is stupid. 04 October 2016, 18:06:36 UTC
6b1c731 Fix merged PR 793 04 October 2016, 17:07:10 UTC
05ad5d3 Colormapping iop: process(): don't do unbound stack-based VLA's 04 October 2016, 17:07:04 UTC
b05a06d Colormapping iop: kmeans(): don't do unbound stack-based VLA's 04 October 2016, 17:07:04 UTC
d86b185 Colortransfer iop: process(): don't do unbound stack-based VLA's 04 October 2016, 17:07:04 UTC
ef01814 Colortransfer iop: kmeans(): don't do unbound stack-based VLA's 04 October 2016, 17:07:04 UTC
2bb5381 Clahe iop: process(): don't do unbound stack-based VLA's 04 October 2016, 17:07:04 UTC
d907060 Dither iop: process_random(): don't do unbound stack-based VLA's 04 October 2016, 17:07:04 UTC
f322e09 Vignette iop: process(): don't do unbound stack-based VLA's 04 October 2016, 17:07:03 UTC
2822336 Spots iop: process(): don't do unbound stack-based VLA's 04 October 2016, 17:07:03 UTC
f3bb208 Denoiseprofile iop: process_wavelets_cl(): don't do unbound stack-based VLA's 04 October 2016, 17:07:03 UTC
6c6dcf8 Soften iop: process_cl(): don't do unbound stack-based VLA's 04 October 2016, 17:07:03 UTC
51b353d Soften iop: process_sse2(): don't do unbound stack-based VLA's 04 October 2016, 17:07:03 UTC
5b65a08 Soften iop: process(): don't do unbound stack-based VLA's 04 October 2016, 17:07:03 UTC
back to top