Revision 7eeecc4b1f480c7ba1932cb9a7693f8c452640f2 authored by Samuel Holland on 03 January 2021, 11:17:41 UTC, committed by David S. Miller on 06 January 2021, 00:32:07 UTC
stmmac_pltfr_remove does three things in one function, making it inapproprate for unwinding the steps in the probe function. Currently, a failure before the call to stmmac_dvr_probe would leak OF node references due to missing a call to stmmac_remove_config_dt. And an error in stmmac_dvr_probe would cause the driver to attempt to remove a netdevice that was never added. Fix these by reordering the init and splitting out the error handling steps. Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i") Fixes: 40a1dcee2d18 ("net: ethernet: dwmac-sun8i: Use the correct function in exit path") Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Chen-Yu Tsai <wens@csie.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 55b7ab1
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 983 bytes |
Makefile | -rw-r--r-- | 409 bytes |
arpc.h | -rw-r--r-- | 1.3 KB |
bundle.c | -rw-r--r-- | 5.4 KB |
connection.c | -rw-r--r-- | 22.6 KB |
control.c | -rw-r--r-- | 13.9 KB |
core.c | -rw-r--r-- | 8.0 KB |
debugfs.c | -rw-r--r-- | 515 bytes |
es2.c | -rw-r--r-- | 33.4 KB |
greybus_trace.h | -rw-r--r-- | 12.1 KB |
hd.c | -rw-r--r-- | 5.6 KB |
interface.c | -rw-r--r-- | 28.9 KB |
manifest.c | -rw-r--r-- | 14.4 KB |
module.c | -rw-r--r-- | 4.9 KB |
operation.c | -rw-r--r-- | 35.0 KB |
svc.c | -rw-r--r-- | 34.8 KB |
svc_watchdog.c | -rw-r--r-- | 4.4 KB |
Computing file changes ...