Revision 7eeecc4b1f480c7ba1932cb9a7693f8c452640f2 authored by Samuel Holland on 03 January 2021, 11:17:41 UTC, committed by David S. Miller on 06 January 2021, 00:32:07 UTC
stmmac_pltfr_remove does three things in one function, making it inapproprate for unwinding the steps in the probe function. Currently, a failure before the call to stmmac_dvr_probe would leak OF node references due to missing a call to stmmac_remove_config_dt. And an error in stmmac_dvr_probe would cause the driver to attempt to remove a netdevice that was never added. Fix these by reordering the init and splitting out the error handling steps. Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i") Fixes: 40a1dcee2d18 ("net: ethernet: dwmac-sun8i: Use the correct function in exit path") Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Chen-Yu Tsai <wens@csie.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 55b7ab1
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 691 bytes |
Makefile | -rw-r--r-- | 452 bytes |
channel.c | -rw-r--r-- | 34.1 KB |
channel_mgmt.c | -rw-r--r-- | 39.4 KB |
connection.c | -rw-r--r-- | 11.5 KB |
hv.c | -rw-r--r-- | 7.1 KB |
hv_balloon.c | -rw-r--r-- | 45.0 KB |
hv_debugfs.c | -rw-r--r-- | 4.4 KB |
hv_fcopy.c | -rw-r--r-- | 10.8 KB |
hv_kvp.c | -rw-r--r-- | 20.9 KB |
hv_snapshot.c | -rw-r--r-- | 11.1 KB |
hv_trace.c | -rw-r--r-- | 114 bytes |
hv_trace.h | -rw-r--r-- | 10.5 KB |
hv_trace_balloon.h | -rw-r--r-- | 1.6 KB |
hv_util.c | -rw-r--r-- | 17.7 KB |
hv_utils_transport.c | -rw-r--r-- | 7.6 KB |
hv_utils_transport.h | -rw-r--r-- | 1.6 KB |
hyperv_vmbus.h | -rw-r--r-- | 12.2 KB |
ring_buffer.c | -rw-r--r-- | 16.5 KB |
vmbus_drv.c | -rw-r--r-- | 69.5 KB |
Computing file changes ...