Revision 7eeecc4b1f480c7ba1932cb9a7693f8c452640f2 authored by Samuel Holland on 03 January 2021, 11:17:41 UTC, committed by David S. Miller on 06 January 2021, 00:32:07 UTC
stmmac_pltfr_remove does three things in one function, making it inapproprate for unwinding the steps in the probe function. Currently, a failure before the call to stmmac_dvr_probe would leak OF node references due to missing a call to stmmac_remove_config_dt. And an error in stmmac_dvr_probe would cause the driver to attempt to remove a netdevice that was never added. Fix these by reordering the init and splitting out the error handling steps. Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i") Fixes: 40a1dcee2d18 ("net: ethernet: dwmac-sun8i: Use the correct function in exit path") Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Chen-Yu Tsai <wens@csie.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 55b7ab1
File | Mode | Size |
---|---|---|
fdp | ||
microread | ||
nfcmrvl | ||
nxp-nci | ||
pn533 | ||
pn544 | ||
s3fwrn5 | ||
st-nci | ||
st21nfca | ||
st95hf | ||
Kconfig | -rw-r--r-- | 1.8 KB |
Makefile | -rw-r--r-- | 590 bytes |
mei_phy.c | -rw-r--r-- | 8.4 KB |
mei_phy.h | -rw-r--r-- | 1.2 KB |
nfcsim.c | -rw-r--r-- | 9.9 KB |
port100.c | -rw-r--r-- | 42.1 KB |
trf7970a.c | -rw-r--r-- | 62.0 KB |
Computing file changes ...