Revision 7eeecc4b1f480c7ba1932cb9a7693f8c452640f2 authored by Samuel Holland on 03 January 2021, 11:17:41 UTC, committed by David S. Miller on 06 January 2021, 00:32:07 UTC
stmmac_pltfr_remove does three things in one function, making it inapproprate for unwinding the steps in the probe function. Currently, a failure before the call to stmmac_dvr_probe would leak OF node references due to missing a call to stmmac_remove_config_dt. And an error in stmmac_dvr_probe would cause the driver to attempt to remove a netdevice that was never added. Fix these by reordering the init and splitting out the error handling steps. Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i") Fixes: 40a1dcee2d18 ("net: ethernet: dwmac-sun8i: Use the correct function in exit path") Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Chen-Yu Tsai <wens@csie.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 55b7ab1
File | Mode | Size |
---|---|---|
unittest-data | ||
Kconfig | -rw-r--r-- | 2.3 KB |
Makefile | -rw-r--r-- | 624 bytes |
address.c | -rw-r--r-- | 27.1 KB |
base.c | -rw-r--r-- | 59.4 KB |
device.c | -rw-r--r-- | 8.6 KB |
dynamic.c | -rw-r--r-- | 22.7 KB |
fdt.c | -rw-r--r-- | 31.5 KB |
fdt_address.c | -rw-r--r-- | 6.2 KB |
irq.c | -rw-r--r-- | 18.6 KB |
kobj.c | -rw-r--r-- | 3.8 KB |
of_net.c | -rw-r--r-- | 3.4 KB |
of_numa.c | -rw-r--r-- | 3.9 KB |
of_private.h | -rw-r--r-- | 5.7 KB |
of_reserved_mem.c | -rw-r--r-- | 11.2 KB |
overlay.c | -rw-r--r-- | 33.9 KB |
pdt.c | -rw-r--r-- | 4.8 KB |
platform.c | -rw-r--r-- | 20.0 KB |
property.c | -rw-r--r-- | 40.0 KB |
resolver.c | -rw-r--r-- | 8.7 KB |
unittest.c | -rw-r--r-- | 92.3 KB |
Computing file changes ...