Revision 7eeecc4b1f480c7ba1932cb9a7693f8c452640f2 authored by Samuel Holland on 03 January 2021, 11:17:41 UTC, committed by David S. Miller on 06 January 2021, 00:32:07 UTC
stmmac_pltfr_remove does three things in one function, making it
inapproprate for unwinding the steps in the probe function. Currently,
a failure before the call to stmmac_dvr_probe would leak OF node
references due to missing a call to stmmac_remove_config_dt. And an
error in stmmac_dvr_probe would cause the driver to attempt to remove a
netdevice that was never added. Fix these by reordering the init and
splitting out the error handling steps.
Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
Fixes: 40a1dcee2d18 ("net: ethernet: dwmac-sun8i: Use the correct function in exit path")
Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 55b7ab1
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 338 bytes |
| bfa.h | -rw-r--r-- | 14.7 KB |
| bfa_core.c | -rw-r--r-- | 50.9 KB |
| bfa_cs.h | -rw-r--r-- | 7.1 KB |
| bfa_defs.h | -rw-r--r-- | 37.5 KB |
| bfa_defs_fcs.h | -rw-r--r-- | 14.0 KB |
| bfa_defs_svc.h | -rw-r--r-- | 47.3 KB |
| bfa_fc.h | -rw-r--r-- | 39.5 KB |
| bfa_fcbuild.c | -rw-r--r-- | 35.0 KB |
| bfa_fcbuild.h | -rw-r--r-- | 9.2 KB |
| bfa_fcpim.c | -rw-r--r-- | 94.2 KB |
| bfa_fcpim.h | -rw-r--r-- | 13.7 KB |
| bfa_fcs.c | -rw-r--r-- | 38.8 KB |
| bfa_fcs.h | -rw-r--r-- | 30.8 KB |
| bfa_fcs_fcpim.c | -rw-r--r-- | 21.2 KB |
| bfa_fcs_lport.c | -rw-r--r-- | 176.2 KB |
| bfa_fcs_rport.c | -rw-r--r-- | 87.8 KB |
| bfa_hw_cb.c | -rw-r--r-- | 4.3 KB |
| bfa_hw_ct.c | -rw-r--r-- | 3.7 KB |
| bfa_ioc.c | -rw-r--r-- | 159.9 KB |
| bfa_ioc.h | -rw-r--r-- | 32.4 KB |
| bfa_ioc_cb.c | -rw-r--r-- | 11.5 KB |
| bfa_ioc_ct.c | -rw-r--r-- | 26.6 KB |
| bfa_modules.h | -rw-r--r-- | 4.5 KB |
| bfa_plog.h | -rw-r--r-- | 4.1 KB |
| bfa_port.c | -rw-r--r-- | 19.4 KB |
| bfa_port.h | -rw-r--r-- | 3.8 KB |
| bfa_svc.c | -rw-r--r-- | 164.5 KB |
| bfa_svc.h | -rw-r--r-- | 25.3 KB |
| bfad.c | -rw-r--r-- | 45.5 KB |
| bfad_attr.c | -rw-r--r-- | 28.9 KB |
| bfad_bsg.c | -rw-r--r-- | 96.8 KB |
| bfad_bsg.h | -rw-r--r-- | 14.5 KB |
| bfad_debugfs.c | -rw-r--r-- | 12.1 KB |
| bfad_drv.h | -rw-r--r-- | 8.9 KB |
| bfad_im.c | -rw-r--r-- | 34.1 KB |
| bfad_im.h | -rw-r--r-- | 6.1 KB |
| bfi.h | -rw-r--r-- | 30.3 KB |
| bfi_ms.h | -rw-r--r-- | 21.6 KB |
| bfi_reg.h | -rw-r--r-- | 17.8 KB |
Computing file changes ...
