Revision 7eeecc4b1f480c7ba1932cb9a7693f8c452640f2 authored by Samuel Holland on 03 January 2021, 11:17:41 UTC, committed by David S. Miller on 06 January 2021, 00:32:07 UTC
stmmac_pltfr_remove does three things in one function, making it
inapproprate for unwinding the steps in the probe function. Currently,
a failure before the call to stmmac_dvr_probe would leak OF node
references due to missing a call to stmmac_remove_config_dt. And an
error in stmmac_dvr_probe would cause the driver to attempt to remove a
netdevice that was never added. Fix these by reordering the init and
splitting out the error handling steps.
Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
Fixes: 40a1dcee2d18 ("net: ethernet: dwmac-sun8i: Use the correct function in exit path")
Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 55b7ab1
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 226 bytes |
| Makefile | -rw-r--r-- | 243 bytes |
| atioctl.h | -rw-r--r-- | 31.0 KB |
| atvda.h | -rw-r--r-- | 34.5 KB |
| esas2r.h | -rw-r--r-- | 43.3 KB |
| esas2r_disc.c | -rw-r--r-- | 28.6 KB |
| esas2r_flash.c | -rw-r--r-- | 38.1 KB |
| esas2r_init.c | -rw-r--r-- | 44.3 KB |
| esas2r_int.c | -rw-r--r-- | 24.1 KB |
| esas2r_io.c | -rw-r--r-- | 23.1 KB |
| esas2r_ioctl.c | -rw-r--r-- | 50.6 KB |
| esas2r_log.c | -rw-r--r-- | 7.5 KB |
| esas2r_log.h | -rw-r--r-- | 4.3 KB |
| esas2r_main.c | -rw-r--r-- | 46.3 KB |
| esas2r_targdb.c | -rw-r--r-- | 7.4 KB |
| esas2r_vda.c | -rw-r--r-- | 13.5 KB |
Computing file changes ...
