| 7f0cce2 | Fons Rademakers | 13 July 2012, 12:19:20 UTC | tag patch release v5-34-01. git-svn-id: http://root.cern.ch/svn/root/tags/v5-34-01@45048 27541ba8-7e3a-0410-8455-c3a389f83636 | 13 July 2012, 12:19:20 UTC |
| f9a0be3 | Fons Rademakers | 13 July 2012, 09:43:09 UTC | remove obsolete modules PEAC and Clarens. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@45043 27541ba8-7e3a-0410-8455-c3a389f83636 | 13 July 2012, 09:43:09 UTC |
| d6b6569 | Fons Rademakers | 13 July 2012, 09:36:54 UTC | make version v5-34-01. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@45040 27541ba8-7e3a-0410-8455-c3a389f83636 | 13 July 2012, 09:36:54 UTC |
| 3d3bf1a | Fons Rademakers | 13 July 2012, 09:35:30 UTC | don't distclean stressRooStats_ref.root. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@45039 27541ba8-7e3a-0410-8455-c3a389f83636 | 13 July 2012, 09:35:30 UTC |
| 8099f62 | Fons Rademakers | 13 July 2012, 09:24:10 UTC | remove obsolete plugin manager entry. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@45037 27541ba8-7e3a-0410-8455-c3a389f83636 | 13 July 2012, 09:24:10 UTC |
| a33bff7 | Fons Rademakers | 13 July 2012, 09:22:05 UTC | remove obsolete modules PEAC and Clarens. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@45036 27541ba8-7e3a-0410-8455-c3a389f83636 | 13 July 2012, 09:22:05 UTC |
| 94efef1 | Philippe Canal | 12 July 2012, 17:15:14 UTC | Import revision 45033 from the trunk: Prevent the inadvertent re-use of a TTreeCache that has been deleted git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@45034 27541ba8-7e3a-0410-8455-c3a389f83636 | 12 July 2012, 17:15:14 UTC |
| 697d0ef | Andrei Gheata | 12 July 2012, 08:44:37 UTC | Replaced open time stamp from gSystem->Now() to time(0) to get the absolute epoch time instead of the local one git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@45017 27541ba8-7e3a-0410-8455-c3a389f83636 | 12 July 2012, 08:44:37 UTC |
| 09d9ab1 | Philippe Canal | 11 July 2012, 18:35:14 UTC | Import revision 45009 from the trunk: Make sure that when using makecintdll.sh dependent library are passed down and correctly put at the end of the link line git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@45010 27541ba8-7e3a-0410-8455-c3a389f83636 | 11 July 2012, 18:35:14 UTC |
| 232d67b | Lorenzo Moneta | 10 July 2012, 15:59:36 UTC | merge with trunk - revision 44989 - see http://root.cern.ch/viewvc?rev=44989&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44990 27541ba8-7e3a-0410-8455-c3a389f83636 | 10 July 2012, 15:59:36 UTC |
| 15f3b50 | Lorenzo Moneta | 10 July 2012, 08:36:13 UTC | merge from the trunk the patch from Axel: http://root.cern.ch/viewvc?view=rev&revision=44507 only in roofit to deal with removing using namespace std in Riostream.h add missing std to header files add using std to implementation files git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44982 27541ba8-7e3a-0410-8455-c3a389f83636 | 10 July 2012, 08:36:13 UTC |
| b868704 | Matevz Tadel | 09 July 2012, 23:28:12 UTC | Merge rev 44873 from trunk. Original Log: Implement somewhat continuous energy loss along track propagation. Needed for following CMS ID tracks reconstructed with the new generation tracking software that can reconstruct low-pT looping tracks. * TEveLine: Add function: Float_t CalculateLineLength() const; * TEveTrackPropagator: Add functions: Int_t GetCurrentPoint() const; Double_t GetTrackLength(Int_t start_point=0, Int_t end_point=-1) const; to give more info to propagation steering code. Consistent white-space. * TEveTrack: Add option to set energy loss over track length. This is applied at points where path-marks are set. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44981 27541ba8-7e3a-0410-8455-c3a389f83636 | 09 July 2012, 23:28:12 UTC |
| f999c51 | Lorenzo Moneta | 09 July 2012, 15:56:23 UTC | merge stressRooStats from the trunk, up to revision 44972 git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44977 27541ba8-7e3a-0410-8455-c3a389f83636 | 09 July 2012, 15:56:23 UTC |
| ff0b785 | Lorenzo Moneta | 09 July 2012, 15:55:45 UTC | merge stressRooStats from the trunk, up to revision 44972 git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44976 27541ba8-7e3a-0410-8455-c3a389f83636 | 09 July 2012, 15:55:45 UTC |
| 27bd40d | Lorenzo Moneta | 09 July 2012, 15:54:25 UTC | merge stressRooStats from the trunk, up to revision 44972 git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44975 27541ba8-7e3a-0410-8455-c3a389f83636 | 09 July 2012, 15:54:25 UTC |
| 3d999d1 | Lorenzo Moneta | 09 July 2012, 15:48:52 UTC | merge from trunk fixes 44662 and 44684 - improve MakeNuisancePdf ti support also cse of RooExtendedPdf - add in HybridCalculator an automatic way to find the constraint pdf from the model git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44974 27541ba8-7e3a-0410-8455-c3a389f83636 | 09 July 2012, 15:48:52 UTC |
| 906a7cc | Lorenzo Moneta | 09 July 2012, 15:14:47 UTC | merge from trunk fix http://root.cern.ch/viewvc?rev=44970&root=root&view=rev Log: do not truncate the number of expected events when generating an expected number of events from an extended Pdf in case of MultiGen git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44971 27541ba8-7e3a-0410-8455-c3a389f83636 | 09 July 2012, 15:14:47 UTC |
| cc463dd | Andrei Gheata | 09 July 2012, 12:46:51 UTC | Port of 44748 from trunk: TAlienFile extra info git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44969 27541ba8-7e3a-0410-8455-c3a389f83636 | 09 July 2012, 12:46:51 UTC |
| 8dbcef7 | Lorenzo Moneta | 09 July 2012, 09:34:54 UTC | merge with trunk - revision 44965 - see http://root.cern.ch/viewvc?rev=44965&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44966 27541ba8-7e3a-0410-8455-c3a389f83636 | 09 July 2012, 09:34:54 UTC |
| ee5f051 | Lorenzo Moneta | 06 July 2012, 13:39:16 UTC | merge with trunk - revision 44937 - see http://root.cern.ch/viewvc?rev=44937&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44938 27541ba8-7e3a-0410-8455-c3a389f83636 | 06 July 2012, 13:39:16 UTC |
| 4c1aad3 | Lorenzo Moneta | 05 July 2012, 17:08:03 UTC | merge with the trunk revision 44907 and 44917 http://root.cern.ch/viewvc?view=rev&revision=44907 http://root.cern.ch/viewvc?view=rev&revision=44917 git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44922 27541ba8-7e3a-0410-8455-c3a389f83636 | 05 July 2012, 17:08:03 UTC |
| 6e666ba | Philippe Canal | 04 July 2012, 14:54:02 UTC | Import revision 44881 from the trunk: Add better support for line continuation git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44886 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 July 2012, 14:54:02 UTC |
| ace0bb5 | Gerardo Ganis | 03 July 2012, 14:31:49 UTC | Import patch 44701 with important fixes in xproofd. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44863 27541ba8-7e3a-0410-8455-c3a389f83636 | 03 July 2012, 14:31:49 UTC |
| bf2f40c | Philippe Canal | 03 July 2012, 13:40:37 UTC | Import revision 44842 from the trunk: From Elvin, increase the cache efficient a bit git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44855 27541ba8-7e3a-0410-8455-c3a389f83636 | 03 July 2012, 13:40:37 UTC |
| 2849ec8 | Philippe Canal | 03 July 2012, 13:06:09 UTC | Import revision 44841 from the trunk: Add an explicit 'Close' for the read cache so that we can insure that all the (concurrent) outstanding connection/use of the TFile are closed before closing the file git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44849 27541ba8-7e3a-0410-8455-c3a389f83636 | 03 July 2012, 13:06:09 UTC |
| 0111d0f | Philippe Canal | 03 July 2012, 12:44:03 UTC | Import revision 44840 from the trunk: Avoid leaving a dangling TTreeCache if the user calls SetDirectory explicitly (in particular when setting it to zero) git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44846 27541ba8-7e3a-0410-8455-c3a389f83636 | 03 July 2012, 12:44:03 UTC |
| 4991413 | Philippe Canal | 03 July 2012, 10:46:14 UTC | Import revision 44838 from the trunk: Activate the input handler after we check for the -q to avoid a risk of calling Terminate twice git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44844 27541ba8-7e3a-0410-8455-c3a389f83636 | 03 July 2012, 10:46:14 UTC |
| 12b1b80 | Axel Naumann | 02 July 2012, 08:26:09 UTC | Import of r44826 from trunk. Resize fBrowsables to fNdimensions; allow fBrowsables to expand. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44827 27541ba8-7e3a-0410-8455-c3a389f83636 | 02 July 2012, 08:26:09 UTC |
| 2f3dcff | Andrei Gheata | 02 July 2012, 07:22:02 UTC | Port of technical fix to avoid dictionary warning from trunk #44824 git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44825 27541ba8-7e3a-0410-8455-c3a389f83636 | 02 July 2012, 07:22:02 UTC |
| e5897ad | Philippe Canal | 28 June 2012, 15:09:03 UTC | Import revision 44808 from the trunk: html target also requires asimage git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44809 27541ba8-7e3a-0410-8455-c3a389f83636 | 28 June 2012, 15:09:03 UTC |
| 0cf9fa5 | Axel Naumann | 28 June 2012, 12:17:27 UTC | Update addresses of email lists to ...@cern.ch git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44803 27541ba8-7e3a-0410-8455-c3a389f83636 | 28 June 2012, 12:17:27 UTC |
| 98ba891 | Philippe Canal | 28 June 2012, 12:12:04 UTC | Import revision 44800 from the trunk: Protect html target against missing X11 component git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44802 27541ba8-7e3a-0410-8455-c3a389f83636 | 28 June 2012, 12:12:04 UTC |
| 0256d52 | Axel Naumann | 28 June 2012, 11:51:43 UTC | Import of r44796 from trunk. Fix Solaris error: cstdlib pulls things into std::, not ::. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44799 27541ba8-7e3a-0410-8455-c3a389f83636 | 28 June 2012, 11:51:43 UTC |
| 2a00e38 | Philippe Canal | 28 June 2012, 07:34:43 UTC | Import revision 44792 from the trunk: makeloghtml.sh: Use root instead of root.exe to set ROOTSYS etc makehtml.sh: Add doc/reminder about not using -b Makefile: html target really needs to depend on everything if we want all the documentation! git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44793 27541ba8-7e3a-0410-8455-c3a389f83636 | 28 June 2012, 07:34:43 UTC |
| e299944 | Philippe Canal | 27 June 2012, 21:16:46 UTC | Import revision 44789 from the trunk: Following 44724 html now depends on ROOTX when it exist _and_ ROOTEXE git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44790 27541ba8-7e3a-0410-8455-c3a389f83636 | 27 June 2012, 21:16:46 UTC |
| 5c36a77 | Philippe Canal | 27 June 2012, 20:43:28 UTC | Import revision 44785 from the trunk: Add a non virtual SetEnablePrefetchingImpl to be called form the constructor and from the virtual SetEnablePrefetching. Make sure that even in the usual case (fEnablePrefetching == false), fAsyncReading is set. Add documentation in the new functions. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44786 27541ba8-7e3a-0410-8455-c3a389f83636 | 27 June 2012, 20:43:28 UTC |
| 280f49b | Matevz Tadel | 27 June 2012, 19:57:47 UTC | Merge the following revisions from trunk: 44693, 44694, 44695, 44783 44693 ===== Author: matevz Date: Thu Jun 14 20:53:13 2012 New Revision: 44693 URL: http://root.cern.ch/viewvc?rev=44693&root=root&view=rev Log: Implement arc-ball camera rotation. Use the 'a' key to switch between the standard (up-direction fixed) and arc-ball rotation modes. * TGLCamera Add functions RotateArcBall() and RotateArcBallRad(). Add member 'Bool_t fWasArBalled'. Check its state in standard Rotate function and fix up direction if needed. * TGLOrthoCamera, TGLPerspectiveCamera Use combined view matrix's third vector as the up direction. * TGLEventHandler Add arc-ball state variable and key-handling. Add logic for calling std vs arc-ball camera rotate function. * TGLSAViewer Document arc-ball key binding in help text. Modified: trunk/graf3d/gl/inc/TGLCamera.h trunk/graf3d/gl/inc/TGLEventHandler.h trunk/graf3d/gl/src/TGLCamera.cxx trunk/graf3d/gl/src/TGLEventHandler.cxx trunk/graf3d/gl/src/TGLOrthoCamera.cxx trunk/graf3d/gl/src/TGLPerspectiveCamera.cxx trunk/graf3d/gl/src/TGLSAViewer.cxx 44694 ===== Author: matevz Date: Fri Jun 15 02:17:09 2012 New Revision: 44694 URL: http://root.cern.ch/viewvc?rev=44694&root=root&view=rev Log: * TGLViewer Add function: TGLViewer::ReinitializeCurrentCamera(TGLVector3 fwd, TGLVector3 up); allowing the user to setup a non-standard camera base. Modified: trunk/graf3d/gl/inc/TGLViewer.h trunk/graf3d/gl/src/TGLViewer.cxx 44695 ===== Author: matevz Date: Fri Jun 15 03:01:39 2012 New Revision: 44695 URL: http://root.cern.ch/viewvc?rev=44695&root=root&view=rev Log: If creation of frame-buffer object for saving of a screenshot fails, fallback to using back-buffer. This can be disabled via the following rootrc setting: OpenGL.SavePictureFallbackToBB: off Latest SLC5, SLC6 intel/mesa drivers seem to be good at lying that they support FBOs and then flipping backwards once you ask them to cough up one. Modified: trunk/graf3d/gl/src/TGLViewer.cxx 44783 ===== Author: matevz Date: Wed Jun 27 19:58:47 2012 New Revision: 44783 URL: http://root.cern.ch/viewvc?rev=44783&root=root&view=rev Log: From Alja: Add new type of track path-mark - TEvePathMatk::kLineSegment. This is to be used for silicon strip detectors rec-hits, especially for low pT tracks where seaching for closest point of approach to a line segment is more roboust that searching for intersection with a plane. * TEvePathMark: Add new path-mark type. * TEveTrackPropagator, TEveTrack: Add support for the new path-mark type. * TEveTrackPropagatorEditor: Add GUI controls for fitting/showing line-segment path-marks. Modified: trunk/graf3d/eve/inc/TEvePathMark.h trunk/graf3d/eve/inc/TEveTrackPropagator.h trunk/graf3d/eve/inc/TEveTrackPropagatorEditor.h trunk/graf3d/eve/src/TEvePathMark.cxx trunk/graf3d/eve/src/TEveTrack.cxx trunk/graf3d/eve/src/TEveTrackPropagator.cxx trunk/graf3d/eve/src/TEveTrackPropagatorEditor.cxx ======================================================================== git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44784 27541ba8-7e3a-0410-8455-c3a389f83636 | 27 June 2012, 19:57:47 UTC |
| 8b7c674 | Lorenzo Moneta | 27 June 2012, 14:46:59 UTC | merge with trunk - revision 44770 - see http://root.cern.ch/viewvc?rev=44770&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44772 27541ba8-7e3a-0410-8455-c3a389f83636 | 27 June 2012, 14:46:59 UTC |
| e78a3e5 | Lorenzo Moneta | 27 June 2012, 14:46:48 UTC | merge with trunk - revision 44770 - see http://root.cern.ch/viewvc?rev=44770&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44771 27541ba8-7e3a-0410-8455-c3a389f83636 | 27 June 2012, 14:46:48 UTC |
| 604b238 | Lorenzo Moneta | 27 June 2012, 14:28:02 UTC | merge with trunk - revision 44768 - see http://root.cern.ch/viewvc?rev=44768&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44769 27541ba8-7e3a-0410-8455-c3a389f83636 | 27 June 2012, 14:28:02 UTC |
| b8654ba | Philippe Canal | 27 June 2012, 14:05:39 UTC | Import revision 44761 from the trunk: From Elvin (and Brian): I looked over the optimisation suggestions that you sent me and I implemented 4/5 of them. Below is the summary. 1) 60% of the time spent in TFileCacheRead::ReadBuffer is from TStorage::ReAllocChar. ReAllocChar spends 86% of its time in memcpy, 8% in alloc, and 6% in memset. It appears that, when a buffer is recycled, the contents of the old buffer (which are then overwritten) are copied over. I modified the call to ReAllocChar not to copy the old contents. Unfortunately, in my testing, this wasn't enough - later on in ReAllocChar, it zeros out the contents of the array, which has basically the same overhead as copying. There is no version of TStorage:ReAlloc that would satisfy the current requirements so I'm using the classic realloc for the TFPBlock buffer. 2) There are a few function calls that could be inlined which aren't inlined by the compiler (GCC 4.6.2). Particularly, TFPBlock::GetLen, TFPBlock::GetBuffer, TFPBlock::GetNoElem, and TFPBlock::GetPos. Done - I in-lined them explicitly, this should do the trick. 3) TTreeCache and TFilePrefetch both keep a sorted list of buffers that TFilePrefetch maintains. When TFileCacheRead::ReadBuffer is called, a binary search is called on both. We can eliminate one of the binary searches and save 3%. This would require some major changes and it would also affect the normal reading pattern (i.e. when reading without the prefetching enabled). I suggest to keep it as it is for the time being so that we maintain the compatibility with the normal reading without prefetching. 4) TFilePrefetch::ReadBuffer calculates the offset into the block's buffer (ptrInt) on-demand. You could probably win a few more percent here by pre-calculating these offsets for the TFPBlock. Done - added a new vector of relative offsets of the pieces in the buffer (in TFPBlock). 5) The deadlock issue. Done - I moved to a cleaner and simpler way to kill the thread by using cancellation. The deadlock situation was introduced in the last patch that I sent you when I was dealing with the TChain issue. The mutex locking was not related to the condition variable, but with the synchronisation with TChain. Brian: Thread cancellation scares the heck out of me - it's much harder to get correct than condition variables, and goes against most best practices. I'd much rather fixing the usage of conditions and have an explicit synchronization for killing the helpers. Elvin also reverted to classic condition variables and semaphores when killing the worker thread. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44763 27541ba8-7e3a-0410-8455-c3a389f83636 | 27 June 2012, 14:05:39 UTC |
| 8fe7ac9 | Philippe Canal | 26 June 2012, 20:56:33 UTC | From Brian: When hooking prefetching up into the CMSSW configuration system, I found the attached patch necessary. Without it, if you change the prefetch settings after the cache is created, I/O operations cause a segfault. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44755 27541ba8-7e3a-0410-8455-c3a389f83636 | 26 June 2012, 20:56:33 UTC |
| 5046f15 | Philippe Canal | 26 June 2012, 20:24:35 UTC | Import revision 44750 from the trunk: From Peter, Jack and Elvin: Indeed one can drop the unnecessary clearing of cache after looping through the collection of baskets. This affects in no way the prefetching. It was left it there for "historical" reasons, when trying to figure out how all the mechanism was working. The FillBuffer code is now pretty entangled and initially it was thought the prefetcher was using this to get the direction of the reads but no, this can be correctly established even without the clearing of the cache. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44752 27541ba8-7e3a-0410-8455-c3a389f83636 | 26 June 2012, 20:24:35 UTC |
| b0d04db | Philippe Canal | 26 June 2012, 20:14:56 UTC | Import revision 44749 from the trunk: Since TMemFile::ResetAfterMerge keeps the live object around, it does not need to delete the map of caches git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44751 27541ba8-7e3a-0410-8455-c3a389f83636 | 26 June 2012, 20:14:56 UTC |
| cf5315b | Axel Naumann | 26 June 2012, 08:37:30 UTC | Use absolute path for root to find it even from within tutorials/ git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44727 27541ba8-7e3a-0410-8455-c3a389f83636 | 26 June 2012, 08:37:30 UTC |
| b1915cf | Axel Naumann | 26 June 2012, 07:58:28 UTC | Import of r44724 from trunk. Use root instead of root.exe to set ROOTSYS etc git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44726 27541ba8-7e3a-0410-8455-c3a389f83636 | 26 June 2012, 07:58:28 UTC |
| a75a5fb | Philippe Canal | 25 June 2012, 17:23:21 UTC | Import revision 44719 from the trunk: Fix off by one error introduced in revision 43390 ; this fixes <http://savannah.cern.ch/bugs/?94910> (TChained Tree index returns wrong entry on GetEntryNumberWithIndex) git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44720 27541ba8-7e3a-0410-8455-c3a389f83636 | 25 June 2012, 17:23:21 UTC |
| af5fbcf | Philippe Canal | 25 June 2012, 17:15:52 UTC | Import revision 44710 from the trunk: From Matthew Straits: This fixes <http://savannah.cern.ch/patch/?5439>. I have a partially written file that ROOT crashes on when I try to read it, e.g. by Add()ing it to a TChain and then calling GetEntries(). The output is: Error in <TBasket::ReadObjWithBuffer>: Unknown class Error in <TBasket::ReadObjWithBuffer>: Unknown class *** Break *** segmentation violation I have traced this to a single line in TFile where there is an unchecked cast. Here is the fix: +++ io/io/src/TFile.cxx (working copy) @@ -1243,7 +1243,7 @@ return 0; } key->ReadKeyBuffer(buf); - list = (TList*)key->ReadObjWithBuffer(buffer); + list = dynamic_cast<TList*>(key->ReadObjWithBuffer(buffer)); if (list) list->SetOwner(); delete [] buffer; delete key; Now the output is: Info in <TFile::GetStreamerInfoList>: cannot find the StreamerInfo record in file broken.root There is no segfault and the rest of the TChain (in my example) can be read. I'm not sure that an Info message is really sufficient to inform the user that an input file isn't being read, but it's better than crashing, at least. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44718 27541ba8-7e3a-0410-8455-c3a389f83636 | 25 June 2012, 17:15:52 UTC |
| 5e838ad | Lorenzo Moneta | 25 June 2012, 15:06:01 UTC | merge with trunk - revision 44714 - see http://root.cern.ch/viewvc?rev=44714&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44715 27541ba8-7e3a-0410-8455-c3a389f83636 | 25 June 2012, 15:06:01 UTC |
| 15193f7 | Lorenzo Moneta | 15 June 2012, 10:04:53 UTC | merge with the trunk (revision 44696 and 44697) the changes in the ModelConfig::GetSnapshot merge also from trunk fix 44697 for stressRooStats git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44698 27541ba8-7e3a-0410-8455-c3a389f83636 | 15 June 2012, 10:04:53 UTC |
| 6c59a80 | Philippe Canal | 13 June 2012, 18:24:26 UTC | Import revision 44679 from the trunk: Restore support for the use case (exisinting in CMS code for example): TFile *input = new TFile(filename); TTree *tree; input.GetObject(treename,tree); TTreeCache *cache = new TTreeCache(tree,cachesize); input.SetCacheRead(cache); ..... read the tree ... input.SetCacheRead(0); delete cache; delete input; // This was leading to a double delete due to TFile::fReadCacheMap still holding a reference to the cache git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44680 27541ba8-7e3a-0410-8455-c3a389f83636 | 13 June 2012, 18:24:26 UTC |
| c6508f2 | Fons Rademakers | 13 June 2012, 15:23:46 UTC | if X11 is not enabled (iOS or native OSX) make sure that any explicitly specified X11 libs are unset. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44673 27541ba8-7e3a-0410-8455-c3a389f83636 | 13 June 2012, 15:23:46 UTC |
| 7365fce | Fons Rademakers | 13 June 2012, 13:29:55 UTC | remove -std=c++11 from .mm compilation rule. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44669 27541ba8-7e3a-0410-8455-c3a389f83636 | 13 June 2012, 13:29:55 UTC |
| 6cbe36e | Axel Naumann | 13 June 2012, 07:48:27 UTC | Add trailing newline (silence warning) git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44664 27541ba8-7e3a-0410-8455-c3a389f83636 | 13 June 2012, 07:48:27 UTC |
| 98abcd1 | Fons Rademakers | 11 June 2012, 15:09:10 UTC | From Pere: new client FindROOT.cmake file for people who want to build using cmake and use ROOT. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44649 27541ba8-7e3a-0410-8455-c3a389f83636 | 11 June 2012, 15:09:10 UTC |
| 18400e0 | Lorenzo Moneta | 11 June 2012, 09:18:22 UTC | merge with trunk - revision 44639 - see http://root.cern.ch/viewvc?rev=44639&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44641 27541ba8-7e3a-0410-8455-c3a389f83636 | 11 June 2012, 09:18:22 UTC |
| 6228b89 | Lorenzo Moneta | 11 June 2012, 07:10:22 UTC | fix an include git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44636 27541ba8-7e3a-0410-8455-c3a389f83636 | 11 June 2012, 07:10:22 UTC |
| 4ca8b0b | Lorenzo Moneta | 08 June 2012, 14:38:01 UTC | import from trunk fix 44630 (http://root.cern.ch/viewvc?rev=44630&root=root&view=rev) git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44631 27541ba8-7e3a-0410-8455-c3a389f83636 | 08 June 2012, 14:38:01 UTC |
| 4caa4c4 | Lorenzo Moneta | 08 June 2012, 07:03:29 UTC | merge with trunk - revision 44612 - see http://root.cern.ch/viewvc?rev=44612&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44613 27541ba8-7e3a-0410-8455-c3a389f83636 | 08 June 2012, 07:03:29 UTC |
| 7fb8626 | Philippe Canal | 07 June 2012, 21:33:49 UTC | Import revision 44609 from the trunk: In TBufferFile::WriteFastArray when the pointer are null, do not request the creation of a (missing) StreamerInfo when the class is abstract. This should fix <http://savannah.cern.ch/bugs/?95175>. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44610 27541ba8-7e3a-0410-8455-c3a389f83636 | 07 June 2012, 21:33:49 UTC |
| 17fa869 | Gerardo Ganis | 07 June 2012, 15:35:20 UTC | Import patch 44606 adding support for gcc4.7 in afdsmgrd git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44608 27541ba8-7e3a-0410-8455-c3a389f83636 | 07 June 2012, 15:35:20 UTC |
| d68cab3 | Lorenzo Moneta | 07 June 2012, 13:28:22 UTC | merge with trunk - revision 44600 - see http://root.cern.ch/viewvc?rev=44600&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44601 27541ba8-7e3a-0410-8455-c3a389f83636 | 07 June 2012, 13:28:22 UTC |
| 8b14336 | Lorenzo Moneta | 07 June 2012, 13:02:36 UTC | merge with trunk - revision 44598 - see http://root.cern.ch/viewvc?rev=44598&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44599 27541ba8-7e3a-0410-8455-c3a389f83636 | 07 June 2012, 13:02:36 UTC |
| d26269d | Fons Rademakers | 05 June 2012, 14:17:03 UTC | print reminder to update version number. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44575 27541ba8-7e3a-0410-8455-c3a389f83636 | 05 June 2012, 14:17:03 UTC |
| 599fd18 | Fons Rademakers | 05 June 2012, 14:16:49 UTC | update version number. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44574 27541ba8-7e3a-0410-8455-c3a389f83636 | 05 June 2012, 14:16:49 UTC |
| cc0d6fe | Fons Rademakers | 05 June 2012, 13:27:47 UTC | make version v5-34-00. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44569 27541ba8-7e3a-0410-8455-c3a389f83636 | 05 June 2012, 13:27:47 UTC |
| 57033c0 | Fons Rademakers | 05 June 2012, 12:44:12 UTC | correct html errors in release notes. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44566 27541ba8-7e3a-0410-8455-c3a389f83636 | 05 June 2012, 12:44:12 UTC |
| a59fd63 | Gerardo Ganis | 05 June 2012, 09:01:20 UTC | Import fix in TDataSetManager::ScanFile to handle propoerly local files (r44411, r44425) git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44555 27541ba8-7e3a-0410-8455-c3a389f83636 | 05 June 2012, 09:01:20 UTC |
| 2452089 | Axel Naumann | 05 June 2012, 06:42:58 UTC | Fix warning (shadowed var) git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44551 27541ba8-7e3a-0410-8455-c3a389f83636 | 05 June 2012, 06:42:58 UTC |
| f40693c | Lorenzo Moneta | 04 June 2012, 21:02:48 UTC | merge with trunk - revision 44548 - see http://root.cern.ch/viewvc?rev=44548&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44549 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 21:02:48 UTC |
| b770cf5 | Lorenzo Moneta | 04 June 2012, 20:49:10 UTC | merge with trunk - revision 44546 - see http://root.cern.ch/viewvc?rev=44546&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44547 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 20:49:10 UTC |
| 89db3a4 | Lorenzo Moneta | 04 June 2012, 20:35:06 UTC | merge with trunk - revision 44544 - see http://root.cern.ch/viewvc?rev=44544&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44545 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 20:35:06 UTC |
| e5d4a91 | Lorenzo Moneta | 04 June 2012, 20:25:32 UTC | merge with trunk - revision 44542 - see http://root.cern.ch/viewvc?rev=44542&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44543 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 20:25:32 UTC |
| dbabda5 | Philippe Canal | 04 June 2012, 20:18:03 UTC | Fix warning: comparison between signed and unsigned integer expressions git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44540 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 20:18:03 UTC |
| c3ccb35 | Philippe Canal | 04 June 2012, 19:46:24 UTC | Update release notes git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44538 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 19:46:24 UTC |
| 7351d61 | Philippe Canal | 04 June 2012, 18:12:53 UTC | Update release notes git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44535 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 18:12:53 UTC |
| fa7698f | Philippe Canal | 04 June 2012, 16:52:20 UTC | Import revision 44533 from the trunk: From Gerri and Bart Butler: Improve efficiency of TFileMerger when merging a single file by doing a TFile::Cp rather than a load/write of the objects. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44534 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 16:52:20 UTC |
| 67b2877 | Philippe Canal | 04 June 2012, 16:37:53 UTC | Import revision 44531 from the trunk: From Yuri Fisyak and Valeri Fine: TTable class does not detect changes in dimensions of arrays and it does not apply a schema evolution for these kind of objects. This patch introduces support for this. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44532 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 16:37:53 UTC |
| 6cf78a1 | Timur Pocheptsov | 04 June 2012, 16:25:19 UTC | Fix resource leak - release data provider, after mask image created. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44530 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 16:25:19 UTC |
| bb3b53a | Gerardo Ganis | 04 June 2012, 15:17:29 UTC | Import coverity-related fixes git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44523 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 15:17:29 UTC |
| 5af379b | Lorenzo Moneta | 04 June 2012, 14:56:30 UTC | merge with trunk - revision 44517 - see http://root.cern.ch/viewvc?rev=44517&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44519 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 14:56:30 UTC |
| ad2714f | Lorenzo Moneta | 04 June 2012, 14:56:20 UTC | merge with trunk - revision 44517 - see http://root.cern.ch/viewvc?rev=44517&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44518 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 14:56:20 UTC |
| 9cd8a8b | Lorenzo Moneta | 04 June 2012, 14:16:56 UTC | merge with trunk - revision 44511 - see http://root.cern.ch/viewvc?rev=44511&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44515 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 14:16:56 UTC |
| e7e9140 | Lorenzo Moneta | 04 June 2012, 12:58:50 UTC | merge with trunk - revision 44500 - see http://root.cern.ch/viewvc?rev=44500&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44509 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 12:58:50 UTC |
| 0387bed | Lorenzo Moneta | 04 June 2012, 12:58:03 UTC | merge with trunk - revision 44499 - see http://root.cern.ch/viewvc?rev=44499&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44508 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 12:58:03 UTC |
| b951f84 | Timur Pocheptsov | 04 June 2012, 11:37:36 UTC | Fix for dialogs from the trunk. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44505 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 11:37:36 UTC |
| 9ce3a8b | Fons Rademakers | 04 June 2012, 11:04:39 UTC | Fix comment in Start(), starting of an existing benchmark will resume the benchmark, not reset it. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44501 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 11:04:39 UTC |
| 69cd28d | Gerardo Ganis | 04 June 2012, 09:06:32 UTC | Import fixes for SECURE_CODING coverity issues git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44498 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 09:06:32 UTC |
| ca18659 | Timur Pocheptsov | 04 June 2012, 08:54:58 UTC | Mods from the trunk. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44497 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 08:54:58 UTC |
| 27c0aeb | Gerardo Ganis | 04 June 2012, 08:35:35 UTC | Import fix for TOCTOU coverity issues git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44492 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 08:35:35 UTC |
| 01962f1 | Fons Rademakers | 04 June 2012, 00:52:12 UTC | Give access to fInfos data member. Fixes issue #94297. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44489 27541ba8-7e3a-0410-8455-c3a389f83636 | 04 June 2012, 00:52:12 UTC |
| 4825fad | Fons Rademakers | 03 June 2012, 12:49:24 UTC | fix and depend and cleanup in the Module.mk. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44486 27541ba8-7e3a-0410-8455-c3a389f83636 | 03 June 2012, 12:49:24 UTC |
| 65d9bc1 | Fons Rademakers | 03 June 2012, 00:25:52 UTC | don't check for Fink/MacPorts on non-MacOS X platforms. Fixes issue 94509. git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44483 27541ba8-7e3a-0410-8455-c3a389f83636 | 03 June 2012, 00:25:52 UTC |
| 734e3a7 | Lorenzo Moneta | 02 June 2012, 10:10:40 UTC | merge with trunk - revision 44479 - see http://root.cern.ch/viewvc?rev=44479&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44482 27541ba8-7e3a-0410-8455-c3a389f83636 | 02 June 2012, 10:10:40 UTC |
| efee28a | Lorenzo Moneta | 02 June 2012, 10:10:17 UTC | merge with trunk - revision 44479 - see http://root.cern.ch/viewvc?rev=44479&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44480 27541ba8-7e3a-0410-8455-c3a389f83636 | 02 June 2012, 10:10:17 UTC |
| 2f75c65 | Lorenzo Moneta | 01 June 2012, 16:36:12 UTC | merge with trunk - revision 44475 - see http://root.cern.ch/viewvc?rev=44475&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44476 27541ba8-7e3a-0410-8455-c3a389f83636 | 01 June 2012, 16:36:12 UTC |
| 4034df7 | Lorenzo Moneta | 01 June 2012, 16:12:31 UTC | merge with trunk - revision 44472 - see http://root.cern.ch/viewvc?rev=44472&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44473 27541ba8-7e3a-0410-8455-c3a389f83636 | 01 June 2012, 16:12:31 UTC |
| 97e1046 | Lorenzo Moneta | 01 June 2012, 15:12:58 UTC | merge with trunk - revision 44469 - see http://root.cern.ch/viewvc?rev=44469&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44470 27541ba8-7e3a-0410-8455-c3a389f83636 | 01 June 2012, 15:12:58 UTC |
| d82955f | Lorenzo Moneta | 01 June 2012, 15:04:37 UTC | merge with trunk - revision 44465 - see http://root.cern.ch/viewvc?rev=44465&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44467 27541ba8-7e3a-0410-8455-c3a389f83636 | 01 June 2012, 15:04:37 UTC |
| 67c107c | Lorenzo Moneta | 01 June 2012, 15:02:51 UTC | merge with trunk - revision 44465 - see http://root.cern.ch/viewvc?rev=44465&root=root&view=rev git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@44466 27541ba8-7e3a-0410-8455-c3a389f83636 | 01 June 2012, 15:02:51 UTC |
