Skip to main content

Browse the archive

Revision 7f850b889dbd484d7dc082b9adc46a82764a840d authored by Yanqin Jin on 28 June 2018, 03:55:07 UTC, committed by Facebook Github Bot on 28 June 2018, 03:59:45 UTC 
Remove 'ALIGNAS' from StatisticsImpl. (#4061)
 
Summary:
Remove over-alignment on `StatisticsImpl` whose benefit is vague and causes UBSAN check to fail due to `std::make_shared` not respecting the over-alignment requirement.

Test plan
```
$ make clean && COMPILE_WITH_UBSAN=1 OPT=-g make -j16 ubsan_check
```
Closes https://github.com/facebook/rocksdb/pull/4061

Differential Revision: D8656506

Pulled By: riversand963

fbshipit-source-id: db355ae9c7bdd2c9e9c5e63cabba13d8d82cc5f9
1 parent 14f409c
Raw File
.lgtm.yml 
extraction:
  cpp:
    index:
      build_command: make static_lib
back to top