Revision - 7f9cfb3 - mm: build_zonelists(): move clear node_load[] to [...] - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

05 April 2024, 19:05:47 UTC

Revision 7f9cfb31030737a7fc9a1cbca3fd01bec184c849 authored by Bo Liu on 18 August 2009, 21:11:19 UTC, committed by Linus Torvalds on 18 August 2009, 23:31:13 UTC

mm: build_zonelists(): move clear node_load[] to __build_all_zonelists()

If node_load[] is cleared everytime build_zonelists() is
called,node_load[] will have no help to find the next node that should
appear in the given node's fallback list.

Because of the bug, zonelist's node_order is not calculated as expected.
This bug affects on big machine, which has asynmetric node distance.

[synmetric NUMA's node distance]
     0    1    2
0   10   12   12
1   12   10   12
2   12   12   10

[asynmetric NUMA's node distance]
     0    1    2
0   10   12   20
1   12   10   14
2   20   14   10

This (my bug) is very old but no one has reported this for a long time.
Maybe because the number of asynmetric NUMA is very small and they use
cpuset for customizing node memory allocation fallback.

[akpm@linux-foundation.org: fix CONFIG_NUMA=n build]
Signed-off-by: Bo Liu <bo-liu@hotmail.com>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Christoph Lameter <cl@linux-foundation.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 parent 503f794

Files
Changes

Permalinks

Tip revision: 7f9cfb31030737a7fc9a1cbca3fd01bec184c849 authored by Bo Liu on 18 August 2009, 21:11:19 UTC
mm: build_zonelists(): move clear node_load[] to __build_all_zonelists()

Tip revision: 7f9cfb3

File	Mode	Size
Documentation
arch
block
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.gitignore	-rw-r--r--	952 bytes
.mailmap	-rw-r--r--	3.9 KB
COPYING	-rw-r--r--	18.3 KB
CREDITS	-rw-r--r--	91.8 KB
Kbuild	-rw-r--r--	2.4 KB
MAINTAINERS	-rw-r--r--	148.6 KB
Makefile	-rw-r--r--	53.9 KB
README	-rw-r--r--	17.0 KB
REPORTING-BUGS	-rw-r--r--	3.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

mm: build_zonelists(): move clear node_load[] to __build_all_zonelists()

README