Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).

read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.

Fix this bug by replacing the rwlock with a mutex.

Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
History
File Mode Size
amdgpu
bridge
dp-mst
rfc
afbc.rst -rw-r--r-- 7.3 KB
backlight.rst -rw-r--r-- 247 bytes
driver-uapi.rst -rw-r--r-- 122 bytes
drivers.rst -rw-r--r-- 311 bytes
drm-client.rst -rw-r--r-- 295 bytes
drm-internals.rst -rw-r--r-- 7.6 KB
drm-kms-helpers.rst -rw-r--r-- 11.0 KB
drm-kms.rst -rw-r--r-- 17.9 KB
drm-mm.rst -rw-r--r-- 18.1 KB
drm-uapi.rst -rw-r--r-- 19.7 KB
i915.rst -rw-r--r-- 21.8 KB
index.rst -rw-r--r-- 388 bytes
introduction.rst -rw-r--r-- 5.3 KB
kms-properties.csv -rw-r--r-- 7.5 KB
komeda-kms.rst -rw-r--r-- 15.2 KB
mcde.rst -rw-r--r-- 287 bytes
meson.rst -rw-r--r-- 1.7 KB
msm-crash-dump.rst -rw-r--r-- 2.4 KB
pl111.rst -rw-r--r-- 261 bytes
tegra.rst -rw-r--r-- 7.2 KB
todo.rst -rw-r--r-- 25.8 KB
tve200.rst -rw-r--r-- 204 bytes
v3d.rst -rw-r--r-- 759 bytes
vc4.rst -rw-r--r-- 2.1 KB
vga-switcheroo.rst -rw-r--r-- 1.9 KB
vgaarbiter.rst -rw-r--r-- 8.0 KB
vkms.rst -rw-r--r-- 7.2 KB
xen-front.rst -rw-r--r-- 1010 bytes

back to top