Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).

read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.

Fix this bug by replacing the rwlock with a mutex.

Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
History
File Mode Size
completion.rst -rw-r--r-- 12.2 KB
index.rst -rw-r--r-- 369 bytes
sched-arch.rst -rw-r--r-- 2.8 KB
sched-bwc.rst -rw-r--r-- 10.8 KB
sched-capacity.rst -rw-r--r-- 15.9 KB
sched-deadline.rst -rw-r--r-- 36.7 KB
sched-design-CFS.rst -rw-r--r-- 9.6 KB
sched-domains.rst -rw-r--r-- 4.3 KB
sched-energy.rst -rw-r--r-- 19.5 KB
sched-nice-design.rst -rw-r--r-- 5.1 KB
sched-pelt.c -rw-r--r-- 2.0 KB
sched-rt-group.rst -rw-r--r-- 6.8 KB
sched-stats.rst -rw-r--r-- 7.4 KB
schedutil.txt -rw-r--r-- 5.9 KB
text_files.rst -rw-r--r-- 101 bytes

back to top