Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).

read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.

Fix this bug by replacing the rwlock with a mutex.

Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
History
File Mode Size
coresight
postprocess
boottime-trace.rst -rw-r--r-- 10.2 KB
events-kmem.rst -rw-r--r-- 5.4 KB
events-msr.rst -rw-r--r-- 783 bytes
events-nmi.rst -rw-r--r-- 1.6 KB
events-power.rst -rw-r--r-- 3.4 KB
events.rst -rw-r--r-- 39.8 KB
ftrace-design.rst -rw-r--r-- 14.7 KB
ftrace-uses.rst -rw-r--r-- 11.9 KB
ftrace.rst -rw-r--r-- 130.4 KB
function-graph-fold.vim -rw-r--r-- 1.3 KB
histogram-design.rst -rw-r--r-- 87.1 KB
histogram.rst -rw-r--r-- 153.6 KB
hwlat_detector.rst -rw-r--r-- 4.0 KB
index.rst -rw-r--r-- 491 bytes
intel_th.rst -rw-r--r-- 6.0 KB
kprobes.rst -rw-r--r-- 29.6 KB
kprobetrace.rst -rw-r--r-- 10.9 KB
mmiotrace.rst -rw-r--r-- 6.8 KB
osnoise-tracer.rst -rw-r--r-- 8.3 KB
ring-buffer-design.rst -rw-r--r-- 30.6 KB
stm.rst -rw-r--r-- 6.6 KB
sys-t.rst -rw-r--r-- 2.1 KB
timerlat-tracer.rst -rw-r--r-- 8.6 KB
tracepoint-analysis.rst -rw-r--r-- 12.1 KB
tracepoints.rst -rw-r--r-- 6.0 KB
uprobetracer.rst -rw-r--r-- 7.2 KB

back to top