Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).
read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.
Fix this bug by replacing the rwlock with a mutex.
Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
| File | Mode | Size |
|---|---|---|
| .kunitconfig | -rw-r--r-- | 63 bytes |
| Kconfig | -rw-r--r-- | 2.3 KB |
| Makefile | -rw-r--r-- | 434 bytes |
| assert.c | -rw-r--r-- | 6.1 KB |
| debugfs.c | -rw-r--r-- | 2.7 KB |
| debugfs.h | -rw-r--r-- | 722 bytes |
| executor.c | -rw-r--r-- | 6.7 KB |
| executor_test.c | -rw-r--r-- | 6.6 KB |
| kunit-example-test.c | -rw-r--r-- | 3.4 KB |
| kunit-test.c | -rw-r--r-- | 12.5 KB |
| string-stream-test.c | -rw-r--r-- | 1.4 KB |
| string-stream.c | -rw-r--r-- | 4.7 KB |
| string-stream.h | -rw-r--r-- | 1.2 KB |
| test.c | -rw-r--r-- | 19.2 KB |
| try-catch-impl.h | -rw-r--r-- | 628 bytes |
| try-catch.c | -rw-r--r-- | 2.8 KB |
Computing file changes ...
