Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).
read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.
Fix this bug by replacing the rwlock with a mutex.
Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
| File | Mode | Size |
|---|---|---|
| crush | ||
| Kconfig | -rw-r--r-- | 1.2 KB |
| Makefile | -rw-r--r-- | 472 bytes |
| armor.c | -rw-r--r-- | 1.9 KB |
| auth.c | -rw-r--r-- | 15.7 KB |
| auth_none.c | -rw-r--r-- | 3.1 KB |
| auth_none.h | -rw-r--r-- | 482 bytes |
| auth_x.c | -rw-r--r-- | 26.8 KB |
| auth_x.h | -rw-r--r-- | 1013 bytes |
| auth_x_protocol.h | -rw-r--r-- | 1.9 KB |
| buffer.c | -rw-r--r-- | 1.2 KB |
| ceph_common.c | -rw-r--r-- | 23.0 KB |
| ceph_hash.c | -rw-r--r-- | 2.9 KB |
| ceph_strings.c | -rw-r--r-- | 1.6 KB |
| cls_lock_client.c | -rw-r--r-- | 11.7 KB |
| crypto.c | -rw-r--r-- | 8.0 KB |
| crypto.h | -rw-r--r-- | 1.1 KB |
| debugfs.c | -rw-r--r-- | 12.3 KB |
| decode.c | -rw-r--r-- | 4.6 KB |
| messenger.c | -rw-r--r-- | 54.0 KB |
| messenger_v1.c | -rw-r--r-- | 38.9 KB |
| messenger_v2.c | -rw-r--r-- | 91.2 KB |
| mon_client.c | -rw-r--r-- | 38.2 KB |
| msgpool.c | -rw-r--r-- | 2.3 KB |
| osd_client.c | -rw-r--r-- | 147.1 KB |
| osdmap.c | -rw-r--r-- | 70.2 KB |
| pagelist.c | -rw-r--r-- | 4.0 KB |
| pagevec.c | -rw-r--r-- | 3.3 KB |
| snapshot.c | -rw-r--r-- | 1.6 KB |
| string_table.c | -rw-r--r-- | 2.2 KB |
| striper.c | -rw-r--r-- | 7.7 KB |
Computing file changes ...
