Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).
read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.
Fix this bug by replacing the rwlock with a mutex.
Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 376 bytes |
| bitset.c | -rw-r--r-- | 22.2 KB |
| bitset.h | -rw-r--r-- | 1.5 KB |
| cabletest.c | -rw-r--r-- | 9.6 KB |
| channels.c | -rw-r--r-- | 6.9 KB |
| coalesce.c | -rw-r--r-- | 13.7 KB |
| common.c | -rw-r--r-- | 22.2 KB |
| common.h | -rw-r--r-- | 1.9 KB |
| debug.c | -rw-r--r-- | 3.3 KB |
| eee.c | -rw-r--r-- | 5.1 KB |
| eeprom.c | -rw-r--r-- | 6.8 KB |
| features.c | -rw-r--r-- | 8.8 KB |
| fec.c | -rw-r--r-- | 8.2 KB |
| ioctl.c | -rw-r--r-- | 85.3 KB |
| linkinfo.c | -rw-r--r-- | 4.3 KB |
| linkmodes.c | -rw-r--r-- | 10.6 KB |
| linkstate.c | -rw-r--r-- | 4.4 KB |
| module.c | -rw-r--r-- | 4.5 KB |
| netlink.c | -rw-r--r-- | 29.3 KB |
| netlink.h | -rw-r--r-- | 17.0 KB |
| pause.c | -rw-r--r-- | 4.9 KB |
| phc_vclocks.c | -rw-r--r-- | 2.4 KB |
| privflags.c | -rw-r--r-- | 5.4 KB |
| rings.c | -rw-r--r-- | 6.2 KB |
| stats.c | -rw-r--r-- | 13.9 KB |
| strset.c | -rw-r--r-- | 11.8 KB |
| tsinfo.c | -rw-r--r-- | 3.7 KB |
| tunnels.c | -rw-r--r-- | 7.0 KB |
| wol.c | -rw-r--r-- | 4.3 KB |
Computing file changes ...
