Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).
read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.
Fix this bug by replacing the rwlock with a mutex.
Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 271 bytes |
| Makefile | -rw-r--r-- | 991 bytes |
| af_llc.c | -rw-r--r-- | 31.9 KB |
| llc_c_ac.c | -rw-r--r-- | 35.5 KB |
| llc_c_ev.c | -rw-r--r-- | 21.3 KB |
| llc_c_st.c | -rw-r--r-- | 151.9 KB |
| llc_conn.c | -rw-r--r-- | 27.4 KB |
| llc_core.c | -rw-r--r-- | 4.1 KB |
| llc_if.c | -rw-r--r-- | 4.5 KB |
| llc_input.c | -rw-r--r-- | 5.9 KB |
| llc_output.c | -rw-r--r-- | 2.0 KB |
| llc_pdu.c | -rw-r--r-- | 10.6 KB |
| llc_proc.c | -rw-r--r-- | 6.0 KB |
| llc_s_ac.c | -rw-r--r-- | 5.9 KB |
| llc_s_ev.c | -rw-r--r-- | 3.5 KB |
| llc_s_st.c | -rw-r--r-- | 5.7 KB |
| llc_sap.c | -rw-r--r-- | 11.3 KB |
| llc_station.c | -rw-r--r-- | 3.2 KB |
| sysctl_net_llc.c | -rw-r--r-- | 1.8 KB |
Computing file changes ...
