Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib() which, in turn, calls mutex_lock(&smc_ib_devices.mutex). read_lock() disables preemption. Therefore, the code acquires a mutex while in atomic context and it leads to a SAC bug. Fix this bug by replacing the rwlock with a mutex. Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support") Confirmed-by: Tony Lu <tonylu@linux.alibaba.com> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> Acked-by: Karsten Graul <kgraul@linux.ibm.com> Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1003 bytes |
Makefile | -rw-r--r-- | 421 bytes |
crypto.c | -rw-r--r-- | 2.4 KB |
crypto_test.c | -rw-r--r-- | 1.7 KB |
ctrl.c | -rw-r--r-- | 4.4 KB |
diag.c | -rw-r--r-- | 3.0 KB |
mib.c | -rw-r--r-- | 3.5 KB |
mib.h | -rw-r--r-- | 3.4 KB |
mptcp_diag.c | -rw-r--r-- | 3.5 KB |
options.c | -rw-r--r-- | 42.7 KB |
pm.c | -rw-r--r-- | 10.3 KB |
pm_netlink.c | -rw-r--r-- | 53.6 KB |
protocol.c | -rw-r--r-- | 93.6 KB |
protocol.h | -rw-r--r-- | 26.8 KB |
sockopt.c | -rw-r--r-- | 31.4 KB |
subflow.c | -rw-r--r-- | 49.5 KB |
syncookies.c | -rw-r--r-- | 3.7 KB |
token.c | -rw-r--r-- | 10.8 KB |
token_test.c | -rw-r--r-- | 4.0 KB |
Computing file changes ...