Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).
read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.
Fix this bug by replacing the rwlock with a mutex.
Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 2.2 KB |
| Makefile | -rw-r--r-- | 554 bytes |
| actions.c | -rw-r--r-- | 38.7 KB |
| conntrack.c | -rw-r--r-- | 60.4 KB |
| conntrack.h | -rw-r--r-- | 2.8 KB |
| datapath.c | -rw-r--r-- | 66.4 KB |
| datapath.h | -rw-r--r-- | 8.1 KB |
| dp_notify.c | -rw-r--r-- | 2.0 KB |
| flow.c | -rw-r--r-- | 24.7 KB |
| flow.h | -rw-r--r-- | 7.9 KB |
| flow_netlink.c | -rw-r--r-- | 96.6 KB |
| flow_netlink.h | -rw-r--r-- | 2.4 KB |
| flow_table.c | -rw-r--r-- | 29.5 KB |
| flow_table.h | -rw-r--r-- | 3.1 KB |
| meter.c | -rw-r--r-- | 18.2 KB |
| meter.h | -rw-r--r-- | 1.3 KB |
| openvswitch_trace.c | -rw-r--r-- | 248 bytes |
| openvswitch_trace.h | -rw-r--r-- | 5.6 KB |
| vport-geneve.c | -rw-r--r-- | 2.9 KB |
| vport-gre.c | -rw-r--r-- | 2.1 KB |
| vport-internal_dev.c | -rw-r--r-- | 5.8 KB |
| vport-internal_dev.h | -rw-r--r-- | 442 bytes |
| vport-netdev.c | -rw-r--r-- | 4.8 KB |
| vport-netdev.h | -rw-r--r-- | 539 bytes |
| vport-vxlan.c | -rw-r--r-- | 3.7 KB |
| vport.c | -rw-r--r-- | 12.6 KB |
| vport.h | -rw-r--r-- | 5.6 KB |
Computing file changes ...
