Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).
read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.
Fix this bug by replacing the rwlock with a mutex.
Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 2.8 KB |
| Makefile | -rw-r--r-- | 703 bytes |
| associola.c | -rw-r--r-- | 49.0 KB |
| auth.c | -rw-r--r-- | 26.6 KB |
| bind_addr.c | -rw-r--r-- | 13.9 KB |
| chunk.c | -rw-r--r-- | 9.5 KB |
| debug.c | -rw-r--r-- | 3.8 KB |
| diag.c | -rw-r--r-- | 13.7 KB |
| endpointola.c | -rw-r--r-- | 10.3 KB |
| input.c | -rw-r--r-- | 35.7 KB |
| inqueue.c | -rw-r--r-- | 6.4 KB |
| ipv6.c | -rw-r--r-- | 31.7 KB |
| objcnt.c | -rw-r--r-- | 2.8 KB |
| offload.c | -rw-r--r-- | 2.6 KB |
| output.c | -rw-r--r-- | 23.9 KB |
| outqueue.c | -rw-r--r-- | 55.5 KB |
| primitive.c | -rw-r--r-- | 6.7 KB |
| proc.c | -rw-r--r-- | 10.9 KB |
| protocol.c | -rw-r--r-- | 45.7 KB |
| sm_make_chunk.c | -rw-r--r-- | 116.9 KB |
| sm_sideeffect.c | -rw-r--r-- | 50.8 KB |
| sm_statefuns.c | -rw-r--r-- | 208.6 KB |
| sm_statetable.c | -rw-r--r-- | 34.3 KB |
| socket.c | -rw-r--r-- | 265.1 KB |
| stream.c | -rw-r--r-- | 26.5 KB |
| stream_interleave.c | -rw-r--r-- | 31.5 KB |
| stream_sched.c | -rw-r--r-- | 6.1 KB |
| stream_sched_prio.c | -rw-r--r-- | 8.4 KB |
| stream_sched_rr.c | -rw-r--r-- | 4.5 KB |
| sysctl.c | -rw-r--r-- | 14.9 KB |
| transport.c | -rw-r--r-- | 25.7 KB |
| tsnmap.c | -rw-r--r-- | 8.8 KB |
| ulpevent.c | -rw-r--r-- | 32.5 KB |
| ulpqueue.c | -rw-r--r-- | 28.7 KB |
Computing file changes ...
