Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).
read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.
Fix this bug by replacing the rwlock with a mutex.
Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 642 bytes |
| Makefile | -rw-r--r-- | 315 bytes |
| af_smc.c | -rw-r--r-- | 79.1 KB |
| smc.h | -rw-r--r-- | 9.5 KB |
| smc_cdc.c | -rw-r--r-- | 13.8 KB |
| smc_cdc.h | -rw-r--r-- | 8.3 KB |
| smc_clc.c | -rw-r--r-- | 32.3 KB |
| smc_clc.h | -rw-r--r-- | 13.0 KB |
| smc_close.c | -rw-r--r-- | 12.4 KB |
| smc_close.h | -rw-r--r-- | 759 bytes |
| smc_core.c | -rw-r--r-- | 65.7 KB |
| smc_core.h | -rw-r--r-- | 17.8 KB |
| smc_diag.c | -rw-r--r-- | 7.4 KB |
| smc_ib.c | -rw-r--r-- | 26.5 KB |
| smc_ib.h | -rw-r--r-- | 4.3 KB |
| smc_ism.c | -rw-r--r-- | 13.4 KB |
| smc_ism.h | -rw-r--r-- | 1.8 KB |
| smc_llc.c | -rw-r--r-- | 64.5 KB |
| smc_llc.h | -rw-r--r-- | 4.0 KB |
| smc_netlink.c | -rw-r--r-- | 3.2 KB |
| smc_netlink.h | -rw-r--r-- | 660 bytes |
| smc_netns.h | -rw-r--r-- | 381 bytes |
| smc_pnet.c | -rw-r--r-- | 30.1 KB |
| smc_pnet.h | -rw-r--r-- | 1.7 KB |
| smc_rx.c | -rw-r--r-- | 11.9 KB |
| smc_rx.h | -rw-r--r-- | 715 bytes |
| smc_stats.c | -rw-r--r-- | 11.0 KB |
| smc_stats.h | -rw-r--r-- | 7.4 KB |
| smc_tracepoint.c | -rw-r--r-- | 275 bytes |
| smc_tracepoint.h | -rw-r--r-- | 2.9 KB |
| smc_tx.c | -rw-r--r-- | 19.3 KB |
| smc_tx.h | -rw-r--r-- | 1.1 KB |
| smc_wr.c | -rw-r--r-- | 24.8 KB |
| smc_wr.h | -rw-r--r-- | 3.9 KB |
Computing file changes ...
