Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).
read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.
Fix this bug by replacing the rwlock with a mutex.
Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 2.5 KB |
| Makefile | -rw-r--r-- | 743 bytes |
| af_vsock.c | -rw-r--r-- | 57.9 KB |
| af_vsock_tap.c | -rw-r--r-- | 2.0 KB |
| diag.c | -rw-r--r-- | 4.0 KB |
| hyperv_transport.c | -rw-r--r-- | 23.4 KB |
| virtio_transport.c | -rw-r--r-- | 18.8 KB |
| virtio_transport_common.c | -rw-r--r-- | 32.1 KB |
| vmci_transport.c | -rw-r--r-- | 57.4 KB |
| vmci_transport.h | -rw-r--r-- | 3.7 KB |
| vmci_transport_notify.c | -rw-r--r-- | 17.8 KB |
| vmci_transport_notify.h | -rw-r--r-- | 2.5 KB |
| vmci_transport_notify_qstate.c | -rw-r--r-- | 11.1 KB |
| vsock_addr.c | -rw-r--r-- | 1.5 KB |
| vsock_loopback.c | -rw-r--r-- | 5.7 KB |
Computing file changes ...
