Revision 7ff57e98fb78ad94edafbdc7435f2d745e9e6bb5 authored by Fabio M. De Francesco on 23 February 2022, 10:02:52 UTC, committed by Jakub Kicinski on 24 February 2022, 17:09:33 UTC
smc_pnetid_by_table_ib() uses read_lock() and then it calls smc_pnet_apply_ib()
which, in turn, calls mutex_lock(&smc_ib_devices.mutex).
read_lock() disables preemption. Therefore, the code acquires a mutex while in
atomic context and it leads to a SAC bug.
Fix this bug by replacing the rwlock with a mutex.
Reported-and-tested-by: syzbot+4f322a6d84e991c38775@syzkaller.appspotmail.com
Fixes: 64e28b52c7a6 ("net/smc: add pnet table namespace support")
Confirmed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/r/20220223100252.22562-1-fmdefrancesco@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e13ad14
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 3.4 KB |
| Makefile | -rw-r--r-- | 530 bytes |
| espintcp.c | -rw-r--r-- | 12.6 KB |
| xfrm_algo.c | -rw-r--r-- | 14.5 KB |
| xfrm_compat.c | -rw-r--r-- | 19.3 KB |
| xfrm_device.c | -rw-r--r-- | 9.7 KB |
| xfrm_hash.c | -rw-r--r-- | 803 bytes |
| xfrm_hash.h | -rw-r--r-- | 4.6 KB |
| xfrm_inout.h | -rw-r--r-- | 1.8 KB |
| xfrm_input.c | -rw-r--r-- | 18.9 KB |
| xfrm_interface.c | -rw-r--r-- | 22.9 KB |
| xfrm_ipcomp.c | -rw-r--r-- | 7.4 KB |
| xfrm_output.c | -rw-r--r-- | 21.1 KB |
| xfrm_policy.c | -rw-r--r-- | 106.0 KB |
| xfrm_proc.c | -rw-r--r-- | 2.8 KB |
| xfrm_replay.c | -rw-r--r-- | 18.5 KB |
| xfrm_state.c | -rw-r--r-- | 68.4 KB |
| xfrm_sysctl.c | -rw-r--r-- | 1.9 KB |
| xfrm_user.c | -rw-r--r-- | 84.8 KB |
Computing file changes ...
